All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Kloudifold <cloudifold.3125@gmail.com>,
	teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com,
	gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	outreachy@lists.linux.dev
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase
Date: Tue, 14 Mar 2023 11:55:02 +0700	[thread overview]
Message-ID: <ZA/+JlgWfdg2wH8B@debian.me> (raw)
In-Reply-To: <ZA+K6OdPe21k8F2k@CloudiRingWorld>

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

On Tue, Mar 14, 2023 at 04:43:20AM +0800, Kloudifold wrote:
> The sm750 driver had some functions named in CamelCase,
> which violates the kernel's naming convention.
> In this patch, I rename these functions to snake case,
> which is the expected style.
> 
> This v2 patch was prompted by an error reported by the
> Linux test robot, which detected the compile error.
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/

Hi,

I'd like to write the patch description as (ignore markdown):

```
sm750 driver has sm750_hw_cursor_* functions, which are named in
camelcase. Rename them to snake case to follow the function naming
convention.

Fixes: <commit that introduces these camelcase function>
```

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2023-03-14  4:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 20:43 [PATCH v2] staging: sm750: Rename function to avoid CamelCase Kloudifold
2023-03-13 20:54 ` Julia Lawall
2023-03-14  0:07 ` Philipp Hortmann
2023-03-14 16:04   ` Alison Schofield
2023-03-14 16:39     ` Greg KH
2023-03-14  4:55 ` Bagas Sanjaya [this message]
2023-03-14 15:29   ` Alison Schofield
2023-03-15  3:08     ` Bagas Sanjaya
2023-03-15  4:54       ` Greg KH
2023-03-15  8:27         ` Bagas Sanjaya
2023-03-14 15:44 ` Alison Schofield
2023-03-14 15:46   ` Alison Schofield
  -- strict thread matches above, loose matches on Subject: below --
2023-03-15 15:35 Kloudifold
2023-03-15 15:43 ` Julia Lawall
2023-03-15 16:13 ` Deepak R Varma
2023-03-16  2:48 ` Bagas Sanjaya
2023-03-18  5:14   ` Ira Weiny
2023-03-18  8:50     ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZA/+JlgWfdg2wH8B@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=cloudifold.3125@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.