From: Greg KH <gregkh@linuxfoundation.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
Kloudifold <cloudifold.3125@gmail.com>,
teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase
Date: Wed, 15 Mar 2023 05:54:53 +0100 [thread overview]
Message-ID: <ZBFPnZbvdI46Ah6r@kroah.com> (raw)
In-Reply-To: <5fd67671-8e21-ffa8-8571-d8b5533b4758@gmail.com>
On Wed, Mar 15, 2023 at 10:08:27AM +0700, Bagas Sanjaya wrote:
> On 3/14/23 22:29, Alison Schofield wrote:
> >> Fixes: <commit that introduces these camelcase function>
> >> ```
> >
> > Why are you asking for a Fixes tag on this?
> > Seems unusual for a staging driver cleanup.
> >
>
> I thought this style cleanup also warrants Fixes: since
> it fixes coding style problem on existing code (see
> Documentation/process/submitting-patches.rst).
No, sorry, Fixes: is for real bugs, not style issues.
next prev parent reply other threads:[~2023-03-15 4:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 20:43 [PATCH v2] staging: sm750: Rename function to avoid CamelCase Kloudifold
2023-03-13 20:54 ` Julia Lawall
2023-03-14 0:07 ` Philipp Hortmann
2023-03-14 16:04 ` Alison Schofield
2023-03-14 16:39 ` Greg KH
2023-03-14 4:55 ` Bagas Sanjaya
2023-03-14 15:29 ` Alison Schofield
2023-03-15 3:08 ` Bagas Sanjaya
2023-03-15 4:54 ` Greg KH [this message]
2023-03-15 8:27 ` Bagas Sanjaya
2023-03-14 15:44 ` Alison Schofield
2023-03-14 15:46 ` Alison Schofield
-- strict thread matches above, loose matches on Subject: below --
2023-03-15 15:35 Kloudifold
2023-03-15 15:43 ` Julia Lawall
2023-03-15 16:13 ` Deepak R Varma
2023-03-16 2:48 ` Bagas Sanjaya
2023-03-18 5:14 ` Ira Weiny
2023-03-18 8:50 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBFPnZbvdI46Ah6r@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alison.schofield@intel.com \
--cc=bagasdotme@gmail.com \
--cc=cloudifold.3125@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.