All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kubiak <michal.kubiak@intel.com>
To: Stefan Assmann <sassmann@kpanic.de>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
	intel-wired-lan@lists.osuosl.org, patryk.piotrowski@intel.com,
	slawomirx.laba@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net] iavf: fix hang on reboot with ice
Date: Mon, 13 Mar 2023 10:15:21 +0100	[thread overview]
Message-ID: <ZA7pqdS04x0T7ExN@localhost.localdomain> (raw)
In-Reply-To: <9f1e4087-239e-3a1a-dc35-59a4680e676b@kpanic.de>

On Mon, Mar 13, 2023 at 07:48:52AM +0100, Stefan Assmann wrote:
> 
> Hi Michal,
> 
> is it okay to add this change in a follow-up patch? I'd like to get this
> patch merged quickly since we have a customer being blocked by this
> issue.
> 
> Thanks!
> 
>   Stefan


Hi Stefan,

I think it is OK.
Moreover, I consulted that idea with Slawomir Laba - the author of that loop.
It seems adding a timeout needs a further investigation. Slawomir claims
that adding that timeout may cause some side effects in other corner cases,
so for now let's leave your patch as it is.
Thank you for fixing it!

Thanks,
Michal

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Michal Kubiak <michal.kubiak@intel.com>
To: Stefan Assmann <sassmann@kpanic.de>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<anthony.l.nguyen@intel.com>, <patryk.piotrowski@intel.com>,
	<slawomirx.laba@intel.com>
Subject: Re: [PATCH net] iavf: fix hang on reboot with ice
Date: Mon, 13 Mar 2023 10:15:21 +0100	[thread overview]
Message-ID: <ZA7pqdS04x0T7ExN@localhost.localdomain> (raw)
In-Reply-To: <9f1e4087-239e-3a1a-dc35-59a4680e676b@kpanic.de>

On Mon, Mar 13, 2023 at 07:48:52AM +0100, Stefan Assmann wrote:
> 
> Hi Michal,
> 
> is it okay to add this change in a follow-up patch? I'd like to get this
> patch merged quickly since we have a customer being blocked by this
> issue.
> 
> Thanks!
> 
>   Stefan


Hi Stefan,

I think it is OK.
Moreover, I consulted that idea with Slawomir Laba - the author of that loop.
It seems adding a timeout needs a further investigation. Slawomir claims
that adding that timeout may cause some side effects in other corner cases,
so for now let's leave your patch as it is.
Thank you for fixing it!

Thanks,
Michal

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>


  reply	other threads:[~2023-03-13 15:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 12:26 [Intel-wired-lan] [PATCH net] iavf: fix hang on reboot with ice Stefan Assmann
2023-03-10 12:26 ` Stefan Assmann
2023-03-10 17:24 ` [Intel-wired-lan] " Michal Kubiak
2023-03-10 17:24   ` Michal Kubiak
2023-03-13  6:48   ` [Intel-wired-lan] " Stefan Assmann
2023-03-13  6:48     ` Stefan Assmann
2023-03-13  9:15     ` Michal Kubiak [this message]
2023-03-13  9:15       ` Michal Kubiak
2023-03-13 14:52       ` [Intel-wired-lan] " Stefan Assmann
2023-03-13 14:52         ` Stefan Assmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZA7pqdS04x0T7ExN@localhost.localdomain \
    --to=michal.kubiak@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=patryk.piotrowski@intel.com \
    --cc=sassmann@kpanic.de \
    --cc=slawomirx.laba@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.