From: Oliver Upton <oliver.upton@linux.dev>
To: Reiji Watanabe <reijiw@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
kvmarm@lists.linux.dev, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ricardo Koller <ricarkol@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 0/2] KVM: arm64: PMU: Preserve vPMC registers properly on migration
Date: Mon, 13 Mar 2023 18:04:07 +0000 [thread overview]
Message-ID: <ZA9llyTSgLcV2a1s@linux.dev> (raw)
In-Reply-To: <20230313032905.1474705-1-reijiw@google.com>
Hi Reiji,
On Sun, Mar 12, 2023 at 08:29:03PM -0700, Reiji Watanabe wrote:
> The series fixes two problems in preserving vPMU counter (vPMC)
> registers (PMCCNTR_EL0/PMEVCNTR<n>_EL0) during migration.
>
> One of the problems is that KVM may not return the current values
> of the vPMC registers for KVM_GET_ONE_REG.
>
> The other one might cause KVM to reset the vPMC registers on the
> first KVM_RUN on the destination. This is because userspace might
> save PMCR_EL0 with PMCR_EL0.{C,P} bits set on the source, and
> restore it on the destination.
>
> See patch-1 and patch-2 for details on these issues respectively.
>
> The series is based on v6.3-rc2.
>
> v2:
> - Collect Marc's r-b tags (Thank you!)
> - Added "Fixes:" tags
> - Added Cc: to stable
> - Cosmetics change (remove one line break in kvm_pmu_handle_pmcr())
>
> v1: https://lore.kernel.org/all/20230302055033.3081456-1-reijiw@google.com/
>
> Reiji Watanabe (2):
> KVM: arm64: PMU: Fix GET_ONE_REG for vPMC regs to return the current
> value
> KVM: arm64: PMU: Don't save PMCR_EL0.{C,P} for the vCPU
I received both of these patches as indepentent emails instead of replies to
the cover letter (i.e. In-Reply-To header is missing). I was able to find
both patches but just wanted to let you know so you can debug your tooling.
--
Thanks,
Oliver
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Upton <oliver.upton@linux.dev>
To: Reiji Watanabe <reijiw@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
kvmarm@lists.linux.dev, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ricardo Koller <ricarkol@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 0/2] KVM: arm64: PMU: Preserve vPMC registers properly on migration
Date: Mon, 13 Mar 2023 18:04:07 +0000 [thread overview]
Message-ID: <ZA9llyTSgLcV2a1s@linux.dev> (raw)
In-Reply-To: <20230313032905.1474705-1-reijiw@google.com>
Hi Reiji,
On Sun, Mar 12, 2023 at 08:29:03PM -0700, Reiji Watanabe wrote:
> The series fixes two problems in preserving vPMU counter (vPMC)
> registers (PMCCNTR_EL0/PMEVCNTR<n>_EL0) during migration.
>
> One of the problems is that KVM may not return the current values
> of the vPMC registers for KVM_GET_ONE_REG.
>
> The other one might cause KVM to reset the vPMC registers on the
> first KVM_RUN on the destination. This is because userspace might
> save PMCR_EL0 with PMCR_EL0.{C,P} bits set on the source, and
> restore it on the destination.
>
> See patch-1 and patch-2 for details on these issues respectively.
>
> The series is based on v6.3-rc2.
>
> v2:
> - Collect Marc's r-b tags (Thank you!)
> - Added "Fixes:" tags
> - Added Cc: to stable
> - Cosmetics change (remove one line break in kvm_pmu_handle_pmcr())
>
> v1: https://lore.kernel.org/all/20230302055033.3081456-1-reijiw@google.com/
>
> Reiji Watanabe (2):
> KVM: arm64: PMU: Fix GET_ONE_REG for vPMC regs to return the current
> value
> KVM: arm64: PMU: Don't save PMCR_EL0.{C,P} for the vCPU
I received both of these patches as indepentent emails instead of replies to
the cover letter (i.e. In-Reply-To header is missing). I was able to find
both patches but just wanted to let you know so you can debug your tooling.
--
Thanks,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-13 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 3:29 [PATCH v2 0/2] KVM: arm64: PMU: Preserve vPMC registers properly on migration Reiji Watanabe
2023-03-13 3:29 ` Reiji Watanabe
2023-03-13 18:04 ` Oliver Upton [this message]
2023-03-13 18:04 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA9llyTSgLcV2a1s@linux.dev \
--to=oliver.upton@linux.dev \
--cc=alexandru.elisei@arm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rananta@google.com \
--cc=reijiw@google.com \
--cc=ricarkol@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.