From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
David Sterba <dsterba@suse.cz>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v7 04/13] btrfs: add support for inserting raid stripe extents
Date: Thu, 2 Mar 2023 06:01:56 -0800 [thread overview]
Message-ID: <ZACsVI3mfprrj4j6@infradead.org> (raw)
In-Reply-To: <7bd4ce91-58e6-f68b-6d69-3f9deff39ff5@wdc.com>
On Thu, Mar 02, 2023 at 11:58:13AM +0000, Johannes Thumshirn wrote:
> > Thus it can cause deadlock if the workqueue has one max_active, and the
> > running one is finish_ordered_fn(), which then can be waiting for the
> > RST work.
> >
> > But the RST work can only be executed if the endio_workers has finished
> > its current work, thus leading to a deadlock.
>
> How about adding a new workqueue for RST updates? That should mitigate
> the deadlock.
The amount of weird workqueues in the btrfs end I/O path is worrysome.
What I plan to do, and might be ready to submit about next week is a
series to actually offload the I/O completion to a workqueue on a
per (original) btrfs_bio basis. This means that RST updates,
ordered_extent processing, compressed write handling etc can all
run from the same end I/O worker. As a bonus we remove all irqsave
locking from btrfs.
next prev parent reply other threads:[~2023-03-02 14:02 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 9:45 [PATCH v7 00/13] btrfs: introduce RAID stripe tree Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 01/13] btrfs: re-add trans parameter to insert_delayed_ref Johannes Thumshirn
2023-03-02 13:36 ` Anand Jain
2023-03-02 9:45 ` [PATCH v7 02/13] btrfs: add raid stripe tree definitions Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 03/13] btrfs: read raid-stripe-tree from disk Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 04/13] btrfs: add support for inserting raid stripe extents Johannes Thumshirn
2023-03-02 10:58 ` Qu Wenruo
2023-03-02 11:25 ` Johannes Thumshirn
2023-03-02 11:45 ` Qu Wenruo
2023-03-02 11:58 ` Johannes Thumshirn
2023-03-02 12:01 ` Qu Wenruo
2023-03-02 14:01 ` Christoph Hellwig [this message]
2023-03-02 15:31 ` Johannes Thumshirn
2023-03-02 22:35 ` Qu Wenruo
2023-03-03 11:15 ` Johannes Thumshirn
2023-03-03 11:42 ` Qu Wenruo
2023-03-03 14:21 ` hch
2023-03-06 10:58 ` Johannes Thumshirn
2023-03-03 14:17 ` hch
2023-03-03 14:16 ` hch
2023-03-08 9:11 ` Johannes Thumshirn
2023-03-08 12:01 ` Qu Wenruo
2023-03-08 14:33 ` Christoph Hellwig
2023-03-09 10:53 ` Johannes Thumshirn
2023-03-09 15:20 ` Christoph Hellwig
2023-03-03 14:15 ` hch
2023-03-02 11:45 ` Johannes Thumshirn
2023-03-02 14:03 ` Christoph Hellwig
2023-03-02 13:59 ` Christoph Hellwig
2023-03-02 15:29 ` Johannes Thumshirn
2023-03-03 0:13 ` Qu Wenruo
2023-03-03 14:15 ` Christoph Hellwig
2023-03-03 23:03 ` Qu Wenruo
2023-03-06 17:11 ` Christoph Hellwig
2023-03-02 9:45 ` [PATCH v7 05/13] btrfs: delete stripe extent on extent deletion Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 06/13] btrfs: lookup physical address from stripe extent Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 07/13] btrfs: add raid stripe tree pretty printer Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 08/13] btrfs: zoned: allow zoned RAID Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 09/13] btrfs: check for leaks of ordered stripes on umount Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 10/13] btrfs: add tracepoints for ordered stripes Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 11/13] btrfs: announce presence of raid-stripe-tree in sysfs Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 12/13] btrfs: consult raid-stripe-tree when scrubbing Johannes Thumshirn
2023-03-02 9:45 ` [PATCH v7 13/13] btrfs: add raid-stripe-tree to features enabled with debug Johannes Thumshirn
2023-03-03 23:27 ` Anand Jain
2023-03-09 7:08 ` Naohiro Aota
2023-03-02 19:38 ` [PATCH v7 00/13] btrfs: introduce RAID stripe tree Neal Gompa
2023-03-03 8:45 ` Johannes Thumshirn
2023-03-03 9:29 ` Anand Jain
2023-03-03 10:32 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZACsVI3mfprrj4j6@infradead.org \
--to=hch@infradead.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dsterba@suse.cz \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.