All of lore.kernel.org
 help / color / mirror / Atom feed
From: "hch@infradead.org" <hch@infradead.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
	"hch@infradead.org" <hch@infradead.org>,
	David Sterba <dsterba@suse.cz>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	Josef Bacik <josef@toxicpanda.com>,
	Christoph Hellwig <hch@lst.de>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v7 04/13] btrfs: add support for inserting raid stripe extents
Date: Fri, 3 Mar 2023 06:17:41 -0800	[thread overview]
Message-ID: <ZAIBhVhIQ+0xcM28@infradead.org> (raw)
In-Reply-To: <b538f61d-fda6-2ed0-9a17-216506ab2692@wdc.com>

On Fri, Mar 03, 2023 at 11:15:00AM +0000, Johannes Thumshirn wrote:
> There's two possibilities how to handle it:
> 1) Have a common workfn that handles all the calls in the correct order
> 2) Do the RST update in btrfs_finish_ordered_io()
> 
> To me both are valuable options, so I don't care. Both need a bit of
> preparation work before, but that's the nature of the beast.
> 
> For 2) we need a pointer to the bioc in ordered_extent, so we need to
> make sure the lifetimes are in sync. Or the other way around, have
> ordered_stripe hold enough information for the RST updates and the
> end_io handler insert it in the ordered_stripe (that needs to be
> passed into the bioc or bbio).
> 
> *Iff* I interpret Christoph's proposal in [1] correctly, options 1) is
> easier to implement.

1 is probably easier, and should be done for other reasons.  But 2
really feels like the right thing to do in addition to 1.

  parent reply	other threads:[~2023-03-03 14:17 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02  9:45 [PATCH v7 00/13] btrfs: introduce RAID stripe tree Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 01/13] btrfs: re-add trans parameter to insert_delayed_ref Johannes Thumshirn
2023-03-02 13:36   ` Anand Jain
2023-03-02  9:45 ` [PATCH v7 02/13] btrfs: add raid stripe tree definitions Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 03/13] btrfs: read raid-stripe-tree from disk Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 04/13] btrfs: add support for inserting raid stripe extents Johannes Thumshirn
2023-03-02 10:58   ` Qu Wenruo
2023-03-02 11:25     ` Johannes Thumshirn
2023-03-02 11:45       ` Qu Wenruo
2023-03-02 11:58         ` Johannes Thumshirn
2023-03-02 12:01           ` Qu Wenruo
2023-03-02 14:01           ` Christoph Hellwig
2023-03-02 15:31             ` Johannes Thumshirn
2023-03-02 22:35               ` Qu Wenruo
2023-03-03 11:15                 ` Johannes Thumshirn
2023-03-03 11:42                   ` Qu Wenruo
2023-03-03 14:21                     ` hch
2023-03-06 10:58                       ` Johannes Thumshirn
2023-03-03 14:17                   ` hch [this message]
2023-03-03 14:16                 ` hch
2023-03-08  9:11                   ` Johannes Thumshirn
2023-03-08 12:01                     ` Qu Wenruo
2023-03-08 14:33                     ` Christoph Hellwig
2023-03-09 10:53                       ` Johannes Thumshirn
2023-03-09 15:20                         ` Christoph Hellwig
2023-03-03 14:15               ` hch
2023-03-02 11:45       ` Johannes Thumshirn
2023-03-02 14:03         ` Christoph Hellwig
2023-03-02 13:59       ` Christoph Hellwig
2023-03-02 15:29         ` Johannes Thumshirn
2023-03-03  0:13         ` Qu Wenruo
2023-03-03 14:15           ` Christoph Hellwig
2023-03-03 23:03             ` Qu Wenruo
2023-03-06 17:11               ` Christoph Hellwig
2023-03-02  9:45 ` [PATCH v7 05/13] btrfs: delete stripe extent on extent deletion Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 06/13] btrfs: lookup physical address from stripe extent Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 07/13] btrfs: add raid stripe tree pretty printer Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 08/13] btrfs: zoned: allow zoned RAID Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 09/13] btrfs: check for leaks of ordered stripes on umount Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 10/13] btrfs: add tracepoints for ordered stripes Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 11/13] btrfs: announce presence of raid-stripe-tree in sysfs Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 12/13] btrfs: consult raid-stripe-tree when scrubbing Johannes Thumshirn
2023-03-02  9:45 ` [PATCH v7 13/13] btrfs: add raid-stripe-tree to features enabled with debug Johannes Thumshirn
2023-03-03 23:27   ` Anand Jain
2023-03-09  7:08   ` Naohiro Aota
2023-03-02 19:38 ` [PATCH v7 00/13] btrfs: introduce RAID stripe tree Neal Gompa
2023-03-03  8:45   ` Johannes Thumshirn
2023-03-03  9:29 ` Anand Jain
2023-03-03 10:32   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAIBhVhIQ+0xcM28@infradead.org \
    --to=hch@infradead.org \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dsterba@suse.cz \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.