From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Stephen Boyd <sboyd@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Kalle Valo <kvalo@kernel.org>, Sebastian Reichel <sre@kernel.org>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-pm@vger.kernel.org,
alsa-devel@alsa-project.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples
Date: Thu, 2 Mar 2023 17:45:04 +0100 [thread overview]
Message-ID: <ZADSkGa6dK4H9p75@ravnborg.org> (raw)
In-Reply-To: <20230228215433.3944508-1-robh@kernel.org>
Hi Rob.
> .../bindings/display/bridge/analogix,anx7625.yaml | 2 +-
> .../bindings/display/bridge/anx6345.yaml | 2 +-
> .../bindings/display/bridge/lontium,lt8912b.yaml | 2 +-
> .../bindings/display/bridge/nxp,ptn3460.yaml | 2 +-
> .../bindings/display/bridge/ps8640.yaml | 2 +-
> .../bindings/display/bridge/sil,sii9234.yaml | 2 +-
> .../bindings/display/bridge/ti,dlpc3433.yaml | 2 +-
> .../bindings/display/bridge/toshiba,tc358762.yaml | 2 +-
> .../bindings/display/bridge/toshiba,tc358768.yaml | 2 +-
> .../bindings/display/panel/nec,nl8048hl11.yaml | 2 +-
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> index 669f70b1b4c4..8bd58913804a 100644
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> @@ -226,7 +226,7 @@ unevaluatedProperties: false
>
> examples:
> - |
> - i2c1 {
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -239,7 +239,7 @@ examples:
>
> ssd1306_i2c: oled@3d {
> compatible = "solomon,ssd1306";
> - reg = <0x3c>;
> + reg = <0x3d>;
> pwms = <&pwm 4 3000>;
> reset-gpios = <&gpio2 7>;
> solomon,com-lrremap;
I can see this align the example with i2c-mux-gpio.yaml so the change
should be fine. I am just positive surprised the tooling caught it.
The change is
Acked-by: Sam Ravnborg <sam@ravnborg.org>
the above was just me thinking loud.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: alsa-devel@alsa-project.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dri-devel@lists.freedesktop.org,
Eric Dumazet <edumazet@google.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-i2c@vger.kernel.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Guenter Roeck <groeck@chromium.org>,
linux-clk@vger.kernel.org, linux-leds@vger.kernel.org,
Robert Foss <rfoss@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Lee Jones <lee@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Miguel Ojeda <ojeda@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Kalle Valo <kvalo@kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
linux-can@vger.kernel.org, linux-gpio@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
Sebastian Reichel <sre@kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples
Date: Thu, 2 Mar 2023 17:45:04 +0100 [thread overview]
Message-ID: <ZADSkGa6dK4H9p75@ravnborg.org> (raw)
In-Reply-To: <20230228215433.3944508-1-robh@kernel.org>
Hi Rob.
> .../bindings/display/bridge/analogix,anx7625.yaml | 2 +-
> .../bindings/display/bridge/anx6345.yaml | 2 +-
> .../bindings/display/bridge/lontium,lt8912b.yaml | 2 +-
> .../bindings/display/bridge/nxp,ptn3460.yaml | 2 +-
> .../bindings/display/bridge/ps8640.yaml | 2 +-
> .../bindings/display/bridge/sil,sii9234.yaml | 2 +-
> .../bindings/display/bridge/ti,dlpc3433.yaml | 2 +-
> .../bindings/display/bridge/toshiba,tc358762.yaml | 2 +-
> .../bindings/display/bridge/toshiba,tc358768.yaml | 2 +-
> .../bindings/display/panel/nec,nl8048hl11.yaml | 2 +-
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> index 669f70b1b4c4..8bd58913804a 100644
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> @@ -226,7 +226,7 @@ unevaluatedProperties: false
>
> examples:
> - |
> - i2c1 {
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -239,7 +239,7 @@ examples:
>
> ssd1306_i2c: oled@3d {
> compatible = "solomon,ssd1306";
> - reg = <0x3c>;
> + reg = <0x3d>;
> pwms = <&pwm 4 3000>;
> reset-gpios = <&gpio2 7>;
> solomon,com-lrremap;
I can see this align the example with i2c-mux-gpio.yaml so the change
should be fine. I am just positive surprised the tooling caught it.
The change is
Acked-by: Sam Ravnborg <sam@ravnborg.org>
the above was just me thinking loud.
Sam
next prev parent reply other threads:[~2023-03-02 16:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 21:54 [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples Rob Herring
2023-02-28 21:54 ` Rob Herring
2023-02-28 21:58 ` Mark Brown
2023-02-28 21:58 ` Mark Brown
2023-03-01 6:51 ` Wolfram Sang
2023-03-01 6:51 ` Wolfram Sang
2023-03-01 7:42 ` Marc Kleine-Budde
2023-03-01 7:42 ` Marc Kleine-Budde
2023-03-01 8:52 ` Lee Jones
2023-03-01 8:52 ` Lee Jones
2023-03-01 14:45 ` Simon Glass
2023-03-01 14:45 ` Simon Glass
2023-03-01 21:09 ` Stephen Boyd
2023-03-01 21:09 ` Stephen Boyd
2023-03-01 23:43 ` Sebastian Reichel
2023-03-01 23:43 ` Sebastian Reichel
2023-03-02 16:45 ` Sam Ravnborg [this message]
2023-03-02 16:45 ` Sam Ravnborg
[not found] ` <CANiq72mm9qX8uuS2y_vvtcza2hAgG3zFEy24koQTfSEOWkKDYQ@mail.gmail.com>
2023-03-06 8:16 ` Robin van der Gracht
2023-03-06 9:26 ` Bartosz Golaszewski
2023-03-06 9:26 ` Bartosz Golaszewski
2023-03-08 14:10 ` Rob Herring
2023-03-08 14:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZADSkGa6dK4H9p75@ravnborg.org \
--to=sam@ravnborg.org \
--cc=alsa-devel@alsa-project.org \
--cc=andrzej.hajda@intel.com \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.