* [PATCH] image_types: fix vname var init in multiubi_mkfs() function
@ 2023-03-03 10:54 romuald.jeanne
2023-03-03 21:29 ` [OE-core] " Alexandre Belloni
0 siblings, 1 reply; 6+ messages in thread
From: romuald.jeanne @ 2023-03-03 10:54 UTC (permalink / raw)
To: openembedded-core; +Cc: Romuald JEANNE
From: Romuald JEANNE <romuald.jeanne@st.com>
As vname var is needed in multiubi_mkfs() function, we need to keep it
defined and use it as parameter to the new write_ubi_config() function.
See [YOCTO #15027]
Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com>
---
meta/classes-recipe/image_types.bbclass | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/meta/classes-recipe/image_types.bbclass b/meta/classes-recipe/image_types.bbclass
index 764e6a5574..77cb22cf9c 100644
--- a/meta/classes-recipe/image_types.bbclass
+++ b/meta/classes-recipe/image_types.bbclass
@@ -157,11 +157,7 @@ UBI_VOLTYPE ?= "dynamic"
UBI_IMGTYPE ?= "ubifs"
write_ubi_config() {
- if [ -z "$1" ]; then
- local vname=""
- else
- local vname="_$1"
- fi
+ local vname="$1"
cat <<EOF > ubinize${vname}-${IMAGE_NAME}.cfg
[ubifs]
@@ -183,7 +179,12 @@ multiubi_mkfs() {
bbfatal "MKUBIFS_ARGS and UBINIZE_ARGS have to be set, see http://www.linux-mtd.infradead.org/faq/ubifs.html for details"
fi
- write_ubi_config "$3"
+ if [ -z "$1" ]; then
+ local vname=""
+ else
+ local vname="_$3"
+ fi
+ write_ubi_config "${vname}"
if [ -n "$vname" ]; then
mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${IMGDEPLOYDIR}/${IMAGE_NAME}${vname}${IMAGE_NAME_SUFFIX}.ubifs ${mkubifs_args}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] image_types: fix vname var init in multiubi_mkfs() function
2023-03-03 10:54 [PATCH] image_types: fix vname var init in multiubi_mkfs() function romuald.jeanne
@ 2023-03-03 21:29 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2023-03-03 21:29 UTC (permalink / raw)
To: romuald.jeanne; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 3152 bytes --]
Hello,
This still fails on the autobuilders:
2023-03-03 19:19:37,778 - oe-selftest - INFO - imagefeatures.ImageFeatures.test_image_fstypes (subunit.RemotedTestCase)
2023-03-03 19:19:37,779 - oe-selftest - INFO - ... FAIL
2023-03-03 19:19:37,779 - oe-selftest - INFO - 2: 21/40 359/523 (131.33s) (0 failed) (imagefeatures.ImageFeatures.test_image_fstypes)
2023-03-03 19:19:37,779 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
File "/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/lib/oeqa/selftest/cases/imagefeatures.py", line 224, in test_image_fstypes
self.assertTrue(os.path.exists(image_path),
File "/usr/lib64/python3.11/unittest/case.py", line 715, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true : ubi image /home/pokybuild/yocto-worker/oe-selftest-fedora/build/build-st-3612031/tmp/deploy/images/qemux86-64/core-image-minimal-qemux86-64.ubi doesn't exist
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/4878/steps/14/logs/stdio
I'm attaching the relevant logs.
On 03/03/2023 11:54:10+0100, Romuald Jeanne via lists.openembedded.org wrote:
> From: Romuald JEANNE <romuald.jeanne@st.com>
>
> As vname var is needed in multiubi_mkfs() function, we need to keep it
> defined and use it as parameter to the new write_ubi_config() function.
>
> See [YOCTO #15027]
>
> Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com>
> ---
> meta/classes-recipe/image_types.bbclass | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/meta/classes-recipe/image_types.bbclass b/meta/classes-recipe/image_types.bbclass
> index 764e6a5574..77cb22cf9c 100644
> --- a/meta/classes-recipe/image_types.bbclass
> +++ b/meta/classes-recipe/image_types.bbclass
> @@ -157,11 +157,7 @@ UBI_VOLTYPE ?= "dynamic"
> UBI_IMGTYPE ?= "ubifs"
>
> write_ubi_config() {
> - if [ -z "$1" ]; then
> - local vname=""
> - else
> - local vname="_$1"
> - fi
> + local vname="$1"
>
> cat <<EOF > ubinize${vname}-${IMAGE_NAME}.cfg
> [ubifs]
> @@ -183,7 +179,12 @@ multiubi_mkfs() {
> bbfatal "MKUBIFS_ARGS and UBINIZE_ARGS have to be set, see http://www.linux-mtd.infradead.org/faq/ubifs.html for details"
> fi
>
> - write_ubi_config "$3"
> + if [ -z "$1" ]; then
> + local vname=""
> + else
> + local vname="_$3"
> + fi
> + write_ubi_config "${vname}"
>
> if [ -n "$vname" ]; then
> mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${IMGDEPLOYDIR}/${IMAGE_NAME}${vname}${IMAGE_NAME_SUFFIX}.ubifs ${mkubifs_args}
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#177985): https://lists.openembedded.org/g/openembedded-core/message/177985
> Mute This Topic: https://lists.openembedded.org/mt/97359377/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: log.do_image_ubi.1353785 --]
[-- Type: text/plain, Size: 7731 bytes --]
DEBUG: Executing python function extend_recipe_sysroot
NOTE: Direct dependencies are ['/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-bsp/grub/grub-efi_2.06.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/glibc/cross-localedef-native_2.37.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/glibc/ldconfig-native_2.12.1.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/os-release/os-release.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/systemd/systemd-boot_252.5.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/binutils/binutils-cross_2.40.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/cdrtools/cdrtools-native_3.01.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-kernel/kmod/depmodwrapper-cross_1.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/btrfs-tools/btrfs-tools_6.1.3.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/createrepo-c/createrepo-c_0.20.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/dnf/dnf_4.14.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/erofs-utils/erofs-utils_1.5.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/makedevs/makedevs_1.0.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/mtd/mtd-utils_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/opkg-utils/opkg-utils_0.5.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/opkg/opkg_0.6.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/pseudo/pseudo_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/rpm/rpm_4.18.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/pigz/pigz_2.7.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/xz/xz_5.4.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/zstd/zstd_1.5.4.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-support/bmap-tools/bmap-tools_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-support/lz4/lz4_1.9.4.bb:do_populate_sysroot']
NOTE: Installed into sysroot: []
NOTE: Skipping as already exists in sysroot: ['grub-efi', 'cross-localedef-native', 'ldconfig-native', 'os-release', 'systemd-boot', 'binutils-cross-x86_64', 'cdrtools-native', 'qemuwrapper-cross', 'syslinux', 'depmodwrapper-cross', 'update-rc.d-native', 'btrfs-tools-native', 'createrepo-c-native', 'dnf-native', 'e2fsprogs-native', 'erofs-utils-native', 'makedevs-native', 'mtd-utils-native', 'opkg-utils-native', 'opkg-native', 'pseudo-native', 'rpm-native', 'squashfs-tools-native', 'syslinux-native', 'pbzip2-native', 'pigz-native', 'xz-native', 'zstd-native', 'bmap-tools-native', 'lz4-native', 'shadow-native', 'coreutils-native', 'python3-six-native', 'python3-native', 'python3-wheel-native', 'python3-build-native', 'python3-installer-native', 'python3-setuptools-native', 'qemu-native', 'texinfo-dummy-native', 'gnu-config-native', 'zlib-native', 'flex-native', 'util-linux-native', 'nasm-native', 'mtools-native', 'librepo-native', 'gettext-minimal-native', 'cmake-native', 'libdnf-native', 'libcomps-native', 'python3-iniparse-native', 'bzip2-native', 'sqlite3-native', 'popt-native', 'elfutils-native', 'libtool-native', 'lua-native', 'libgcrypt-native', 'file-native', 'gcc-runtime', 'e2fsprogs', 'glibc', 'util-linux', 'openssl-native', 'debianutils-native', 'perl-native', 'lzo-native', 'attr-native', 'acl-native', 'libarchive-native', 'libsolv-native', 'util-linux-libuuid-native', 'kmod-native', 'libxml2-native', 'expat-native', 'curl-native', 'glib-2.0-native', 'gnu-efi', 'libcap', 'ncurses-native', 'gdbm-native', 'libffi-native', 'readline-native', 'libtirpc-native', 'libnsl2-native', 'python3-flit-core-native', 'python3-pyproject-hooks-native', 'python3-packaging-native', 'm4-native', 'libpcre2-native', 'libcap-ng-native', 'groff-native', 'gpgme-native', 'gobject-introspection-native', 'swig-native', 'libmodulemd-native', 'json-c-native', 'libcheck-native', 'libmicrohttpd-native', 'libgpg-error-native', 'libcap-native', 'linux-libc-headers', 'libgcc', 'opkg-utils', 'attr', 'autoconf-archive', 'util-linux-libuuid', 'bash-completion', 'ncurses', 'zlib', 'libcap-ng', 'libxcrypt', 'make-native', 'gettext-native', 'unzip-native', 'libassuan-native', 'libyaml-native', 'gnutls-native', 'libidn2-native', 'nettle-native', 'gmp-native', 'libunistring-native']
DEBUG: Python function extend_recipe_sysroot finished
DEBUG: Executing python function set_image_size
DEBUG: 33883.200000 = 26064 * 1.300000
DEBUG: 33883.200000 = max(33883.200000, 8192)[33883.200000] + 0
DEBUG: 33884.000000 = int(33883.200000)
DEBUG: 33884 = aligned(33884)
DEBUG: returning 33884
DEBUG: Python function set_image_size finished
DEBUG: Executing shell function do_image_ubi
ubinize: volume size was not specified in section "ubifs", assume minimum to fit image "/home/pokybuild/yocto-worker/oe-selftest-fedora/build/build-st-3612031/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/deploy-core-image-minimal-image-complete/core-image-minimal-qemux86-64-20230303191747_.rootfs.ubifs"20385792 bytes (19.4 MiB)
/home/pokybuild/yocto-worker/oe-selftest-fedora/build/build-st-3612031
DEBUG: Shell function do_image_ubi finished
DEBUG: Executing python function create_symlinks
NOTE: Skipping symlink, source does not exist: /home/pokybuild/yocto-worker/oe-selftest-fedora/build/build-st-3612031/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/deploy-core-image-minimal-image-complete/core-image-minimal-qemux86-64.ubi -> core-image-minimal-qemux86-64-20230303191747.rootfs.ubi
DEBUG: Python function create_symlinks finished
[-- Attachment #3: log.do_image_ubifs.1336032 --]
[-- Type: text/plain, Size: 7301 bytes --]
DEBUG: Executing python function extend_recipe_sysroot
NOTE: Direct dependencies are ['/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-bsp/grub/grub-efi_2.06.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/glibc/cross-localedef-native_2.37.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/glibc/ldconfig-native_2.12.1.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/os-release/os-release.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/systemd/systemd-boot_252.5.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/binutils/binutils-cross_2.40.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/cdrtools/cdrtools-native_3.01.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb:do_populate_sysroot', '/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-kernel/kmod/depmodwrapper-cross_1.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/update-rc.d/update-rc.d_0.8.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/btrfs-tools/btrfs-tools_6.1.3.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/createrepo-c/createrepo-c_0.20.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/dnf/dnf_4.14.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/erofs-utils/erofs-utils_1.5.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/makedevs/makedevs_1.0.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/mtd/mtd-utils_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/opkg-utils/opkg-utils_0.5.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/opkg/opkg_0.6.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/pseudo/pseudo_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/rpm/rpm_4.18.0.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/pigz/pigz_2.7.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/xz/xz_5.4.1.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-extended/zstd/zstd_1.5.4.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-support/bmap-tools/bmap-tools_git.bb:do_populate_sysroot', 'virtual:native:/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-support/lz4/lz4_1.9.4.bb:do_populate_sysroot']
NOTE: Installed into sysroot: []
NOTE: Skipping as already exists in sysroot: ['grub-efi', 'cross-localedef-native', 'ldconfig-native', 'os-release', 'systemd-boot', 'binutils-cross-x86_64', 'cdrtools-native', 'qemuwrapper-cross', 'syslinux', 'depmodwrapper-cross', 'update-rc.d-native', 'btrfs-tools-native', 'createrepo-c-native', 'dnf-native', 'e2fsprogs-native', 'erofs-utils-native', 'makedevs-native', 'mtd-utils-native', 'opkg-utils-native', 'opkg-native', 'pseudo-native', 'rpm-native', 'squashfs-tools-native', 'syslinux-native', 'pbzip2-native', 'pigz-native', 'xz-native', 'zstd-native', 'bmap-tools-native', 'lz4-native', 'shadow-native', 'coreutils-native', 'python3-six-native', 'python3-native', 'python3-wheel-native', 'python3-build-native', 'python3-installer-native', 'python3-setuptools-native', 'qemu-native', 'texinfo-dummy-native', 'gnu-config-native', 'zlib-native', 'flex-native', 'util-linux-native', 'nasm-native', 'mtools-native', 'librepo-native', 'gettext-minimal-native', 'cmake-native', 'libdnf-native', 'libcomps-native', 'python3-iniparse-native', 'bzip2-native', 'sqlite3-native', 'popt-native', 'elfutils-native', 'libtool-native', 'lua-native', 'libgcrypt-native', 'file-native', 'gcc-runtime', 'e2fsprogs', 'glibc', 'util-linux', 'openssl-native', 'debianutils-native', 'perl-native', 'lzo-native', 'attr-native', 'acl-native', 'libarchive-native', 'libsolv-native', 'util-linux-libuuid-native', 'kmod-native', 'libxml2-native', 'expat-native', 'curl-native', 'glib-2.0-native', 'gnu-efi', 'libcap', 'ncurses-native', 'gdbm-native', 'libffi-native', 'readline-native', 'libtirpc-native', 'libnsl2-native', 'python3-flit-core-native', 'python3-pyproject-hooks-native', 'python3-packaging-native', 'm4-native', 'libpcre2-native', 'libcap-ng-native', 'groff-native', 'gpgme-native', 'gobject-introspection-native', 'swig-native', 'libmodulemd-native', 'json-c-native', 'libcheck-native', 'libmicrohttpd-native', 'libgpg-error-native', 'libcap-native', 'linux-libc-headers', 'libgcc', 'opkg-utils', 'attr', 'autoconf-archive', 'util-linux-libuuid', 'bash-completion', 'ncurses', 'zlib', 'libcap-ng', 'libxcrypt', 'make-native', 'gettext-native', 'unzip-native', 'libassuan-native', 'libyaml-native', 'gnutls-native', 'libidn2-native', 'nettle-native', 'gmp-native', 'libunistring-native']
DEBUG: Python function extend_recipe_sysroot finished
DEBUG: Executing python function set_image_size
DEBUG: 33883.200000 = 26064 * 1.300000
DEBUG: 33883.200000 = max(33883.200000, 8192)[33883.200000] + 0
DEBUG: 33884.000000 = int(33883.200000)
DEBUG: 33884 = aligned(33884)
DEBUG: returning 33884
DEBUG: Python function set_image_size finished
DEBUG: Executing shell function do_image_ubifs
DEBUG: Shell function do_image_ubifs finished
DEBUG: Executing python function create_symlinks
NOTE: Creating symlink: /home/pokybuild/yocto-worker/oe-selftest-fedora/build/build-st-3612031/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/deploy-core-image-minimal-image-complete/core-image-minimal-qemux86-64.ubifs -> core-image-minimal-qemux86-64-20230303191747.rootfs.ubifs
DEBUG: Python function create_symlinks finished
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] image_types: fix vname var init in multiubi_mkfs() function
2023-03-09 7:54 romuald.jeanne
@ 2023-03-09 8:30 ` Martin Jansa
2023-03-09 9:28 ` Romuald JEANNE
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2023-03-09 8:30 UTC (permalink / raw)
To: romuald.jeanne; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
On Thu, Mar 9, 2023 at 8:55 AM Romuald Jeanne via lists.openembedded.org
<romuald.jeanne=st.com@lists.openembedded.org> wrote:
> From: Romuald JEANNE <romuald.jeanne@st.com>
>
> As vname var is needed in multiubi_mkfs() function, we need to keep it
> defined and use it as parameter to the new write_ubi_config() function.
>
> See [YOCTO #15027]
>
> Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com>
> ---
> meta/classes-recipe/image_types.bbclass | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/meta/classes-recipe/image_types.bbclass
> b/meta/classes-recipe/image_types.bbclass
> index 764e6a5574..c6cb8f5336 100644
> --- a/meta/classes-recipe/image_types.bbclass
> +++ b/meta/classes-recipe/image_types.bbclass
> @@ -157,11 +157,7 @@ UBI_VOLTYPE ?= "dynamic"
> UBI_IMGTYPE ?= "ubifs"
>
> write_ubi_config() {
> - if [ -z "$1" ]; then
> - local vname=""
> - else
> - local vname="_$1"
> - fi
> + local vname="$1"
>
Did you drop the _ separator intentionally?
[-- Attachment #2: Type: text/html, Size: 1702 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [OE-core] [PATCH] image_types: fix vname var init in multiubi_mkfs() function
2023-03-09 8:30 ` [OE-core] " Martin Jansa
@ 2023-03-09 9:28 ` Romuald JEANNE
2023-03-09 9:46 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Romuald JEANNE @ 2023-03-09 9:28 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]
Hello,
The ‘write_ubi_config()’ is called through ‘multiubi_mkfs()’ where the _ separator is managed with proper init of ‘vname’ var.
So I didn’t dropped the _ separator, it is managed on calling function side.
Best regards,
Romuald JEANNE
From: Martin Jansa <martin.jansa@gmail.com>
Sent: jeudi 9 mars 2023 09:31
To: Romuald JEANNE <romuald.jeanne@st.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] image_types: fix vname var init in multiubi_mkfs() function
On Thu, Mar 9, 2023 at 8:55 AM Romuald Jeanne via lists.openembedded.org<http://lists.openembedded.org> <romuald.jeanne=st.com@lists.openembedded.org<mailto:st.com@lists.openembedded.org>> wrote:
From: Romuald JEANNE <romuald.jeanne@st.com<mailto:romuald.jeanne@st.com>>
As vname var is needed in multiubi_mkfs() function, we need to keep it
defined and use it as parameter to the new write_ubi_config() function.
See [YOCTO #15027]
Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com<mailto:romuald.jeanne@st.com>>
---
meta/classes-recipe/image_types.bbclass | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/meta/classes-recipe/image_types.bbclass b/meta/classes-recipe/image_types.bbclass
index 764e6a5574..c6cb8f5336 100644
--- a/meta/classes-recipe/image_types.bbclass
+++ b/meta/classes-recipe/image_types.bbclass
@@ -157,11 +157,7 @@ UBI_VOLTYPE ?= "dynamic"
UBI_IMGTYPE ?= "ubifs"
write_ubi_config() {
- if [ -z "$1" ]; then
- local vname=""
- else
- local vname="_$1"
- fi
+ local vname="$1"
Did you drop the _ separator intentionally?
ST Restricted
[-- Attachment #2: Type: text/html, Size: 6363 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] image_types: fix vname var init in multiubi_mkfs() function
2023-03-09 9:28 ` Romuald JEANNE
@ 2023-03-09 9:46 ` Martin Jansa
2023-03-09 9:50 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2023-03-09 9:46 UTC (permalink / raw)
To: Romuald JEANNE; +Cc: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]
- local vname="_$1"
- fi
+ local vname="$1"
cat <<EOF > ubinize${vname}-${IMAGE_NAME}.cfg
_ surely got removed from this ubinize filename, right?
On Thu, Mar 9, 2023 at 10:28 AM Romuald JEANNE <romuald.jeanne@st.com>
wrote:
> Hello,
>
>
>
> The ‘write_ubi_config()’ is called through ‘multiubi_mkfs()’ where the _
> separator is managed with proper init of ‘vname’ var.
>
> So I didn’t dropped the _ separator, it is managed on calling function
> side.
>
>
>
> Best regards,
>
>
>
> Romuald JEANNE
>
>
>
> *From:* Martin Jansa <martin.jansa@gmail.com>
> *Sent:* jeudi 9 mars 2023 09:31
> *To:* Romuald JEANNE <romuald.jeanne@st.com>
> *Cc:* openembedded-core@lists.openembedded.org
> *Subject:* Re: [OE-core] [PATCH] image_types: fix vname var init in
> multiubi_mkfs() function
>
>
>
> On Thu, Mar 9, 2023 at 8:55 AM Romuald Jeanne via lists.openembedded.org
> <romuald.jeanne=st.com@lists.openembedded.org> wrote:
>
> From: Romuald JEANNE <romuald.jeanne@st.com>
>
> As vname var is needed in multiubi_mkfs() function, we need to keep it
> defined and use it as parameter to the new write_ubi_config() function.
>
> See [YOCTO #15027]
>
> Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com>
> ---
> meta/classes-recipe/image_types.bbclass | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/meta/classes-recipe/image_types.bbclass
> b/meta/classes-recipe/image_types.bbclass
> index 764e6a5574..c6cb8f5336 100644
> --- a/meta/classes-recipe/image_types.bbclass
> +++ b/meta/classes-recipe/image_types.bbclass
> @@ -157,11 +157,7 @@ UBI_VOLTYPE ?= "dynamic"
> UBI_IMGTYPE ?= "ubifs"
>
> write_ubi_config() {
> - if [ -z "$1" ]; then
> - local vname=""
> - else
> - local vname="_$1"
> - fi
> + local vname="$1"
>
>
>
> Did you drop the _ separator intentionally?
>
>
>
> ST Restricted
>
[-- Attachment #2: Type: text/html, Size: 5258 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] image_types: fix vname var init in multiubi_mkfs() function
2023-03-09 9:46 ` Martin Jansa
@ 2023-03-09 9:50 ` Martin Jansa
0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2023-03-09 9:50 UTC (permalink / raw)
To: Romuald JEANNE; +Cc: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 2252 bytes --]
Sorry, didn't get enough coffee today, I was reading it wrong.
On Thu, Mar 9, 2023 at 10:46 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> - local vname="_$1"
> - fi
> + local vname="$1"
>
> cat <<EOF > ubinize${vname}-${IMAGE_NAME}.cfg
>
> _ surely got removed from this ubinize filename, right?
>
> On Thu, Mar 9, 2023 at 10:28 AM Romuald JEANNE <romuald.jeanne@st.com>
> wrote:
>
>> Hello,
>>
>>
>>
>> The ‘write_ubi_config()’ is called through ‘multiubi_mkfs()’ where the _
>> separator is managed with proper init of ‘vname’ var.
>>
>> So I didn’t dropped the _ separator, it is managed on calling function
>> side.
>>
>>
>>
>> Best regards,
>>
>>
>>
>> Romuald JEANNE
>>
>>
>>
>> *From:* Martin Jansa <martin.jansa@gmail.com>
>> *Sent:* jeudi 9 mars 2023 09:31
>> *To:* Romuald JEANNE <romuald.jeanne@st.com>
>> *Cc:* openembedded-core@lists.openembedded.org
>> *Subject:* Re: [OE-core] [PATCH] image_types: fix vname var init in
>> multiubi_mkfs() function
>>
>>
>>
>> On Thu, Mar 9, 2023 at 8:55 AM Romuald Jeanne via lists.openembedded.org
>> <romuald.jeanne=st.com@lists.openembedded.org> wrote:
>>
>> From: Romuald JEANNE <romuald.jeanne@st.com>
>>
>> As vname var is needed in multiubi_mkfs() function, we need to keep it
>> defined and use it as parameter to the new write_ubi_config() function.
>>
>> See [YOCTO #15027]
>>
>> Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com>
>> ---
>> meta/classes-recipe/image_types.bbclass | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/meta/classes-recipe/image_types.bbclass
>> b/meta/classes-recipe/image_types.bbclass
>> index 764e6a5574..c6cb8f5336 100644
>> --- a/meta/classes-recipe/image_types.bbclass
>> +++ b/meta/classes-recipe/image_types.bbclass
>> @@ -157,11 +157,7 @@ UBI_VOLTYPE ?= "dynamic"
>> UBI_IMGTYPE ?= "ubifs"
>>
>> write_ubi_config() {
>> - if [ -z "$1" ]; then
>> - local vname=""
>> - else
>> - local vname="_$1"
>> - fi
>> + local vname="$1"
>>
>>
>>
>> Did you drop the _ separator intentionally?
>>
>>
>>
>> ST Restricted
>>
>
[-- Attachment #2: Type: text/html, Size: 5548 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-09 9:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-03 10:54 [PATCH] image_types: fix vname var init in multiubi_mkfs() function romuald.jeanne
2023-03-03 21:29 ` [OE-core] " Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2023-03-09 7:54 romuald.jeanne
2023-03-09 8:30 ` [OE-core] " Martin Jansa
2023-03-09 9:28 ` Romuald JEANNE
2023-03-09 9:46 ` Martin Jansa
2023-03-09 9:50 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.