From: Abel Vesa <abel.vesa@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Johan Hovold" <johan+linaro@kernel.org>,
"Georgi Djakov" <djakov@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Artur Świgoń" <a.swigon@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/23] interconnect: qcom: sm8550: fix registration race
Date: Mon, 6 Mar 2023 11:39:33 +0200 [thread overview]
Message-ID: <ZAW01RH/gLwlueoT@linaro.org> (raw)
In-Reply-To: <ZAWzqtWt5yBlYpQU@hovoldconsulting.com>
On 23-03-06 10:34:34, Johan Hovold wrote:
> On Mon, Mar 06, 2023 at 11:03:14AM +0200, Abel Vesa wrote:
> > On 23-03-06 08:56:41, Johan Hovold wrote:
> > > The current interconnect provider registration interface is inherently
> > > racy as nodes are not added until the after adding the provider. This
> > > can specifically cause racing DT lookups to fail.
> > >
> > > Switch to using the new API where the provider is not registered until
> > > after it has been fully initialised.
> > >
> > > Fixes: e6f0d6a30f73 ("interconnect: qcom: Add SM8550 interconnect provider driver")
> > > Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > ---
> >
> > Any changes since v1 or is it just a resend?
>
> Please see the cover letter:
>
> https://lore.kernel.org/lkml/20230306075651.2449-1-johan+linaro@kernel.org/
>
> Only the first patch of the series was updated in v2.
Right, my bad. Though I wasn't CC'ed on that as well.
>
> Johan
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Johan Hovold" <johan+linaro@kernel.org>,
"Georgi Djakov" <djakov@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Artur Świgoń" <a.swigon@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/23] interconnect: qcom: sm8550: fix registration race
Date: Mon, 6 Mar 2023 11:39:33 +0200 [thread overview]
Message-ID: <ZAW01RH/gLwlueoT@linaro.org> (raw)
In-Reply-To: <ZAWzqtWt5yBlYpQU@hovoldconsulting.com>
On 23-03-06 10:34:34, Johan Hovold wrote:
> On Mon, Mar 06, 2023 at 11:03:14AM +0200, Abel Vesa wrote:
> > On 23-03-06 08:56:41, Johan Hovold wrote:
> > > The current interconnect provider registration interface is inherently
> > > racy as nodes are not added until the after adding the provider. This
> > > can specifically cause racing DT lookups to fail.
> > >
> > > Switch to using the new API where the provider is not registered until
> > > after it has been fully initialised.
> > >
> > > Fixes: e6f0d6a30f73 ("interconnect: qcom: Add SM8550 interconnect provider driver")
> > > Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > ---
> >
> > Any changes since v1 or is it just a resend?
>
> Please see the cover letter:
>
> https://lore.kernel.org/lkml/20230306075651.2449-1-johan+linaro@kernel.org/
>
> Only the first patch of the series was updated in v2.
Right, my bad. Though I wasn't CC'ed on that as well.
>
> Johan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-06 9:39 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 7:56 [PATCH v2 00/23] interconnect: fix racy provider registration Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 01/23] interconnect: fix mem leak when freeing nodes Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-07 9:42 ` Luca Ceresoli
2023-03-07 9:42 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 02/23] interconnect: fix icc_provider_del() error handling Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-07 9:43 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 03/23] interconnect: fix provider registration API Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-07 9:43 ` Luca Ceresoli
2023-03-06 7:56 ` [PATCH v2 04/23] interconnect: imx: fix registration race Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-07 9:43 ` Luca Ceresoli
2023-03-07 9:43 ` Luca Ceresoli
2023-03-07 10:25 ` Johan Hovold
2023-03-07 10:25 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 05/23] interconnect: qcom: osm-l3: " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 06/23] interconnect: qcom: rpm: fix probe child-node error handling Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 07/23] interconnect: qcom: rpm: fix probe PM domain " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 08/23] interconnect: qcom: rpm: fix registration race Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 09/23] interconnect: qcom: rpmh: fix probe child-node error handling Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 10/23] interconnect: qcom: rpmh: fix registration race Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 11/23] interconnect: qcom: msm8974: " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 12/23] interconnect: qcom: sm8450: " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 13/23] interconnect: qcom: sm8550: " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 9:03 ` Abel Vesa
2023-03-06 9:03 ` Abel Vesa
2023-03-06 9:34 ` Johan Hovold
2023-03-06 9:34 ` Johan Hovold
2023-03-06 9:39 ` Abel Vesa [this message]
2023-03-06 9:39 ` Abel Vesa
2023-03-06 10:04 ` Johan Hovold
2023-03-06 10:04 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 14/23] interconnect: exynos: fix node leak in probe PM QoS error path Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 15/23] interconnect: exynos: fix registration race Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 16/23] interconnect: exynos: drop redundant link destroy Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 17/23] memory: tegra: fix interconnect registration race Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 18/23] memory: tegra124-emc: " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 19/23] memory: tegra20-emc: " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 20/23] memory: tegra30-emc: " Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 21/23] interconnect: drop racy registration API Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 22/23] interconnect: drop unused icc_get() interface Johan Hovold
2023-03-06 7:56 ` Johan Hovold
2023-03-06 7:56 ` [PATCH v2 23/23] interconnect: drop unused icc_link_destroy() interface Johan Hovold
2023-03-06 7:56 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAW01RH/gLwlueoT@linaro.org \
--to=abel.vesa@linaro.org \
--cc=a.swigon@samsung.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=festevam@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.