All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andrew Davis <afd@ti.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>,
	devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Date: Tue, 7 Mar 2023 13:55:40 +0200	[thread overview]
Message-ID: <ZAcmPAbvH2FtyX3E@smile.fi.intel.com> (raw)
In-Reply-To: <20230306224752.8417-1-afd@ti.com>

On Mon, Mar 06, 2023 at 04:47:52PM -0600, Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.

Since in the past I had a problem with unnecessary rebuilding, this removes
the rule, so should not bring a similar regression.

Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Thank you.

> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  scripts/Makefile.lib | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
>  $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>  	$(call if_changed_dep,dtb)
>  
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> -	$(call if_changed_dep,dtc)
> -
>  $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>  	$(call if_changed_dep,dtc)
>  
> -- 
> 2.39.2
> 

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andrew Davis <afd@ti.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>,
	devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
Date: Tue, 7 Mar 2023 13:55:40 +0200	[thread overview]
Message-ID: <ZAcmPAbvH2FtyX3E@smile.fi.intel.com> (raw)
In-Reply-To: <20230306224752.8417-1-afd@ti.com>

On Mon, Mar 06, 2023 at 04:47:52PM -0600, Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.

Since in the past I had a problem with unnecessary rebuilding, this removes
the rule, so should not bring a similar regression.

Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Thank you.

> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  scripts/Makefile.lib | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
>  $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>  	$(call if_changed_dep,dtb)
>  
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> -	$(call if_changed_dep,dtc)
> -
>  $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>  	$(call if_changed_dep,dtc)
>  
> -- 
> 2.39.2
> 

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-03-07 11:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 22:47 [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files Andrew Davis
2023-03-06 22:47 ` Andrew Davis
2023-03-07  2:36 ` Masahiro Yamada
2023-03-07  2:36   ` Masahiro Yamada
2023-03-07  7:59 ` Geert Uytterhoeven
2023-03-07  7:59   ` Geert Uytterhoeven
2023-03-07 11:55 ` Andy Shevchenko [this message]
2023-03-07 11:55   ` Andy Shevchenko
2023-03-08 16:56 ` Nicolas Schier
2023-03-08 16:56   ` Nicolas Schier
2023-03-08 17:01   ` Andrew Davis
2023-03-08 17:01     ` Andrew Davis
2023-05-15 16:48     ` Andrew Davis
2023-05-15 16:48       ` Andrew Davis
2023-05-22  1:36       ` Masahiro Yamada
2023-05-22  1:36         ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAcmPAbvH2FtyX3E@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.