From: Jianhua Lu <lujianhua000@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings
Date: Wed, 8 Mar 2023 08:29:28 +0800 [thread overview]
Message-ID: <ZAfW6AbFLkKwxZZA@Gentoo> (raw)
In-Reply-To: <CACRpkdZ=6bU2gPv4zVzMBFaCgEY+fkRbrnLAB6NGOhWus1gwaA@mail.gmail.com>
On Tue, Mar 07, 2023 at 11:22:35PM +0100, Linus Walleij wrote:
> On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu <lujianhua000@gmail.com> wrote:
>
> > Novatek NT36523 is a display driver IC used to drive DSI panels.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > Changes in v2:
> > - Drop unnecessary description
> > - dsi0 -> dsi
> > - Correct indentation
>
> I'd like Konrad and Neil to look at this before we merge it.
>
> > +required:
> > + - compatible
> > + - reg
> > + - vddio-supply
> > + - vddpos-supply
> > + - vddneg-supply
>
> It appears vddpos and vddneg are not necessary on
> all variants, can they be made non-required?
It can be non-required, this panel's positive regulator and negative
regulator are supplied by backlight IC, the both regulator of Konrad's
NT36523W panel are supplied by secure firmware layer.
>
> It is also possible to do some - if -construction of course
> based on the compatible, if we want to be fancy.
>
> Yours,
> Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Jianhua Lu <lujianhua000@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings
Date: Wed, 8 Mar 2023 08:29:28 +0800 [thread overview]
Message-ID: <ZAfW6AbFLkKwxZZA@Gentoo> (raw)
In-Reply-To: <CACRpkdZ=6bU2gPv4zVzMBFaCgEY+fkRbrnLAB6NGOhWus1gwaA@mail.gmail.com>
On Tue, Mar 07, 2023 at 11:22:35PM +0100, Linus Walleij wrote:
> On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu <lujianhua000@gmail.com> wrote:
>
> > Novatek NT36523 is a display driver IC used to drive DSI panels.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > Changes in v2:
> > - Drop unnecessary description
> > - dsi0 -> dsi
> > - Correct indentation
>
> I'd like Konrad and Neil to look at this before we merge it.
>
> > +required:
> > + - compatible
> > + - reg
> > + - vddio-supply
> > + - vddpos-supply
> > + - vddneg-supply
>
> It appears vddpos and vddneg are not necessary on
> all variants, can they be made non-required?
It can be non-required, this panel's positive regulator and negative
regulator are supplied by backlight IC, the both regulator of Konrad's
NT36523W panel are supplied by secure firmware layer.
>
> It is also possible to do some - if -construction of course
> based on the compatible, if we want to be fancy.
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2023-03-08 0:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 12:12 [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings Jianhua Lu
2023-02-20 12:12 ` Jianhua Lu
2023-02-20 12:12 ` [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523 Jianhua Lu
2023-02-20 12:12 ` Jianhua Lu
2023-03-07 22:34 ` Linus Walleij
2023-03-07 22:34 ` Linus Walleij
2023-03-08 0:37 ` Jianhua Lu
2023-03-08 0:37 ` Jianhua Lu
2023-03-08 0:45 ` Jianhua Lu
2023-03-08 0:45 ` Jianhua Lu
2023-03-08 11:04 ` Konrad Dybcio
2023-03-08 11:04 ` Konrad Dybcio
2023-02-22 9:34 ` [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings Krzysztof Kozlowski
2023-02-22 9:34 ` Krzysztof Kozlowski
2023-03-07 22:22 ` Linus Walleij
2023-03-07 22:22 ` Linus Walleij
2023-03-08 0:29 ` Jianhua Lu [this message]
2023-03-08 0:29 ` Jianhua Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAfW6AbFLkKwxZZA@Gentoo \
--to=lujianhua000@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.