* [PATCH] yq: Drop {LINKSHARED}
@ 2023-03-07 2:48 mingli.yu
2023-03-07 3:47 ` [meta-virtualization] " Bruce Ashfield
2023-03-07 11:57 ` Jose Quaresma
0 siblings, 2 replies; 6+ messages in thread
From: mingli.yu @ 2023-03-07 2:48 UTC (permalink / raw)
To: meta-virtualization
From: Mingli Yu <mingli.yu@windriver.com>
Drop {LINKSHARED} to fix the below build failure.
WARNING: /build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/temp/run.do_compile.923432:185 exit 1 from 'aarch64-wrs-linux-go install -linkshared -p 48 -v -ldflags="-r /usr/lib64/go/pkg/linux_arm64_dynlink -I /lib64/ld-linux-aarch64.so.1 -extldflags ' -mcpu=cortex-a53 -march=armv8-a+crc -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot -Wl,-rpath-link=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot/usr/lib64/go/pkg/linux_arm64_dynlink -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot-native= -Wl,-z,relro,-z,now'" -trimpath -buildmode=pie `go_list_packages`'
Before the patch:
# rpm -ql yq
/usr
/usr/bin
/usr/bin/yq
# du -sh /usr/bin/yq
5.2M /usr/bin/yq
After the patch:
# rpm -ql yq
/usr
/usr/bin
/usr/bin/yq
# du -sh /usr/bin/yq
9.0M /usr/bin/yq
Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
recipes-devtools/yq/yq_git.bb | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
index 45f2f970..b3e00473 100644
--- a/recipes-devtools/yq/yq_git.bb
+++ b/recipes-devtools/yq/yq_git.bb
@@ -50,6 +50,13 @@ GO_IMPORT = "github.com/mikefarah/yq"
inherit go ptest
+go_do_compile() {
+ export TMPDIR="${GOTMPDIR}"
+ if [ -n "${GO_INSTALL}" ]; then
+ ${GO} install ${GOBUILDFLAGS} `go_list_packages`
+ fi
+}
+
do_compile:prepend() {
# arrange for some of the golang built ins to be found
(
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-virtualization] [PATCH] yq: Drop {LINKSHARED}
2023-03-07 2:48 [PATCH] yq: Drop {LINKSHARED} mingli.yu
@ 2023-03-07 3:47 ` Bruce Ashfield
2023-03-07 11:57 ` Jose Quaresma
1 sibling, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2023-03-07 3:47 UTC (permalink / raw)
To: Yu, Mingli; +Cc: meta-virtualization
On Mon, Mar 6, 2023 at 9:48 PM Yu, Mingli <mingli.yu@eng.windriver.com> wrote:
>
> From: Mingli Yu <mingli.yu@windriver.com>
>
> Drop {LINKSHARED} to fix the below build failure.
> WARNING: /build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/temp/run.do_compile.923432:185 exit 1 from 'aarch64-wrs-linux-go install -linkshared -p 48 -v -ldflags="-r /usr/lib64/go/pkg/linux_arm64_dynlink -I /lib64/ld-linux-aarch64.so.1 -extldflags ' -mcpu=cortex-a53 -march=armv8-a+crc -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot -Wl,-rpath-link=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot/usr/lib64/go/pkg/linux_arm64_dynlink -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot-native= -Wl,-z,relro,-z,now'" -trimpath -buildmode=pie `go_list_packages`'
>
> Before the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 5.2M /usr/bin/yq
>
> After the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 9.0M /usr/bin/yq
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
> recipes-devtools/yq/yq_git.bb | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
> index 45f2f970..b3e00473 100644
> --- a/recipes-devtools/yq/yq_git.bb
> +++ b/recipes-devtools/yq/yq_git.bb
> @@ -50,6 +50,13 @@ GO_IMPORT = "github.com/mikefarah/yq"
>
> inherit go ptest
>
> +go_do_compile() {
> + export TMPDIR="${GOTMPDIR}"
> + if [ -n "${GO_INSTALL}" ]; then
> + ${GO} install ${GOBUILDFLAGS} `go_list_packages`
> + fi
> +}
My preference is implement do_compile, versus go_do_compile, since the
go.bbclass rarely does the right thing by default.
There's only one other go_do_compile that slipped through my normal
checks (buildah), and I have a local patch removing it, that I'll push
to master-next shortly. buildah also had linkeshared issues :)
Bruce
> +
> do_compile:prepend() {
> # arrange for some of the golang built ins to be found
> (
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7929): https://lists.yoctoproject.org/g/meta-virtualization/message/7929
> Mute This Topic: https://lists.yoctoproject.org/mt/97442079/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-virtualization] [PATCH] yq: Drop {LINKSHARED}
2023-03-07 2:48 [PATCH] yq: Drop {LINKSHARED} mingli.yu
2023-03-07 3:47 ` [meta-virtualization] " Bruce Ashfield
@ 2023-03-07 11:57 ` Jose Quaresma
2023-03-07 13:54 ` Bruce Ashfield
1 sibling, 1 reply; 6+ messages in thread
From: Jose Quaresma @ 2023-03-07 11:57 UTC (permalink / raw)
To: Yu, Mingli; +Cc: meta-virtualization
[-- Attachment #1: Type: text/plain, Size: 3986 bytes --]
Hi
Yu, Mingli <mingli.yu@eng.windriver.com> escreveu no dia terça, 7/03/2023
à(s) 02:48:
> From: Mingli Yu <mingli.yu@windriver.com>
>
> Drop {LINKSHARED} to fix the below build failure.
> WARNING:
> /build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/temp/run.do_compile.923432:185
> exit 1 from 'aarch64-wrs-linux-go install -linkshared -p 48 -v -ldflags="-r
> /usr/lib64/go/pkg/linux_arm64_dynlink -I /lib64/ld-linux-aarch64.so.1
> -extldflags ' -mcpu=cortex-a53 -march=armv8-a+crc -fstack-protector-strong
> -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security
> --sysroot=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot
> -Wl,-rpath-link=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot/usr/lib64/go/pkg/linux_arm64_dynlink
> -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
> -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot=
> -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot=
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot-native=
> -Wl,-z,relro,-z,now'" -trimpath -buildmode=pie `go_list_packages`'
>
> Before the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 5.2M /usr/bin/yq
>
> After the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 9.0M /usr/bin/yq
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
> recipes-devtools/yq/yq_git.bb | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
> index 45f2f970..b3e00473 100644
> --- a/recipes-devtools/yq/yq_git.bb
> +++ b/recipes-devtools/yq/yq_git.bb
> @@ -50,6 +50,13 @@ GO_IMPORT = "github.com/mikefarah/yq"
>
> inherit go ptest
>
> +go_do_compile() {
> + export TMPDIR="${GOTMPDIR}"
> + if [ -n "${GO_INSTALL}" ]; then
> + ${GO} install ${GOBUILDFLAGS} `go_list_packages`
> + fi
> +}
>
I wonder if it would be more appropriate to disable the linkshared
with GO_LINKSHARED = ""
Jose
+
> do_compile:prepend() {
> # arrange for some of the golang built ins to be found
> (
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7929):
> https://lists.yoctoproject.org/g/meta-virtualization/message/7929
> Mute This Topic: https://lists.yoctoproject.org/mt/97442079/5052612
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
--
Best regards,
José Quaresma
[-- Attachment #2: Type: text/html, Size: 5795 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-virtualization] [PATCH] yq: Drop {LINKSHARED}
2023-03-07 11:57 ` Jose Quaresma
@ 2023-03-07 13:54 ` Bruce Ashfield
2023-03-08 3:42 ` [PATCH v2] yq: drop {LINKSHARED} mingli.yu
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Ashfield @ 2023-03-07 13:54 UTC (permalink / raw)
To: Jose Quaresma; +Cc: Yu, Mingli, meta-virtualization
On Tue, Mar 7, 2023 at 6:57 AM Jose Quaresma <quaresma.jose@gmail.com> wrote:
>
> Hi
>
> Yu, Mingli <mingli.yu@eng.windriver.com> escreveu no dia terça, 7/03/2023 à(s) 02:48:
>>
>> From: Mingli Yu <mingli.yu@windriver.com>
>>
>> Drop {LINKSHARED} to fix the below build failure.
>> WARNING: /build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/temp/run.do_compile.923432:185 exit 1 from 'aarch64-wrs-linux-go install -linkshared -p 48 -v -ldflags="-r /usr/lib64/go/pkg/linux_arm64_dynlink -I /lib64/ld-linux-aarch64.so.1 -extldflags ' -mcpu=cortex-a53 -march=armv8-a+crc -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot -Wl,-rpath-link=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot/usr/lib64/go/pkg/linux_arm64_dynlink -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot-native= -Wl,-z,relro,-z,now'" -trimpath -buildmode=pie `go_list_packages`'
>>
>> Before the patch:
>> # rpm -ql yq
>> /usr
>> /usr/bin
>> /usr/bin/yq
>>
>> # du -sh /usr/bin/yq
>> 5.2M /usr/bin/yq
>>
>> After the patch:
>> # rpm -ql yq
>> /usr
>> /usr/bin
>> /usr/bin/yq
>>
>> # du -sh /usr/bin/yq
>> 9.0M /usr/bin/yq
>>
>> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
>> ---
>> recipes-devtools/yq/yq_git.bb | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
>> index 45f2f970..b3e00473 100644
>> --- a/recipes-devtools/yq/yq_git.bb
>> +++ b/recipes-devtools/yq/yq_git.bb
>> @@ -50,6 +50,13 @@ GO_IMPORT = "github.com/mikefarah/yq"
>>
>> inherit go ptest
>>
>> +go_do_compile() {
>> + export TMPDIR="${GOTMPDIR}"
>> + if [ -n "${GO_INSTALL}" ]; then
>> + ${GO} install ${GOBUILDFLAGS} `go_list_packages`
>> + fi
>> +}
>
>
> I wonder if it would be more appropriate to disable the linkshared with GO_LINKSHARED = ""
>
That didn't fix the buildah problem, but yes, this one could be
different in the solution.
That being said, I still suggest an entirely new do_compile(), to keep
control in the recipe.
Bruce
> Jose
>
>> +
>> do_compile:prepend() {
>> # arrange for some of the golang built ins to be found
>> (
>> --
>> 2.25.1
>>
>>
>>
>>
>
>
> --
> Best regards,
>
> José Quaresma
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7931): https://lists.yoctoproject.org/g/meta-virtualization/message/7931
> Mute This Topic: https://lists.yoctoproject.org/mt/97442079/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] yq: drop {LINKSHARED}
2023-03-07 13:54 ` Bruce Ashfield
@ 2023-03-08 3:42 ` mingli.yu
2023-03-08 22:08 ` [meta-virtualization] " Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: mingli.yu @ 2023-03-08 3:42 UTC (permalink / raw)
To: meta-virtualization
From: Mingli Yu <mingli.yu@windriver.com>
Redefine do_compile logic to drop {LINKSHARED} to fix the
below build failure.
WARNING: /build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/temp/run.do_compile.923432:185 exit 1 from 'aarch64-wrs-linux-go install -linkshared -p 48 -v -ldflags="-r /usr/lib64/go/pkg/linux_arm64_dynlink -I /lib64/ld-linux-aarch64.so.1 -extldflags ' -mcpu=cortex-a53 -march=armv8-a+crc -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot -Wl,-rpath-link=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot/usr/lib64/go/pkg/linux_arm64_dynlink -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot-native= -Wl,-z,relro,-z,now'" -trimpath -buildmode=pie `go_list_packages`'
Before the patch:
# rpm -ql yq
/usr
/usr/bin
/usr/bin/yq
# du -sh /usr/bin/yq
5.2M /usr/bin/yq
After the patch:
# rpm -ql yq
/usr
/usr/bin
/usr/bin/yq
# du -sh /usr/bin/yq
9.0M /usr/bin/yq
Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
recipes-devtools/yq/yq_git.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
index 45f2f970..bd474a79 100644
--- a/recipes-devtools/yq/yq_git.bb
+++ b/recipes-devtools/yq/yq_git.bb
@@ -50,7 +50,7 @@ GO_IMPORT = "github.com/mikefarah/yq"
inherit go ptest
-do_compile:prepend() {
+do_compile() {
# arrange for some of the golang built ins to be found
(
cd ${WORKDIR}/build/src/
@@ -60,6 +60,7 @@ do_compile:prepend() {
# arrange for the fetched dependencies to be found
export GOPATH="${GOPATH}:${WORKDIR}/build/vendor/"
export GO111MODULE=off
+ ${GO} install ${GOBUILDFLAGS} `go_list_packages`
}
do_install:append() {
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-virtualization] [PATCH v2] yq: drop {LINKSHARED}
2023-03-08 3:42 ` [PATCH v2] yq: drop {LINKSHARED} mingli.yu
@ 2023-03-08 22:08 ` Bruce Ashfield
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2023-03-08 22:08 UTC (permalink / raw)
To: Yu, Mingli; +Cc: meta-virtualization
v2 looks much better!
merged.
Bruce
In message: [meta-virtualization] [PATCH v2] yq: drop {LINKSHARED}
on 08/03/2023 Yu, Mingli wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
>
> Redefine do_compile logic to drop {LINKSHARED} to fix the
> below build failure.
> WARNING: /build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/temp/run.do_compile.923432:185 exit 1 from 'aarch64-wrs-linux-go install -linkshared -p 48 -v -ldflags="-r /usr/lib64/go/pkg/linux_arm64_dynlink -I /lib64/ld-linux-aarch64.so.1 -extldflags ' -mcpu=cortex-a53 -march=armv8-a+crc -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot -Wl,-rpath-link=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot/usr/lib64/go/pkg/linux_arm64_dynlink -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0 -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot= -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot-native= -Wl,-z,relro,-z,now'" -trimpath -buildmode=pie `go_list_packages`'
>
> Before the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 5.2M /usr/bin/yq
>
> After the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 9.0M /usr/bin/yq
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
> recipes-devtools/yq/yq_git.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
> index 45f2f970..bd474a79 100644
> --- a/recipes-devtools/yq/yq_git.bb
> +++ b/recipes-devtools/yq/yq_git.bb
> @@ -50,7 +50,7 @@ GO_IMPORT = "github.com/mikefarah/yq"
>
> inherit go ptest
>
> -do_compile:prepend() {
> +do_compile() {
> # arrange for some of the golang built ins to be found
> (
> cd ${WORKDIR}/build/src/
> @@ -60,6 +60,7 @@ do_compile:prepend() {
> # arrange for the fetched dependencies to be found
> export GOPATH="${GOPATH}:${WORKDIR}/build/vendor/"
> export GO111MODULE=off
> + ${GO} install ${GOBUILDFLAGS} `go_list_packages`
> }
>
> do_install:append() {
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7933): https://lists.yoctoproject.org/g/meta-virtualization/message/7933
> Mute This Topic: https://lists.yoctoproject.org/mt/97466079/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-08 22:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-07 2:48 [PATCH] yq: Drop {LINKSHARED} mingli.yu
2023-03-07 3:47 ` [meta-virtualization] " Bruce Ashfield
2023-03-07 11:57 ` Jose Quaresma
2023-03-07 13:54 ` Bruce Ashfield
2023-03-08 3:42 ` [PATCH v2] yq: drop {LINKSHARED} mingli.yu
2023-03-08 22:08 ` [meta-virtualization] " Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.