From: Baoquan He <bhe@redhat.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-arch@vger.kernel.org, linux-parisc@vger.kernel.org,
arnd@arndb.de, linux-sh@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, hch@infradead.org,
linux-mm@kvack.org, mcgrof@kernel.org, geert@linux-m68k.org,
linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org,
linux-hexagon@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures
Date: Fri, 10 Mar 2023 09:45:28 +0800 [thread overview]
Message-ID: <ZAqLuNrPng9i0rZV@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20230309143621.GA12350@alpha.franken.de>
On 03/09/23 at 03:36pm, Thomas Bogendoerfer wrote:
> On Wed, Mar 08, 2023 at 09:07:09PM +0800, Baoquan He wrote:
> > ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> > extension, and on ia64 with its slightly unconventional ioremap()
> > behavior. So remove the ioremap_uc() definition in architecutures
> > other than x86 and ia64. These architectures all have asm-generic/io.h
> > included and will have the default ioremap_uc() definition which
> > returns NULL.
> >
> > This changes the existing behaviour, while no need to worry about
> > any breakage because in the only callsite of ioremap_uc(), code
> > has been adjusted to eliminate the impact. Please see
> > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c.
> >
> > If any new invocation of ioremap_uc() need be added, please consider
> > using ioremap() intead or adding a ARCH specific version if necessary.
> >
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: linux-alpha@vger.kernel.org
> > Cc: linux-hexagon@vger.kernel.org
> > Cc: linux-m68k@lists.linux-m68k.org
> > Cc: linux-mips@vger.kernel.org
> > Cc: linux-parisc@vger.kernel.org
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Cc: linux-sh@vger.kernel.org
> > Cc: sparclinux@vger.kernel.org
> > ---
> > Documentation/driver-api/device-io.rst | 9 +++++----
> > arch/alpha/include/asm/io.h | 1 -
> > arch/hexagon/include/asm/io.h | 3 ---
> > arch/m68k/include/asm/kmap.h | 1 -
> > arch/mips/include/asm/io.h | 1 -
> > arch/parisc/include/asm/io.h | 2 --
> > arch/powerpc/include/asm/io.h | 1 -
> > arch/sh/include/asm/io.h | 2 --
> > arch/sparc/include/asm/io_64.h | 1 -
> > 9 files changed, 5 insertions(+), 16 deletions(-)
>
> this doesn't apply to v6.3-rc1... what tree is this based on ?
Sorry, I forgot mentioning this in cover letter. This series is
followup of below patchset, so it's on top of below patchset and based
on v6.3-rc1.
https://lore.kernel.org/all/20230301034247.136007-1-bhe@redhat.com/T/#u
[PATCH v5 00/17] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way
Thanks
Baoquan
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, arnd@arndb.de, mpe@ellerman.id.au,
geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org,
linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures
Date: Fri, 10 Mar 2023 09:45:28 +0800 [thread overview]
Message-ID: <ZAqLuNrPng9i0rZV@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20230309143621.GA12350@alpha.franken.de>
On 03/09/23 at 03:36pm, Thomas Bogendoerfer wrote:
> On Wed, Mar 08, 2023 at 09:07:09PM +0800, Baoquan He wrote:
> > ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> > extension, and on ia64 with its slightly unconventional ioremap()
> > behavior. So remove the ioremap_uc() definition in architecutures
> > other than x86 and ia64. These architectures all have asm-generic/io.h
> > included and will have the default ioremap_uc() definition which
> > returns NULL.
> >
> > This changes the existing behaviour, while no need to worry about
> > any breakage because in the only callsite of ioremap_uc(), code
> > has been adjusted to eliminate the impact. Please see
> > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c.
> >
> > If any new invocation of ioremap_uc() need be added, please consider
> > using ioremap() intead or adding a ARCH specific version if necessary.
> >
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: linux-alpha@vger.kernel.org
> > Cc: linux-hexagon@vger.kernel.org
> > Cc: linux-m68k@lists.linux-m68k.org
> > Cc: linux-mips@vger.kernel.org
> > Cc: linux-parisc@vger.kernel.org
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Cc: linux-sh@vger.kernel.org
> > Cc: sparclinux@vger.kernel.org
> > ---
> > Documentation/driver-api/device-io.rst | 9 +++++----
> > arch/alpha/include/asm/io.h | 1 -
> > arch/hexagon/include/asm/io.h | 3 ---
> > arch/m68k/include/asm/kmap.h | 1 -
> > arch/mips/include/asm/io.h | 1 -
> > arch/parisc/include/asm/io.h | 2 --
> > arch/powerpc/include/asm/io.h | 1 -
> > arch/sh/include/asm/io.h | 2 --
> > arch/sparc/include/asm/io_64.h | 1 -
> > 9 files changed, 5 insertions(+), 16 deletions(-)
>
> this doesn't apply to v6.3-rc1... what tree is this based on ?
Sorry, I forgot mentioning this in cover letter. This series is
followup of below patchset, so it's on top of below patchset and based
on v6.3-rc1.
https://lore.kernel.org/all/20230301034247.136007-1-bhe@redhat.com/T/#u
[PATCH v5 00/17] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way
Thanks
Baoquan
next prev parent reply other threads:[~2023-03-10 1:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 13:07 [PATCH v4 0/4] arch/*/io.h: remove ioremap_uc in some architectures Baoquan He
2023-03-08 13:07 ` [PATCH v4 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Baoquan He
2023-03-08 13:07 ` Baoquan He
2023-03-08 20:01 ` Luis Chamberlain
2023-03-08 20:01 ` Luis Chamberlain
2023-03-08 21:34 ` Arnd Bergmann
2023-03-08 21:34 ` Arnd Bergmann
2023-03-08 21:49 ` Helge Deller
2023-03-08 21:49 ` Helge Deller
2023-03-08 22:48 ` Ondrej Zary
2023-03-08 22:48 ` Ondrej Zary
2023-03-08 13:07 ` [PATCH v4 2/4] mips: add <asm-generic/io.h> including Baoquan He
2023-03-13 17:55 ` Thomas Bogendoerfer
2023-03-14 2:56 ` Baoquan He
2023-03-14 15:34 ` Thomas Bogendoerfer
2023-03-14 16:31 ` Florian Fainelli
2023-03-14 17:19 ` Arnd Bergmann
2023-03-15 0:49 ` Baoquan He
2023-03-15 12:52 ` Thomas Bogendoerfer
2023-03-08 13:07 ` [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures Baoquan He
2023-03-08 13:07 ` Baoquan He
2023-03-09 14:36 ` Thomas Bogendoerfer
2023-03-09 14:36 ` Thomas Bogendoerfer
2023-03-10 1:45 ` Baoquan He [this message]
2023-03-10 1:45 ` Baoquan He
2023-03-10 21:14 ` Helge Deller
2023-03-10 21:14 ` Helge Deller
2023-03-09 22:54 ` Michael Ellerman
2023-03-09 22:54 ` Michael Ellerman
2023-03-08 13:07 ` [PATCH v4 4/4] mips: io: remove duplicated codes Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAqLuNrPng9i0rZV@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mcgrof@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.