From: Jianhua Lu <lujianhua000@gmail.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523
Date: Fri, 10 Mar 2023 17:33:28 +0800 [thread overview]
Message-ID: <ZAr5aO0BpSeW5iXD@Gentoo> (raw)
In-Reply-To: <aac6ba9c-4230-aff7-c93d-23eaf6895464@linaro.org>
On Thu, Mar 09, 2023 at 11:37:17PM +0100, Konrad Dybcio wrote:
>
> [...]
> = of_graph_get_remote_node(dsi->dev.of_node, 1, -1);
> >>>>> + if (!dsi1) {
> >>>>> + dev_err(dev, "cannot get secondary DSI node.\n");
> >>>>> + return -ENODEV;
> >>>>> + }
> >>>>> +
> >>>>> + dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
> >>>>> + of_node_put(dsi1);
> >>>> Shouldn't you put the reference only if it's found?
> >>> thanks for spot it.
> Apparently not.. please don't change this
OK
>
> Konrad
> >>>>
> >>>>> + if (!dsi1_host) {
> >>>>> + dev_err(dev, "cannot get secondary DSI host\n");
> >>>>> + return -EPROBE_DEFER;
> >>>> dev_err_probe, here and in neighbouring exit return paths?
> >>> Acked.
> >>>>
> >>>>
> >>>> Konrad
WARNING: multiple messages have this Message-ID (diff)
From: Jianhua Lu <lujianhua000@gmail.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
devicetree@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523
Date: Fri, 10 Mar 2023 17:33:28 +0800 [thread overview]
Message-ID: <ZAr5aO0BpSeW5iXD@Gentoo> (raw)
In-Reply-To: <aac6ba9c-4230-aff7-c93d-23eaf6895464@linaro.org>
On Thu, Mar 09, 2023 at 11:37:17PM +0100, Konrad Dybcio wrote:
>
> [...]
> = of_graph_get_remote_node(dsi->dev.of_node, 1, -1);
> >>>>> + if (!dsi1) {
> >>>>> + dev_err(dev, "cannot get secondary DSI node.\n");
> >>>>> + return -ENODEV;
> >>>>> + }
> >>>>> +
> >>>>> + dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
> >>>>> + of_node_put(dsi1);
> >>>> Shouldn't you put the reference only if it's found?
> >>> thanks for spot it.
> Apparently not.. please don't change this
OK
>
> Konrad
> >>>>
> >>>>> + if (!dsi1_host) {
> >>>>> + dev_err(dev, "cannot get secondary DSI host\n");
> >>>>> + return -EPROBE_DEFER;
> >>>> dev_err_probe, here and in neighbouring exit return paths?
> >>> Acked.
> >>>>
> >>>>
> >>>> Konrad
next prev parent reply other threads:[~2023-03-10 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 4:37 [PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings Jianhua Lu
2023-03-08 4:37 ` Jianhua Lu
2023-03-08 4:37 ` [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523 Jianhua Lu
2023-03-08 4:37 ` Jianhua Lu
2023-03-08 11:13 ` Konrad Dybcio
2023-03-08 11:13 ` Konrad Dybcio
2023-03-08 11:53 ` Jianhua Lu
2023-03-08 11:53 ` Jianhua Lu
2023-03-08 12:33 ` Konrad Dybcio
2023-03-08 12:33 ` Konrad Dybcio
2023-03-08 13:37 ` Jianhua Lu
2023-03-08 13:37 ` Jianhua Lu
2023-03-09 22:37 ` Konrad Dybcio
2023-03-09 22:37 ` Konrad Dybcio
2023-03-10 9:33 ` Jianhua Lu [this message]
2023-03-10 9:33 ` Jianhua Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAr5aO0BpSeW5iXD@Gentoo \
--to=lujianhua000@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.