From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kurt Kanzenbach <kurt@linutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get()
Date: Fri, 10 Mar 2023 20:44:04 +0200 [thread overview]
Message-ID: <ZAt6dDGQ7stx36UC@smile.fi.intel.com> (raw)
In-Reply-To: <ZAt0gqmOifS65Z91@corigine.com>
On Fri, Mar 10, 2023 at 07:18:42PM +0100, Simon Horman wrote:
> On Fri, Mar 10, 2023 at 06:38:55PM +0200, Andy Shevchenko wrote:
...
> > + hellcreek->led_sync_good.brightness =
> > + hellcreek_get_brightness(hellcreek, STATUS_OUT_SYNC_GOOD);
>
> nit: I think < 80 columns wide is still preferred for network code
I can do it if it's a strict rule here.
...
> This seems to duplicate the logic in the earlier hunk of this patch.
> Could it be moved into a helper?
It's possible, but in a separate patch as it's out of scope of this one.
Do you want to create a such?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-10 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 16:38 [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() Andy Shevchenko
2023-03-10 18:18 ` Simon Horman
2023-03-10 18:44 ` Andy Shevchenko [this message]
2023-03-10 20:06 ` Andy Shevchenko
2023-03-10 20:16 ` Simon Horman
2023-03-10 20:23 ` Andy Shevchenko
2023-03-10 20:17 ` Simon Horman
2023-03-11 2:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAt6dDGQ7stx36UC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.