All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chester Lin <clin@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"NXP S32 Linux Team" <s32@nxp.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Ghennadi Procopciuc" <Ghennadi.Procopciuc@oss.nxp.com>,
	"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
	"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Matthias Brugger" <mbrugger@suse.com>
Subject: Re: [PATCH v3 6/6] pinctrl: s32: separate const device data from struct s32_pinctrl_soc_info
Date: Fri, 24 Mar 2023 15:45:49 +0800	[thread overview]
Message-ID: <ZB1VLbvTudD2Ye5C@linux-8mug> (raw)
In-Reply-To: <CAHp75VfnVzrVLUpXdspw1H-e4qxVzia+hf_2uJ5xgSm6Q0C7ug@mail.gmail.com>

Hi Andy,

Thanks for reviewing this patch!

On Thu, Mar 23, 2023 at 08:50:41PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 23, 2023 at 4:49 PM Chester Lin <clin@suse.com> wrote:
> >
> > The .data field in struct of_device_id is used as a const member so it's
> > inappropriate to attach struct s32_pinctrl_soc_info with of_device_id
> > because some members in s32_pinctrl_soc_info need to be filled by
> > pinctrl-s32cc at runtime.
> >
> > For this reason, struct s32_pinctrl_soc_info must be allocated in
> > pinctrl-s32cc and then create a new struct s32_pinctrl_soc_data in order
> > to represent const .data in of_device_id. To combine these two structures,
> > a s32_pinctrl_soc_data pointer is introduced in s32_pinctrl_soc_info.
> 
> So, the first patch has to be embedded in this one, correct?

Correct. Leave the first patch alone will cause a compiler warning.

> Don't forget to compile and test your contributions beforehand.

Will do.

Regards,
Chester

> 
> -- 
> With Best Regards,
> Andy Shevchenko

WARNING: multiple messages have this Message-ID (diff)
From: Chester Lin <clin@suse.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"NXP S32 Linux Team" <s32@nxp.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Ghennadi Procopciuc" <Ghennadi.Procopciuc@oss.nxp.com>,
	"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
	"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Matthias Brugger" <mbrugger@suse.com>
Subject: Re: [PATCH v3 6/6] pinctrl: s32: separate const device data from struct s32_pinctrl_soc_info
Date: Fri, 24 Mar 2023 15:45:49 +0800	[thread overview]
Message-ID: <ZB1VLbvTudD2Ye5C@linux-8mug> (raw)
In-Reply-To: <CAHp75VfnVzrVLUpXdspw1H-e4qxVzia+hf_2uJ5xgSm6Q0C7ug@mail.gmail.com>

Hi Andy,

Thanks for reviewing this patch!

On Thu, Mar 23, 2023 at 08:50:41PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 23, 2023 at 4:49 PM Chester Lin <clin@suse.com> wrote:
> >
> > The .data field in struct of_device_id is used as a const member so it's
> > inappropriate to attach struct s32_pinctrl_soc_info with of_device_id
> > because some members in s32_pinctrl_soc_info need to be filled by
> > pinctrl-s32cc at runtime.
> >
> > For this reason, struct s32_pinctrl_soc_info must be allocated in
> > pinctrl-s32cc and then create a new struct s32_pinctrl_soc_data in order
> > to represent const .data in of_device_id. To combine these two structures,
> > a s32_pinctrl_soc_data pointer is introduced in s32_pinctrl_soc_info.
> 
> So, the first patch has to be embedded in this one, correct?

Correct. Leave the first patch alone will cause a compiler warning.

> Don't forget to compile and test your contributions beforehand.

Will do.

Regards,
Chester

> 
> -- 
> With Best Regards,
> Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-24  7:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 14:48 [PATCH v3 0/6] pinctrl: s32: driver improvements and generic struct use Chester Lin
2023-03-23 14:48 ` Chester Lin
2023-03-23 14:48 ` [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match_data() to get device data Chester Lin
2023-03-23 14:48   ` Chester Lin
2023-03-23 17:11   ` kernel test robot
2023-03-23 17:11     ` kernel test robot
2023-03-23 17:42     ` Chester Lin
2023-03-23 17:42       ` Chester Lin
2023-03-23 14:48 ` [PATCH v3 2/6] pinctrl: s32: refine error/return/config checks and simplify driver codes Chester Lin
2023-03-23 14:48   ` Chester Lin
2023-03-23 14:48 ` [PATCH v3 3/6] pinctrl: s32cc: refactor pin config parsing Chester Lin
2023-03-23 14:48   ` Chester Lin
2023-03-23 18:44   ` Andy Shevchenko
2023-03-23 18:44     ` Andy Shevchenko
2023-03-23 14:48 ` [PATCH v3 4/6] pinctrl: s32cc: embed generic struct pingroup Chester Lin
2023-03-23 14:48   ` Chester Lin
2023-03-23 14:48 ` [PATCH v3 5/6] pinctrl: s32cc: Use generic struct data to describe pin function Chester Lin
2023-03-23 14:48   ` Chester Lin
2023-03-23 18:49   ` Andy Shevchenko
2023-03-23 18:49     ` Andy Shevchenko
2023-03-23 14:48 ` [PATCH v3 6/6] pinctrl: s32: separate const device data from struct s32_pinctrl_soc_info Chester Lin
2023-03-23 14:48   ` Chester Lin
2023-03-23 18:50   ` Andy Shevchenko
2023-03-23 18:50     ` Andy Shevchenko
2023-03-24  7:45     ` Chester Lin [this message]
2023-03-24  7:45       ` Chester Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZB1VLbvTudD2Ye5C@linux-8mug \
    --to=clin@suse.com \
    --cc=Ghennadi.Procopciuc@oss.nxp.com \
    --cc=afaerber@suse.de \
    --cc=andrei.stefanescu@nxp.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbrugger@suse.com \
    --cc=radu-nicolae.pirea@nxp.com \
    --cc=s32@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.