From: Sean Christopherson <seanjc@google.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH kernel v4] KVM: PPC: Make KVM_CAP_IRQFD_RESAMPLE support platform dependent
Date: Wed, 15 Mar 2023 10:16:45 -0700 [thread overview]
Message-ID: <ZBH9fZ3aMnHKtrZj@google.com> (raw)
In-Reply-To: <20221003235722.2085145-1-aik@ozlabs.ru>
+Michael and KVM s390 maintainers
On Tue, Oct 04, 2022, Alexey Kardashevskiy wrote:
> When introduced, IRQFD resampling worked on POWER8 with XICS. However
> KVM on POWER9 has never implemented it - the compatibility mode code
> ("XICS-on-XIVE") misses the kvm_notify_acked_irq() call and the native
> XIVE mode does not handle INTx in KVM at all.
>
> This moved the capability support advertising to platforms and stops
> advertising it on XIVE, i.e. POWER9 and later.
>
> This should cause no behavioural change for other architectures.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Acked-by: Nicholas Piggin <npiggin@gmail.com>
> Acked-by: Marc Zyngier <maz@kernel.org>
> ---
If no one objects, I'll grab this for 6.4 and route it through kvm-x86/generic.
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index fb1490761c87..908ce8bd91c9 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -593,6 +593,12 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> break;
> #endif
>
> +#ifdef CONFIG_HAVE_KVM_IRQFD
> + case KVM_CAP_IRQFD_RESAMPLE:
> + r = !xive_enabled();
> + break;
> +#endif
@PPC folks, do you want to avoid the #ifdef? If so, I can tweak to this when
applying.
case KVM_CAP_IRQFD_RESAMPLE:
r = IS_ENABLED(CONFIG_HAVE_KVM_IRQFD) && !xive_enabled();
break;
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org,
Paolo Bonzini <pbonzini@redhat.com>,
Anup Patel <anup@brainfault.org>,
kvm-ppc@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: [PATCH kernel v4] KVM: PPC: Make KVM_CAP_IRQFD_RESAMPLE support platform dependent
Date: Wed, 15 Mar 2023 17:16:45 +0000 [thread overview]
Message-ID: <ZBH9fZ3aMnHKtrZj@google.com> (raw)
In-Reply-To: <20221003235722.2085145-1-aik@ozlabs.ru>
+Michael and KVM s390 maintainers
On Tue, Oct 04, 2022, Alexey Kardashevskiy wrote:
> When introduced, IRQFD resampling worked on POWER8 with XICS. However
> KVM on POWER9 has never implemented it - the compatibility mode code
> ("XICS-on-XIVE") misses the kvm_notify_acked_irq() call and the native
> XIVE mode does not handle INTx in KVM at all.
>
> This moved the capability support advertising to platforms and stops
> advertising it on XIVE, i.e. POWER9 and later.
>
> This should cause no behavioural change for other architectures.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Acked-by: Nicholas Piggin <npiggin@gmail.com>
> Acked-by: Marc Zyngier <maz@kernel.org>
> ---
If no one objects, I'll grab this for 6.4 and route it through kvm-x86/generic.
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index fb1490761c87..908ce8bd91c9 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -593,6 +593,12 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> break;
> #endif
>
> +#ifdef CONFIG_HAVE_KVM_IRQFD
> + case KVM_CAP_IRQFD_RESAMPLE:
> + r = !xive_enabled();
> + break;
> +#endif
@PPC folks, do you want to avoid the #ifdef? If so, I can tweak to this when
applying.
case KVM_CAP_IRQFD_RESAMPLE:
r = IS_ENABLED(CONFIG_HAVE_KVM_IRQFD) && !xive_enabled();
break;
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org,
Paolo Bonzini <pbonzini@redhat.com>,
Anup Patel <anup@brainfault.org>,
kvm-ppc@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: [PATCH kernel v4] KVM: PPC: Make KVM_CAP_IRQFD_RESAMPLE support platform dependent
Date: Wed, 15 Mar 2023 10:16:45 -0700 [thread overview]
Message-ID: <ZBH9fZ3aMnHKtrZj@google.com> (raw)
In-Reply-To: <20221003235722.2085145-1-aik@ozlabs.ru>
+Michael and KVM s390 maintainers
On Tue, Oct 04, 2022, Alexey Kardashevskiy wrote:
> When introduced, IRQFD resampling worked on POWER8 with XICS. However
> KVM on POWER9 has never implemented it - the compatibility mode code
> ("XICS-on-XIVE") misses the kvm_notify_acked_irq() call and the native
> XIVE mode does not handle INTx in KVM at all.
>
> This moved the capability support advertising to platforms and stops
> advertising it on XIVE, i.e. POWER9 and later.
>
> This should cause no behavioural change for other architectures.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Acked-by: Nicholas Piggin <npiggin@gmail.com>
> Acked-by: Marc Zyngier <maz@kernel.org>
> ---
If no one objects, I'll grab this for 6.4 and route it through kvm-x86/generic.
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index fb1490761c87..908ce8bd91c9 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -593,6 +593,12 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> break;
> #endif
>
> +#ifdef CONFIG_HAVE_KVM_IRQFD
> + case KVM_CAP_IRQFD_RESAMPLE:
> + r = !xive_enabled();
> + break;
> +#endif
@PPC folks, do you want to avoid the #ifdef? If so, I can tweak to this when
applying.
case KVM_CAP_IRQFD_RESAMPLE:
r = IS_ENABLED(CONFIG_HAVE_KVM_IRQFD) && !xive_enabled();
break;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org,
Paolo Bonzini <pbonzini@redhat.com>,
Anup Patel <anup@brainfault.org>,
kvm-ppc@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: [PATCH kernel v4] KVM: PPC: Make KVM_CAP_IRQFD_RESAMPLE support platform dependent
Date: Wed, 15 Mar 2023 10:16:45 -0700 [thread overview]
Message-ID: <ZBH9fZ3aMnHKtrZj@google.com> (raw)
In-Reply-To: <20221003235722.2085145-1-aik@ozlabs.ru>
+Michael and KVM s390 maintainers
On Tue, Oct 04, 2022, Alexey Kardashevskiy wrote:
> When introduced, IRQFD resampling worked on POWER8 with XICS. However
> KVM on POWER9 has never implemented it - the compatibility mode code
> ("XICS-on-XIVE") misses the kvm_notify_acked_irq() call and the native
> XIVE mode does not handle INTx in KVM at all.
>
> This moved the capability support advertising to platforms and stops
> advertising it on XIVE, i.e. POWER9 and later.
>
> This should cause no behavioural change for other architectures.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Acked-by: Nicholas Piggin <npiggin@gmail.com>
> Acked-by: Marc Zyngier <maz@kernel.org>
> ---
If no one objects, I'll grab this for 6.4 and route it through kvm-x86/generic.
> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
> index fb1490761c87..908ce8bd91c9 100644
> --- a/arch/powerpc/kvm/powerpc.c
> +++ b/arch/powerpc/kvm/powerpc.c
> @@ -593,6 +593,12 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
> break;
> #endif
>
> +#ifdef CONFIG_HAVE_KVM_IRQFD
> + case KVM_CAP_IRQFD_RESAMPLE:
> + r = !xive_enabled();
> + break;
> +#endif
@PPC folks, do you want to avoid the #ifdef? If so, I can tweak to this when
applying.
case KVM_CAP_IRQFD_RESAMPLE:
r = IS_ENABLED(CONFIG_HAVE_KVM_IRQFD) && !xive_enabled();
break;
next prev parent reply other threads:[~2023-03-15 17:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 23:57 [PATCH kernel v4] KVM: PPC: Make KVM_CAP_IRQFD_RESAMPLE support platform dependent Alexey Kardashevskiy
2022-10-03 23:57 ` Alexey Kardashevskiy
2022-10-03 23:57 ` Alexey Kardashevskiy
2022-10-03 23:57 ` Alexey Kardashevskiy
2022-10-03 23:57 ` Alexey Kardashevskiy
2022-10-27 7:38 ` Alexey Kardashevskiy
2022-10-27 7:38 ` Alexey Kardashevskiy
2022-10-27 7:38 ` Alexey Kardashevskiy
2022-10-27 7:38 ` Alexey Kardashevskiy
2022-10-27 7:38 ` Alexey Kardashevskiy
2022-12-06 4:39 ` Alexey Kardashevskiy
2022-12-06 4:39 ` Alexey Kardashevskiy
2022-12-06 4:39 ` Alexey Kardashevskiy
2022-12-06 4:39 ` Alexey Kardashevskiy
2022-12-06 4:39 ` Alexey Kardashevskiy
2023-01-02 0:43 ` Alexey Kardashevskiy
2023-01-02 0:43 ` Alexey Kardashevskiy
2023-01-02 0:43 ` Alexey Kardashevskiy
2023-01-02 0:43 ` Alexey Kardashevskiy
2023-01-02 0:43 ` Alexey Kardashevskiy
2023-02-28 6:17 ` Alexey Kardashevskiy
2023-02-28 6:17 ` Alexey Kardashevskiy
2023-02-28 6:17 ` Alexey Kardashevskiy
2023-02-28 6:17 ` Alexey Kardashevskiy
2023-03-07 0:24 ` Alexey Kardashevskiy
2023-03-07 0:24 ` Alexey Kardashevskiy
2023-03-07 0:24 ` Alexey Kardashevskiy
2023-03-07 0:24 ` Alexey Kardashevskiy
2023-03-31 15:19 ` Paolo Bonzini
2023-03-31 15:19 ` Paolo Bonzini
2023-03-31 15:19 ` Paolo Bonzini
2023-03-31 15:19 ` Paolo Bonzini
2023-03-15 17:16 ` Sean Christopherson [this message]
2023-03-15 17:16 ` Sean Christopherson
2023-03-15 17:16 ` Sean Christopherson
2023-03-15 17:16 ` Sean Christopherson
2023-03-28 4:30 ` Alexey Kardashevskiy
2023-03-28 4:30 ` Alexey Kardashevskiy
2023-03-28 4:30 ` Alexey Kardashevskiy
2023-03-28 4:30 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBH9fZ3aMnHKtrZj@google.com \
--to=seanjc@google.com \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.