All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: will@kernel.org, joro@8bytes.org, robin.murphy@arm.com,
	andersson@kernel.org, johan+linaro@kernel.org, steev@kali.org,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iommu/arm-smmu-qcom: Rework the logic finding the bypass quirk
Date: Wed, 15 Mar 2023 15:12:26 +0100	[thread overview]
Message-ID: <ZBHSSrcOYtLpnFsm@hovoldconsulting.com> (raw)
In-Reply-To: <20230315133730.GB98059@thinkpad>

On Wed, Mar 15, 2023 at 07:07:30PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Mar 15, 2023 at 09:38:42AM +0100, Johan Hovold wrote:
> > On Wed, Mar 15, 2023 at 01:29:58PM +0530, Manivannan Sadhasivam wrote:
> > > On Wed, Mar 15, 2023 at 08:37:32AM +0100, Johan Hovold wrote:
> > 
> > > > > +static int qcom_smmu_cfg_probe(struct arm_smmu_device *smmu)
> > > > > +{
> > > > > +	u32 smr;
> > > > > +	int i;
> > > > > +
> > > > > +	/*
> > > > > +	 * Limit the number of stream matching groups to 128 as the ARM SMMU architecture
> > > > > +	 * specification defines NUMSMRG (Number of Stream Mapping Register Groups) in the
> > > > > +	 * range of 0-127, but some Qcom platforms emulate more stream mapping groups. And
> > > > > +	 * those groups don't exhibit the same behavior as the architecture supported ones.
> > > > > +	 */
> > > > 
> > > > Please fix your editor so that it wraps lines at 80 columns, which is
> > > > still the preferred (soft) limit.
> > > > 
> > > 
> > > If exceeding 80 columns end up making the comment more readable (fewer lines),
> > > then why should we limit ourselves?
> > 
> > Exceeding 80 column for comments does generally not improve readability.
> > 
> 
> It all depends on the perspective/preference... But I can limit to 80 columns
> here.

No, this is not about preference. The soft limit is 80 columns and a
valid reason for breaking that for comments would be, for example, if
you have a long URL or something which does not fit within that width
(and not just personal preference).

Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: will@kernel.org, joro@8bytes.org, robin.murphy@arm.com,
	andersson@kernel.org, johan+linaro@kernel.org, steev@kali.org,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iommu/arm-smmu-qcom: Rework the logic finding the bypass quirk
Date: Wed, 15 Mar 2023 15:12:26 +0100	[thread overview]
Message-ID: <ZBHSSrcOYtLpnFsm@hovoldconsulting.com> (raw)
In-Reply-To: <20230315133730.GB98059@thinkpad>

On Wed, Mar 15, 2023 at 07:07:30PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Mar 15, 2023 at 09:38:42AM +0100, Johan Hovold wrote:
> > On Wed, Mar 15, 2023 at 01:29:58PM +0530, Manivannan Sadhasivam wrote:
> > > On Wed, Mar 15, 2023 at 08:37:32AM +0100, Johan Hovold wrote:
> > 
> > > > > +static int qcom_smmu_cfg_probe(struct arm_smmu_device *smmu)
> > > > > +{
> > > > > +	u32 smr;
> > > > > +	int i;
> > > > > +
> > > > > +	/*
> > > > > +	 * Limit the number of stream matching groups to 128 as the ARM SMMU architecture
> > > > > +	 * specification defines NUMSMRG (Number of Stream Mapping Register Groups) in the
> > > > > +	 * range of 0-127, but some Qcom platforms emulate more stream mapping groups. And
> > > > > +	 * those groups don't exhibit the same behavior as the architecture supported ones.
> > > > > +	 */
> > > > 
> > > > Please fix your editor so that it wraps lines at 80 columns, which is
> > > > still the preferred (soft) limit.
> > > > 
> > > 
> > > If exceeding 80 columns end up making the comment more readable (fewer lines),
> > > then why should we limit ourselves?
> > 
> > Exceeding 80 column for comments does generally not improve readability.
> > 
> 
> It all depends on the perspective/preference... But I can limit to 80 columns
> here.

No, this is not about preference. The soft limit is 80 columns and a
valid reason for breaking that for comments would be, for example, if
you have a long URL or something which does not fit within that width
(and not just personal preference).

Johan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-15 14:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 18:46 [PATCH v3] iommu/arm-smmu-qcom: Rework the logic finding the bypass quirk Manivannan Sadhasivam
2023-03-14 18:46 ` Manivannan Sadhasivam
2023-03-15  7:37 ` Johan Hovold
2023-03-15  7:37   ` Johan Hovold
2023-03-15  7:59   ` Manivannan Sadhasivam
2023-03-15  7:59     ` Manivannan Sadhasivam
2023-03-15  8:38     ` Johan Hovold
2023-03-15  8:38       ` Johan Hovold
2023-03-15 13:37       ` Manivannan Sadhasivam
2023-03-15 13:37         ` Manivannan Sadhasivam
2023-03-15 14:12         ` Johan Hovold [this message]
2023-03-15 14:12           ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBHSSrcOYtLpnFsm@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=andersson@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=johan+linaro@kernel.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robin.murphy@arm.com \
    --cc=steev@kali.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.