From: Wolfram Sang <wsa@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] i2c: imx-lpi2c: check only for enabled interrupt flags
Date: Thu, 16 Mar 2023 20:36:24 +0100 [thread overview]
Message-ID: <ZBNvuBZYZSc0P9w9@shikoro> (raw)
In-Reply-To: <20230130153247.445027-2-alexander.stein@ew.tq-group.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Mon, Jan 30, 2023 at 04:32:47PM +0100, Alexander Stein wrote:
> When reading from I2C, the Tx watermark is set to 0. Unfortunately the
> TDF (transmit data flag) is enabled when Tx FIFO entries is equal or less
> than watermark. So it is set in every case, hence the reset default of 1.
> This results in the MSR_RDF _and_ MSR_TDF flags to be set thus trying
> to send Tx data on a read message.
> Mask the IRQ status to filter for wanted flags only.
>
> Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] i2c: imx-lpi2c: check only for enabled interrupt flags
Date: Thu, 16 Mar 2023 20:36:24 +0100 [thread overview]
Message-ID: <ZBNvuBZYZSc0P9w9@shikoro> (raw)
In-Reply-To: <20230130153247.445027-2-alexander.stein@ew.tq-group.com>
[-- Attachment #1.1: Type: text/plain, Size: 642 bytes --]
On Mon, Jan 30, 2023 at 04:32:47PM +0100, Alexander Stein wrote:
> When reading from I2C, the Tx watermark is set to 0. Unfortunately the
> TDF (transmit data flag) is enabled when Tx FIFO entries is equal or less
> than watermark. So it is set in every case, hence the reset default of 1.
> This results in the MSR_RDF _and_ MSR_TDF flags to be set thus trying
> to send Tx data on a read message.
> Mask the IRQ status to filter for wanted flags only.
>
> Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-16 19:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 15:32 [PATCH 1/2] i2c: imx-lpi2c: clean rx/tx buffers upon new message Alexander Stein
2023-01-30 15:32 ` Alexander Stein
2023-01-30 15:32 ` [PATCH 2/2] i2c: imx-lpi2c: check only for enabled interrupt flags Alexander Stein
2023-01-30 15:32 ` Alexander Stein
2023-03-16 19:36 ` Wolfram Sang [this message]
2023-03-16 19:36 ` Wolfram Sang
2023-02-14 6:53 ` [PATCH 1/2] i2c: imx-lpi2c: clean rx/tx buffers upon new message Alexander Stein
2023-02-14 6:53 ` Alexander Stein
2023-03-02 11:06 ` Emanuele Ghidoli
2023-03-02 11:06 ` Emanuele Ghidoli
2023-03-02 11:15 ` Alexander Stein
2023-03-02 11:15 ` Alexander Stein
2023-03-02 11:50 ` Emanuele Ghidoli
2023-03-02 11:50 ` Emanuele Ghidoli
2023-03-03 7:21 ` Emanuele Ghidoli
2023-03-03 7:21 ` Emanuele Ghidoli
2023-03-09 21:19 ` Wolfram Sang
2023-03-09 21:19 ` Wolfram Sang
2023-03-16 19:37 ` Wolfram Sang
2023-03-16 19:37 ` Wolfram Sang
2023-03-16 19:36 ` Wolfram Sang
2023-03-16 19:36 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBNvuBZYZSc0P9w9@shikoro \
--to=wsa@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.