All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Shenwei Wang <shenwei.wang@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/1] net: stmmac: start PHY early in __stmmac_open
Date: Fri, 17 Mar 2023 17:38:59 +0000	[thread overview]
Message-ID: <ZBSlsyv+qcd30hBg@shell.armlinux.org.uk> (raw)
In-Reply-To: <f348ece4-90ef-4368-893a-73de37410fd2@lunn.ch>

On Fri, Mar 17, 2023 at 06:34:13PM +0100, Andrew Lunn wrote:
> > NAK. A patch similar to this has already been sent.
> > 
> > The problem with just moving this is that phylink can call the
> > mac_link_up() method *before* phylink_start() has returned - and as
> > this driver has not completed the setup, it doesn't expect the link
> > to come up at that point.
> > 
> > There are several issues with this driver wanting the PHY clock early,
> > and there have been two people working on addressing this previously,
> > proposing two different changes to phylink.
> > 
> > I sent them away to talk to each other and come back with a unified
> > solution. Shock horror, they never came back.
> > 
> > Now we seem to be starting again from the beginning.
> > 
> > stmmac folk really need to get a handle on this so reviewers are not
> > having to NAK similar patches time and time again, resulting in the
> > problem not being solved.
> 
> And just adding to that, Developers should also get into the habit of
> searching to see if somebody has already tried and failed to solve the
> problem.
> 
> “Those Who Do Not Learn History Are Doomed To Repeat It.”
> 
> Try avoiding wasting everybody's times by learning a bit of history.

+1,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000!

(Yes, factorial too! :) )

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Shenwei Wang <shenwei.wang@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/1] net: stmmac: start PHY early in __stmmac_open
Date: Fri, 17 Mar 2023 17:38:59 +0000	[thread overview]
Message-ID: <ZBSlsyv+qcd30hBg@shell.armlinux.org.uk> (raw)
In-Reply-To: <f348ece4-90ef-4368-893a-73de37410fd2@lunn.ch>

On Fri, Mar 17, 2023 at 06:34:13PM +0100, Andrew Lunn wrote:
> > NAK. A patch similar to this has already been sent.
> > 
> > The problem with just moving this is that phylink can call the
> > mac_link_up() method *before* phylink_start() has returned - and as
> > this driver has not completed the setup, it doesn't expect the link
> > to come up at that point.
> > 
> > There are several issues with this driver wanting the PHY clock early,
> > and there have been two people working on addressing this previously,
> > proposing two different changes to phylink.
> > 
> > I sent them away to talk to each other and come back with a unified
> > solution. Shock horror, they never came back.
> > 
> > Now we seem to be starting again from the beginning.
> > 
> > stmmac folk really need to get a handle on this so reviewers are not
> > having to NAK similar patches time and time again, resulting in the
> > problem not being solved.
> 
> And just adding to that, Developers should also get into the habit of
> searching to see if somebody has already tried and failed to solve the
> problem.
> 
> “Those Who Do Not Learn History Are Doomed To Repeat It.”
> 
> Try avoiding wasting everybody's times by learning a bit of history.

+1,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000!

(Yes, factorial too! :) )

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-17 17:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 20:54 [PATCH 1/1] net: stmmac: start PHY early in __stmmac_open Shenwei Wang
2023-03-16 20:54 ` Shenwei Wang
2023-03-16 21:56 ` Russell King (Oracle)
2023-03-16 21:56   ` Russell King (Oracle)
2023-03-17 17:34   ` Andrew Lunn
2023-03-17 17:34     ` Andrew Lunn
2023-03-17 17:38     ` Russell King (Oracle) [this message]
2023-03-17 17:38       ` Russell King (Oracle)
2023-03-17 17:47     ` Florian Fainelli
2023-03-17 17:47       ` Florian Fainelli
2023-03-20 14:07   ` [EXT] " Shenwei Wang
2023-03-20 14:07     ` Shenwei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBSlsyv+qcd30hBg@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=imx@lists.linux.dev \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=shenwei.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.