All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt
Date: Fri, 17 Mar 2023 23:09:10 +0530	[thread overview]
Message-ID: <ZBSlvrDmKGjwWBa7@matsya> (raw)
In-Reply-To: <20230313170250.815-2-jszhang@kernel.org>

On 14-03-23, 01:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it

The dmaengine framework...

> outself is wrong.

s/outself/ourself

Looks this this is needed for all the patches

> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 4169e1d7d5ca..7f3a60e28e38 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev)
>  	dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask);
>  
>  	/* DMA capabilities */
> -	dw->dma.chancnt = hdata->nr_channels;
>  	dw->dma.max_burst = hdata->axi_rw_burst_len;
>  	dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS;
>  	dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS;
> -- 
> 2.39.2

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Sinan Kaya <okaya@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt
Date: Fri, 17 Mar 2023 23:09:10 +0530	[thread overview]
Message-ID: <ZBSlvrDmKGjwWBa7@matsya> (raw)
In-Reply-To: <20230313170250.815-2-jszhang@kernel.org>

On 14-03-23, 01:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it

The dmaengine framework...

> outself is wrong.

s/outself/ourself

Looks this this is needed for all the patches

> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> index 4169e1d7d5ca..7f3a60e28e38 100644
> --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev)
>  	dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask);
>  
>  	/* DMA capabilities */
> -	dw->dma.chancnt = hdata->nr_channels;
>  	dw->dma.max_burst = hdata->axi_rw_burst_len;
>  	dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS;
>  	dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS;
> -- 
> 2.39.2

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-17 17:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 17:02 [PATCH 0/5] dma: don't set chancnt Jisheng Zhang
2023-03-13 17:02 ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 1/5] dmaengine: dw-axi-dmac: Don't " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-17 17:39   ` Vinod Koul [this message]
2023-03-17 17:39     ` Vinod Koul
2023-03-13 17:02 ` [PATCH 2/5] dmaengine: axi-dmac: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-13 17:36   ` Lars-Peter Clausen
2023-03-13 17:36     ` Lars-Peter Clausen
2023-03-13 17:02 ` [PATCH 3/5] dmaengine: plx_dma: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 4/5] dmaengine: hidma: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-13 17:02 ` [PATCH 5/5] dmaengine: sprd: " Jisheng Zhang
2023-03-13 17:02   ` Jisheng Zhang
2023-03-14  3:51   ` Baolin Wang
2023-03-14  3:51     ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBSlvrDmKGjwWBa7@matsya \
    --to=vkoul@kernel.org \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=jszhang@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=okaya@kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.