* [PATCH] perf build: Add warning for when vmlinux.h generation fails
@ 2023-03-22 18:31 Ian Rogers
2023-03-22 19:50 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2023-03-22 18:31 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Adrian Hunter, linux-perf-users, linux-kernel, Stephen Rothwell
Cc: Ian Rogers
The warning advises on the NO_BPF_SKEL=1 option.
Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/Makefile.perf | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index ed6b6a070f79..48aba186ceb5 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -1072,7 +1072,11 @@ VMLINUX_BTF ?= $(abspath $(firstword $(wildcard $(VMLINUX_BTF_PATHS))))
$(SKEL_OUT)/vmlinux.h: $(VMLINUX_BTF) $(BPFTOOL)
ifeq ($(VMLINUX_H),)
- $(QUIET_GEN)$(BPFTOOL) btf dump file $< format c > $@
+ $(QUIET_GEN)$(BPFTOOL) btf dump file $< format c > $@ || \
+ (echo "Failure to generate vmlinux.h needed for the recommended BPF skeleton support." && \
+ echo "To disable this use the build option NO_BPF_SKEL=1." && \
+ echo "Alternatively point at a pre-generated vmlinux.h with VMLINUX_H=<path>." && \
+ false)
else
$(Q)cp "$(VMLINUX_H)" $@
endif
--
2.40.0.rc1.284.g88254d51c5-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf build: Add warning for when vmlinux.h generation fails
2023-03-22 18:31 [PATCH] perf build: Add warning for when vmlinux.h generation fails Ian Rogers
@ 2023-03-22 19:50 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-03-22 19:50 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Adrian Hunter, linux-perf-users,
linux-kernel, Stephen Rothwell
Em Wed, Mar 22, 2023 at 11:31:08AM -0700, Ian Rogers escreveu:
> The warning advises on the NO_BPF_SKEL=1 option.
Looks ok, applying.
- Arnaldo
> Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/Makefile.perf | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index ed6b6a070f79..48aba186ceb5 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -1072,7 +1072,11 @@ VMLINUX_BTF ?= $(abspath $(firstword $(wildcard $(VMLINUX_BTF_PATHS))))
>
> $(SKEL_OUT)/vmlinux.h: $(VMLINUX_BTF) $(BPFTOOL)
> ifeq ($(VMLINUX_H),)
> - $(QUIET_GEN)$(BPFTOOL) btf dump file $< format c > $@
> + $(QUIET_GEN)$(BPFTOOL) btf dump file $< format c > $@ || \
> + (echo "Failure to generate vmlinux.h needed for the recommended BPF skeleton support." && \
> + echo "To disable this use the build option NO_BPF_SKEL=1." && \
> + echo "Alternatively point at a pre-generated vmlinux.h with VMLINUX_H=<path>." && \
> + false)
> else
> $(Q)cp "$(VMLINUX_H)" $@
> endif
> --
> 2.40.0.rc1.284.g88254d51c5-goog
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-22 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-22 18:31 [PATCH] perf build: Add warning for when vmlinux.h generation fails Ian Rogers
2023-03-22 19:50 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.