From: Sabrina Dubroca <sd@queasysnail.net>
To: Emeel Hakim <ehakim@nvidia.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org, leon@kernel.org
Subject: Re: [PATCH net-next v3 1/4] vlan: Add MACsec offload operations for VLAN interface
Date: Wed, 5 Apr 2023 11:37:48 +0200 [thread overview]
Message-ID: <ZC1BbKhzYTjGQuzz@hog> (raw)
In-Reply-To: <20230330135715.23652-2-ehakim@nvidia.com>
2023-03-30, 16:57:12 +0300, Emeel Hakim wrote:
> +static int vlan_macsec_del_secy(struct macsec_context *ctx)
> +{
> + const struct macsec_ops *ops = vlan_get_macsec_ops(ctx);
> +
> + if (!ops || !ops->mdo_del_secy)
> + return -EOPNOTSUPP;
> +
> + return ops->mdo_del_secy(ctx);
> +}
> +
> +#undef _BUILD_VLAN_MACSEC_MDO
FWIW, I didn't have a problem with this particular macro, only
VLAN_MACSEC_DECLARE_MDO. But if you're going to remove
_BUILD_VLAN_MACSEC_MDO, you need to remove it completely.
--
Sabrina
next prev parent reply other threads:[~2023-04-05 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 13:57 [PATCH net-next v3 0/4] Support MACsec VLAN Emeel Hakim
2023-03-30 13:57 ` [PATCH net-next v3 1/4] vlan: Add MACsec offload operations for VLAN interface Emeel Hakim
2023-03-31 13:49 ` Simon Horman
2023-04-05 9:37 ` Sabrina Dubroca [this message]
2023-04-05 9:43 ` Emeel Hakim
[not found] ` <CA+sq2Cew_NiVcLBzxVF=C8htuNPSzHeEe48s6uD9smqKeUA9gQ@mail.gmail.com>
[not found] ` <CO1PR18MB46666401C2A9138BB6144BC8A1909@CO1PR18MB4666.namprd18.prod.outlook.com>
2023-04-05 13:47 ` [EXT] Fwd: " Subbaraya Sundeep Bhatta
2023-04-07 9:04 ` Emeel Hakim
2023-03-30 13:57 ` [PATCH net-next v3 2/4] net/mlx5: Support MACsec over VLAN Emeel Hakim
2023-03-31 13:48 ` Simon Horman
2023-03-30 13:57 ` [PATCH net-next v3 3/4] net/mlx5: Consider VLAN interface in MACsec TX steering rules Emeel Hakim
2023-03-31 13:49 ` Simon Horman
2023-03-30 13:57 ` [PATCH net-next v3 4/4] macsec: Add MACsec rx_handler change support Emeel Hakim
2023-03-31 13:50 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC1BbKhzYTjGQuzz@hog \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ehakim@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.