From: Simon Horman <simon.horman@corigine.com>
To: Emeel Hakim <ehakim@nvidia.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, sd@queasysnail.net, netdev@vger.kernel.org,
leon@kernel.org
Subject: Re: [PATCH net-next v3 3/4] net/mlx5: Consider VLAN interface in MACsec TX steering rules
Date: Fri, 31 Mar 2023 15:49:47 +0200 [thread overview]
Message-ID: <ZCbk+2oblodtwSQc@corigine.com> (raw)
In-Reply-To: <20230330135715.23652-4-ehakim@nvidia.com>
On Thu, Mar 30, 2023 at 04:57:14PM +0300, Emeel Hakim wrote:
> Offloading MACsec when its configured over VLAN with current MACsec
> TX steering rules will wrongly insert MACsec sec tag after inserting
> the VLAN header leading to a ETHERNET | SECTAG | VLAN packet when
> ETHERNET | VLAN | SECTAG is configured.
>
> The above issue is due to adding the SECTAG by HW which is a later
> stage compared to the VLAN header insertion stage.
>
> Detect such a case and adjust TX steering rules to insert the
> SECTAG in the correct place by using reformat_param_0 field in
> the packet reformat to indicate the offset of SECTAG from end of
> the MAC header to account for VLANs in granularity of 4Bytes.
>
> Signed-off-by: Emeel Hakim <ehakim@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-31 13:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 13:57 [PATCH net-next v3 0/4] Support MACsec VLAN Emeel Hakim
2023-03-30 13:57 ` [PATCH net-next v3 1/4] vlan: Add MACsec offload operations for VLAN interface Emeel Hakim
2023-03-31 13:49 ` Simon Horman
2023-04-05 9:37 ` Sabrina Dubroca
2023-04-05 9:43 ` Emeel Hakim
[not found] ` <CA+sq2Cew_NiVcLBzxVF=C8htuNPSzHeEe48s6uD9smqKeUA9gQ@mail.gmail.com>
[not found] ` <CO1PR18MB46666401C2A9138BB6144BC8A1909@CO1PR18MB4666.namprd18.prod.outlook.com>
2023-04-05 13:47 ` [EXT] Fwd: " Subbaraya Sundeep Bhatta
2023-04-07 9:04 ` Emeel Hakim
2023-03-30 13:57 ` [PATCH net-next v3 2/4] net/mlx5: Support MACsec over VLAN Emeel Hakim
2023-03-31 13:48 ` Simon Horman
2023-03-30 13:57 ` [PATCH net-next v3 3/4] net/mlx5: Consider VLAN interface in MACsec TX steering rules Emeel Hakim
2023-03-31 13:49 ` Simon Horman [this message]
2023-03-30 13:57 ` [PATCH net-next v3 4/4] macsec: Add MACsec rx_handler change support Emeel Hakim
2023-03-31 13:50 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCbk+2oblodtwSQc@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ehakim@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.