All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Petr Vorel" <pvorel@suse.cz>,
	"Naresh Kamboju" <naresh.kamboju@linaro.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"LTP List" <ltp@lists.linux.it>,
	llvm@lists.linux.dev, "Nathan Chancellor" <nathan@kernel.org>,
	"Anders Roxell" <anders.roxell@linaro.org>,
	"Daniel Díaz" <daniel.diaz@linaro.org>,
	"Benjamin Copeland" <ben.copeland@linaro.org>,
	"Tudor Cretu" <tudor.cretu@arm.com>
Subject: Re: LTP: list of failures on 32bit and compat mode
Date: Thu, 6 Apr 2023 15:58:12 +0200	[thread overview]
Message-ID: <ZC7P9BgW1CTFAMjB@yuki> (raw)
In-Reply-To: <c2a6d31f-173b-4d08-b377-e31748f33443@app.fastmail.com>

Hi!
> > Thanks! I've just searched in musl as well, because it didn't make sense to me
> > it'd be a code for LTP.
> >
> > "to catch the fault on ltp" I wonder if it's not actually musl bug.
> 
> No, musl is fine here. The problem is that ltp passes an invalid pointer,
> expecting to get -EFAULT from the kernel when that faults in
> copy_to_user().
> 
> There is nothing wrong with musl sanitizing the data behind that
> pointer, but then you get a signal instead of the EFAULT error.

That's actually quite common, usually we fix that by running the test in
a child and treating SEGFAULT as a PASS.

-- 
Cyril Hrubis
chrubis@suse.cz

WARNING: multiple messages have this Message-ID (diff)
From: Cyril Hrubis <chrubis@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Benjamin Copeland <ben.copeland@linaro.org>,
	llvm@lists.linux.dev, open list <linux-kernel@vger.kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] LTP: list of failures on 32bit and compat mode
Date: Thu, 6 Apr 2023 15:58:12 +0200	[thread overview]
Message-ID: <ZC7P9BgW1CTFAMjB@yuki> (raw)
In-Reply-To: <c2a6d31f-173b-4d08-b377-e31748f33443@app.fastmail.com>

Hi!
> > Thanks! I've just searched in musl as well, because it didn't make sense to me
> > it'd be a code for LTP.
> >
> > "to catch the fault on ltp" I wonder if it's not actually musl bug.
> 
> No, musl is fine here. The problem is that ltp passes an invalid pointer,
> expecting to get -EFAULT from the kernel when that faults in
> copy_to_user().
> 
> There is nothing wrong with musl sanitizing the data behind that
> pointer, but then you get a signal instead of the EFAULT error.

That's actually quite common, usually we fix that by running the test in
a child and treating SEGFAULT as a PASS.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-04-06 13:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06  9:11 LTP: list of failures on 32bit and compat mode Naresh Kamboju
2023-04-06  9:11 ` [LTP] " Naresh Kamboju
2023-04-06  9:54 ` Arnd Bergmann
2023-04-06  9:54   ` [LTP] " Arnd Bergmann
2023-04-06 10:56   ` Petr Vorel
2023-04-06 10:56     ` [LTP] " Petr Vorel
2023-04-06 11:23     ` Arnd Bergmann
2023-04-06 11:23       ` [LTP] " Arnd Bergmann
2023-04-06 12:48       ` Petr Vorel
2023-04-06 12:48         ` [LTP] " Petr Vorel
2023-04-06 12:53         ` Arnd Bergmann
2023-04-06 12:53           ` [LTP] " Arnd Bergmann
2023-04-06 13:17           ` Petr Vorel
2023-04-06 13:17             ` [LTP] " Petr Vorel
2023-04-06 13:21             ` Arnd Bergmann
2023-04-06 13:21               ` [LTP] " Arnd Bergmann
2023-04-06 13:58               ` Cyril Hrubis [this message]
2023-04-06 13:58                 ` Cyril Hrubis
2023-04-11 16:45     ` Naresh Kamboju
2023-04-11 16:45       ` [LTP] " Naresh Kamboju
2023-04-11 17:37       ` Naresh Kamboju
2023-04-11 17:37         ` [LTP] " Naresh Kamboju
2023-04-11 22:08       ` Petr Vorel
2023-04-11 22:08         ` [LTP] " Petr Vorel
2023-04-12  5:22         ` Daniel Díaz
2023-04-12  5:22           ` [LTP] " Daniel Díaz
2023-04-12  7:14           ` Petr Vorel
2023-04-12  7:14             ` [LTP] " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZC7P9BgW1CTFAMjB@yuki \
    --to=chrubis@suse.cz \
    --cc=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=ben.copeland@linaro.org \
    --cc=daniel.diaz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=ltp@lists.linux.it \
    --cc=naresh.kamboju@linaro.org \
    --cc=nathan@kernel.org \
    --cc=pvorel@suse.cz \
    --cc=tudor.cretu@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.