From: Jianhua Lu <lujianhua000@gmail.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH] Asoc: wm_adsp: Add support for loading firmware with prefix name
Date: Wed, 29 Mar 2023 23:43:10 +0800 [thread overview]
Message-ID: <ZCRcjgMWhV0dp8p0@Gentoo> (raw)
In-Reply-To: <57c5a3b3-00cd-5b44-02f4-dedabacc7662@opensource.cirrus.com>
On Wed, Mar 29, 2023 at 04:33:08PM +0100, Richard Fitzgerald wrote:
> On 29/3/23 14:05, Jianhua Lu wrote:
> > For platform using fdt, system_name is NULL, it doesn't provide
> > a way to load firmware with prefix name, so add it.
>
> This is intended behavior.
>
> To load per-amp tuning you must know the function of each amp.
> You only know that if you know what hardware platform you are running
> on.
>
> So if system_name is NULL it should fall back to generic firmware.
Make sense
WARNING: multiple messages have this Message-ID (diff)
From: Jianhua Lu <lujianhua000@gmail.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH] Asoc: wm_adsp: Add support for loading firmware with prefix name
Date: Wed, 29 Mar 2023 23:43:10 +0800 [thread overview]
Message-ID: <ZCRcjgMWhV0dp8p0@Gentoo> (raw)
In-Reply-To: <57c5a3b3-00cd-5b44-02f4-dedabacc7662@opensource.cirrus.com>
On Wed, Mar 29, 2023 at 04:33:08PM +0100, Richard Fitzgerald wrote:
> On 29/3/23 14:05, Jianhua Lu wrote:
> > For platform using fdt, system_name is NULL, it doesn't provide
> > a way to load firmware with prefix name, so add it.
>
> This is intended behavior.
>
> To load per-amp tuning you must know the function of each amp.
> You only know that if you know what hardware platform you are running
> on.
>
> So if system_name is NULL it should fall back to generic firmware.
Make sense
next prev parent reply other threads:[~2023-03-29 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 13:05 [PATCH] Asoc: wm_adsp: Add support for loading firmware with prefix name Jianhua Lu
2023-03-29 14:05 ` Charles Keepax
2023-03-29 14:37 ` Jianhua Lu
2023-03-29 14:37 ` Jianhua Lu
2023-03-29 15:38 ` Richard Fitzgerald
2023-03-29 15:49 ` Jianhua Lu
2023-03-29 15:49 ` Jianhua Lu
2023-03-29 15:38 ` Richard Fitzgerald via Alsa-devel
2023-03-29 14:05 ` Charles Keepax via Alsa-devel
2023-03-29 15:33 ` Richard Fitzgerald via Alsa-devel
2023-03-29 15:33 ` Richard Fitzgerald
2023-03-29 15:43 ` Jianhua Lu [this message]
2023-03-29 15:43 ` Jianhua Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCRcjgMWhV0dp8p0@Gentoo \
--to=lujianhua000@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=phone-devel@vger.kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.