All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joel Camilo Chang Gonzalez <jcchangg3@gmail.com>
Cc: driverdev-devel@linuxdriverproject.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: ks7010: remove unnecesary parentheses
Date: Thu, 30 Mar 2023 14:49:54 +0200	[thread overview]
Message-ID: <ZCWFcosyX0PllKLI@kroah.com> (raw)
In-Reply-To: <ZCWEM7DCDUEOzBe9@joel-ubuntu-desktop>

On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote:
> Remove parentheses not needed in if statement
> 
> Signed-off-by: Joel Camilo Chang Gonzalez <jcchangg3@gmail.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index af3825578d85..8bded7e88ce7 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
>  	size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
>  		ap_info->rsn.size : RSN_IE_BODY_MAX;
>  	if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
> -	    (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
> +	    priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {

If you look in the archives, you will see that I reject this type of
patch all the time.

Also, please use scripts/get_maintainer.pl to determine who to send this
to, you used a very old mailing list address that is long dead.

thanks,

greg k-h

  reply	other threads:[~2023-03-30 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 12:44 [PATCH] staging: ks7010: remove unnecesary parentheses Joel Camilo Chang Gonzalez
2023-03-30 12:49 ` Greg KH [this message]
2023-03-30 17:04   ` Joel C. Chang
2023-03-30 20:53     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2023-03-30 12:09 Joel Camilo Chang Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCWFcosyX0PllKLI@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=jcchangg3@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.