* [PATCH] staging: ks7010: remove unnecesary parentheses
@ 2023-03-30 12:44 Joel Camilo Chang Gonzalez
2023-03-30 12:49 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Joel Camilo Chang Gonzalez @ 2023-03-30 12:44 UTC (permalink / raw)
To: driverdev-devel, linux-staging, gregkh
Remove parentheses not needed in if statement
Signed-off-by: Joel Camilo Chang Gonzalez <jcchangg3@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index af3825578d85..8bded7e88ce7 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
ap_info->rsn.size : RSN_IE_BODY_MAX;
if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
- (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
+ priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {
ap->rsn_ie.id = RSN_INFO_ELEM_ID;
ap->rsn_ie.size = size;
memcpy(ap->rsn_ie.body, ap_info->rsn.body, size);
--
2.37.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: ks7010: remove unnecesary parentheses
2023-03-30 12:44 [PATCH] staging: ks7010: remove unnecesary parentheses Joel Camilo Chang Gonzalez
@ 2023-03-30 12:49 ` Greg KH
2023-03-30 17:04 ` Joel C. Chang
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2023-03-30 12:49 UTC (permalink / raw)
To: Joel Camilo Chang Gonzalez; +Cc: driverdev-devel, linux-staging
On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote:
> Remove parentheses not needed in if statement
>
> Signed-off-by: Joel Camilo Chang Gonzalez <jcchangg3@gmail.com>
> ---
> drivers/staging/ks7010/ks_hostif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index af3825578d85..8bded7e88ce7 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
> size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
> ap_info->rsn.size : RSN_IE_BODY_MAX;
> if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
> - (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
> + priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {
If you look in the archives, you will see that I reject this type of
patch all the time.
Also, please use scripts/get_maintainer.pl to determine who to send this
to, you used a very old mailing list address that is long dead.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: ks7010: remove unnecesary parentheses
2023-03-30 12:49 ` Greg KH
@ 2023-03-30 17:04 ` Joel C. Chang
2023-03-30 20:53 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Joel C. Chang @ 2023-03-30 17:04 UTC (permalink / raw)
To: Greg KH; +Cc: driverdev-devel, linux-staging
On Thu, Mar 30, 2023 at 02:49:54PM +0200, Greg KH wrote:
> On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote:
> > Remove parentheses not needed in if statement
> >
> > Signed-off-by: Joel Camilo Chang Gonzalez <jcchangg3@gmail.com>
> > ---
> > drivers/staging/ks7010/ks_hostif.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> > index af3825578d85..8bded7e88ce7 100644
> > --- a/drivers/staging/ks7010/ks_hostif.c
> > +++ b/drivers/staging/ks7010/ks_hostif.c
> > @@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
> > size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
> > ap_info->rsn.size : RSN_IE_BODY_MAX;
> > if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
> > - (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
> > + priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {
>
> If you look in the archives, you will see that I reject this type of
> patch all the time.
>
> Also, please use scripts/get_maintainer.pl to determine who to send this
> to, you used a very old mailing list address that is long dead.
>
> thanks,
>
> greg k-h
Thanks for the input. I wasn't sure who to send it to, since the TODO in
the driver and the script have different email addresses.
Is there a place to check for inactive mailing lists?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] staging: ks7010: remove unnecesary parentheses
2023-03-30 17:04 ` Joel C. Chang
@ 2023-03-30 20:53 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2023-03-30 20:53 UTC (permalink / raw)
To: Joel C. Chang; +Cc: linux-staging, driverdev-devel
On Fri, Mar 31, 2023 at 01:04:59AM +0800, Joel C. Chang wrote:
> On Thu, Mar 30, 2023 at 02:49:54PM +0200, Greg KH wrote:
> > On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote:
> > > Remove parentheses not needed in if statement
> > >
> > > Signed-off-by: Joel Camilo Chang Gonzalez <jcchangg3@gmail.com>
> > > ---
> > > drivers/staging/ks7010/ks_hostif.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> > > index af3825578d85..8bded7e88ce7 100644
> > > --- a/drivers/staging/ks7010/ks_hostif.c
> > > +++ b/drivers/staging/ks7010/ks_hostif.c
> > > @@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
> > > size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
> > > ap_info->rsn.size : RSN_IE_BODY_MAX;
> > > if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
> > > - (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
> > > + priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {
> >
> > If you look in the archives, you will see that I reject this type of
> > patch all the time.
> >
> > Also, please use scripts/get_maintainer.pl to determine who to send this
> > to, you used a very old mailing list address that is long dead.
> >
> > thanks,
> >
> > greg k-h
>
> Thanks for the input. I wasn't sure who to send it to, since the TODO in
> the driver and the script have different email addresses.
>
> Is there a place to check for inactive mailing lists?
Just trust the get_maintainer.pl script, it knows what to do.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: ks7010: remove unnecesary parentheses
@ 2023-03-30 12:09 Joel Camilo Chang Gonzalez
0 siblings, 0 replies; 5+ messages in thread
From: Joel Camilo Chang Gonzalez @ 2023-03-30 12:09 UTC (permalink / raw)
To: linux-staging
Remove parentheses not needed in if statement
Signed-off-by: Joel Camilo Chang Gonzalez <jcchangg3@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index af3825578d85..8bded7e88ce7 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
ap_info->rsn.size : RSN_IE_BODY_MAX;
if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
- (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
+ priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {
ap->rsn_ie.id = RSN_INFO_ELEM_ID;
ap->rsn_ie.size = size;
memcpy(ap->rsn_ie.body, ap_info->rsn.body, size);
--
2.37.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-30 20:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-30 12:44 [PATCH] staging: ks7010: remove unnecesary parentheses Joel Camilo Chang Gonzalez
2023-03-30 12:49 ` Greg KH
2023-03-30 17:04 ` Joel C. Chang
2023-03-30 20:53 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2023-03-30 12:09 Joel Camilo Chang Gonzalez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.