All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@linaro.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init
Date: Fri, 31 Mar 2023 22:58:34 +0300	[thread overview]
Message-ID: <ZCc7agfv1Kvkh04l@linaro.org> (raw)
In-Reply-To: <ZCbXC6A4lgxc4wO4@linaro.org>

On 23-03-31 15:50:19, Abel Vesa wrote:
> On 23-03-21 14:53:24, Alexander Stein wrote:
> > Make sure to keep UART clocks enabled during kernel init if
> > earlyprintk or earlycon are active.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Applied, thanks!
> 
> [1/1] clk: imx6ul: retain early UART clocks during kernel init
>       commit: edc6476d334adaeedf899c70e61264305155fd70
> 
> Best regards,
> --
> Abel Vesa <abel.vesa@linaro.org>


Actually dropped, because of this:
https://lore.kernel.org/all/202304010336.L6H9SxmK-lkp@intel.com/

Rebase and resend if needed, please.

> 
> > ---
> > Apparently i.MX6UL was missed in commit 0822f933735c ("clk: imx6: retain
> > early UART clocks during kernel init"). But as commit 379c9a24cc23 ("clk:
> > imx: Fix reparenting of UARTs not associated with stdout") changes the
> > calling signature it's not warranting a Fixes for the old commit.
> > 
> >  drivers/clk/imx/clk-imx6ul.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> > index 206e4c43f68f..26578e407d3e 100644
> > --- a/drivers/clk/imx/clk-imx6ul.c
> > +++ b/drivers/clk/imx/clk-imx6ul.c
> > @@ -510,6 +510,8 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
> >  		clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk);
> >  
> >  	clk_set_parent(hws[IMX6UL_CLK_ENFC_SEL]->clk, hws[IMX6UL_CLK_PLL2_PFD2]->clk);
> > +
> > +	imx_register_uart_clocks(2);
> >  }
> >  
> >  CLK_OF_DECLARE(imx6ul, "fsl,imx6ul-ccm", imx6ul_clocks_init);
> > -- 
> > 2.34.1
> > 

WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@linaro.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init
Date: Fri, 31 Mar 2023 22:58:34 +0300	[thread overview]
Message-ID: <ZCc7agfv1Kvkh04l@linaro.org> (raw)
In-Reply-To: <ZCbXC6A4lgxc4wO4@linaro.org>

On 23-03-31 15:50:19, Abel Vesa wrote:
> On 23-03-21 14:53:24, Alexander Stein wrote:
> > Make sure to keep UART clocks enabled during kernel init if
> > earlyprintk or earlycon are active.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> Applied, thanks!
> 
> [1/1] clk: imx6ul: retain early UART clocks during kernel init
>       commit: edc6476d334adaeedf899c70e61264305155fd70
> 
> Best regards,
> --
> Abel Vesa <abel.vesa@linaro.org>


Actually dropped, because of this:
https://lore.kernel.org/all/202304010336.L6H9SxmK-lkp@intel.com/

Rebase and resend if needed, please.

> 
> > ---
> > Apparently i.MX6UL was missed in commit 0822f933735c ("clk: imx6: retain
> > early UART clocks during kernel init"). But as commit 379c9a24cc23 ("clk:
> > imx: Fix reparenting of UARTs not associated with stdout") changes the
> > calling signature it's not warranting a Fixes for the old commit.
> > 
> >  drivers/clk/imx/clk-imx6ul.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> > index 206e4c43f68f..26578e407d3e 100644
> > --- a/drivers/clk/imx/clk-imx6ul.c
> > +++ b/drivers/clk/imx/clk-imx6ul.c
> > @@ -510,6 +510,8 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
> >  		clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk);
> >  
> >  	clk_set_parent(hws[IMX6UL_CLK_ENFC_SEL]->clk, hws[IMX6UL_CLK_PLL2_PFD2]->clk);
> > +
> > +	imx_register_uart_clocks(2);
> >  }
> >  
> >  CLK_OF_DECLARE(imx6ul, "fsl,imx6ul-ccm", imx6ul_clocks_init);
> > -- 
> > 2.34.1
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-31 19:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 13:53 [PATCH 1/1] clk: imx6ul: retain early UART clocks during kernel init Alexander Stein
2023-03-21 13:53 ` Alexander Stein
2023-03-31 12:50 ` Abel Vesa
2023-03-31 12:50   ` Abel Vesa
2023-03-31 19:58   ` Abel Vesa [this message]
2023-03-31 19:58     ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCc7agfv1Kvkh04l@linaro.org \
    --to=abel.vesa@linaro.org \
    --cc=abelvesa@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=mturquette@baylibre.com \
    --cc=peng.fan@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.