From: Simon Horman <simon.horman@corigine.com>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net-next 2/4] ice: remove redundant Rx field from rule info
Date: Sat, 1 Apr 2023 11:03:26 +0200 [thread overview]
Message-ID: <ZCfzXuoLHxoxqa/C@corigine.com> (raw)
In-Reply-To: <20230331105747.89612-3-michal.swiatkowski@linux.intel.com>
On Fri, Mar 31, 2023 at 12:57:45PM +0200, Michal Swiatkowski wrote:
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
>
> Setting direction flag doesn't mean that there is a match criteria for
> direction in rule. It is only a information for HW from where switch id
> should be collected (VSI or port). In current implementation of advance
> rule handling, without matching for direction metadata, we can always
> set one the same flag and everything will work the same.
>
> Ability to match on direction matadata will be added in follow up
> patches.
nit: checkpatch.pl --codespell tells me that 'matadata' is misspelt
>
> Recipe 0, 3 and 9 loaded from package has direction match
> criteria, but they are handled in other function.
>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
wojciech.drewek@intel.com, piotr.raczynski@intel.com
Subject: Re: [PATCH net-next 2/4] ice: remove redundant Rx field from rule info
Date: Sat, 1 Apr 2023 11:03:26 +0200 [thread overview]
Message-ID: <ZCfzXuoLHxoxqa/C@corigine.com> (raw)
In-Reply-To: <20230331105747.89612-3-michal.swiatkowski@linux.intel.com>
On Fri, Mar 31, 2023 at 12:57:45PM +0200, Michal Swiatkowski wrote:
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
>
> Setting direction flag doesn't mean that there is a match criteria for
> direction in rule. It is only a information for HW from where switch id
> should be collected (VSI or port). In current implementation of advance
> rule handling, without matching for direction metadata, we can always
> set one the same flag and everything will work the same.
>
> Ability to match on direction matadata will be added in follow up
> patches.
nit: checkpatch.pl --codespell tells me that 'matadata' is misspelt
>
> Recipe 0, 3 and 9 loaded from package has direction match
> criteria, but they are handled in other function.
>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-04-01 9:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 10:57 [Intel-wired-lan] [PATCH net-next 0/4] ice: allow matching on metadata Michal Swiatkowski
2023-03-31 10:57 ` Michal Swiatkowski
2023-03-31 10:57 ` [Intel-wired-lan] [PATCH net-next 1/4] ice: define metadata to match in switch Michal Swiatkowski
2023-03-31 10:57 ` Michal Swiatkowski
2023-04-01 9:02 ` [Intel-wired-lan] " Simon Horman
2023-04-01 9:02 ` Simon Horman
2023-03-31 10:57 ` [Intel-wired-lan] [PATCH net-next 2/4] ice: remove redundant Rx field from rule info Michal Swiatkowski
2023-03-31 10:57 ` Michal Swiatkowski
2023-04-01 9:03 ` Simon Horman [this message]
2023-04-01 9:03 ` Simon Horman
2023-03-31 10:57 ` [Intel-wired-lan] [PATCH net-next 3/4] ice: allow matching on metadata Michal Swiatkowski
2023-03-31 10:57 ` Michal Swiatkowski
2023-04-01 9:04 ` [Intel-wired-lan] " Simon Horman
2023-04-01 9:04 ` Simon Horman
2023-03-31 10:57 ` [Intel-wired-lan] [PATCH net-next 4/4] ice: use src VSI instead of src MAC in slow-path Michal Swiatkowski
2023-03-31 10:57 ` Michal Swiatkowski
2023-04-01 9:04 ` [Intel-wired-lan] " Simon Horman
2023-04-01 9:04 ` Simon Horman
2023-04-03 6:01 ` [Intel-wired-lan] " Michal Swiatkowski
2023-04-03 6:01 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCfzXuoLHxoxqa/C@corigine.com \
--to=simon.horman@corigine.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.