From: Abel Vesa <abel.vesa@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: mturquette@baylibre.com, sboyd@kernel.org, abelvesa@kernel.org,
peng.fan@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
heiko@sntech.de, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 2/4] clk: imx: Remove values for mmask and nmask in struct clk_fractional_divider
Date: Mon, 3 Apr 2023 23:39:11 +0300 [thread overview]
Message-ID: <ZCs5bwy63l8E91AM@linaro.org> (raw)
In-Reply-To: <187a2266c3a034a593a151d6e5e6b21118043b5d.1680423909.git.christophe.jaillet@wanadoo.fr>
On 23-04-02 11:42:05, Christophe JAILLET wrote:
> Now that fractional_divider clk computes mmask and nmask when needed, there
> is no more need to provide them explicitly anymore.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/clk/imx/clk-composite-7ulp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
> index 4eedd45dbaa8..e208ddc51133 100644
> --- a/drivers/clk/imx/clk-composite-7ulp.c
> +++ b/drivers/clk/imx/clk-composite-7ulp.c
> @@ -19,10 +19,8 @@
> #define PCG_CGC_SHIFT 30
> #define PCG_FRAC_SHIFT 3
> #define PCG_FRAC_WIDTH 1
> -#define PCG_FRAC_MASK BIT(3)
> #define PCG_PCD_SHIFT 0
> #define PCG_PCD_WIDTH 3
> -#define PCG_PCD_MASK 0x7
>
> #define SW_RST BIT(28)
>
> @@ -102,10 +100,8 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
> fd->reg = reg;
> fd->mshift = PCG_FRAC_SHIFT;
> fd->mwidth = PCG_FRAC_WIDTH;
> - fd->mmask = PCG_FRAC_MASK;
> fd->nshift = PCG_PCD_SHIFT;
> fd->nwidth = PCG_PCD_WIDTH;
> - fd->nmask = PCG_PCD_MASK;
> fd->flags = CLK_FRAC_DIVIDER_ZERO_BASED;
> if (has_swrst)
> fd->lock = &imx_ccm_lock;
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: mturquette@baylibre.com, sboyd@kernel.org, abelvesa@kernel.org,
peng.fan@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
heiko@sntech.de, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 2/4] clk: imx: Remove values for mmask and nmask in struct clk_fractional_divider
Date: Mon, 3 Apr 2023 23:39:11 +0300 [thread overview]
Message-ID: <ZCs5bwy63l8E91AM@linaro.org> (raw)
In-Reply-To: <187a2266c3a034a593a151d6e5e6b21118043b5d.1680423909.git.christophe.jaillet@wanadoo.fr>
On 23-04-02 11:42:05, Christophe JAILLET wrote:
> Now that fractional_divider clk computes mmask and nmask when needed, there
> is no more need to provide them explicitly anymore.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/clk/imx/clk-composite-7ulp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
> index 4eedd45dbaa8..e208ddc51133 100644
> --- a/drivers/clk/imx/clk-composite-7ulp.c
> +++ b/drivers/clk/imx/clk-composite-7ulp.c
> @@ -19,10 +19,8 @@
> #define PCG_CGC_SHIFT 30
> #define PCG_FRAC_SHIFT 3
> #define PCG_FRAC_WIDTH 1
> -#define PCG_FRAC_MASK BIT(3)
> #define PCG_PCD_SHIFT 0
> #define PCG_PCD_WIDTH 3
> -#define PCG_PCD_MASK 0x7
>
> #define SW_RST BIT(28)
>
> @@ -102,10 +100,8 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
> fd->reg = reg;
> fd->mshift = PCG_FRAC_SHIFT;
> fd->mwidth = PCG_FRAC_WIDTH;
> - fd->mmask = PCG_FRAC_MASK;
> fd->nshift = PCG_PCD_SHIFT;
> fd->nwidth = PCG_PCD_WIDTH;
> - fd->nmask = PCG_PCD_MASK;
> fd->flags = CLK_FRAC_DIVIDER_ZERO_BASED;
> if (has_swrst)
> fd->lock = &imx_ccm_lock;
> --
> 2.34.1
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: mturquette@baylibre.com, sboyd@kernel.org, abelvesa@kernel.org,
peng.fan@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
heiko@sntech.de, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 2/4] clk: imx: Remove values for mmask and nmask in struct clk_fractional_divider
Date: Mon, 3 Apr 2023 23:39:11 +0300 [thread overview]
Message-ID: <ZCs5bwy63l8E91AM@linaro.org> (raw)
In-Reply-To: <187a2266c3a034a593a151d6e5e6b21118043b5d.1680423909.git.christophe.jaillet@wanadoo.fr>
On 23-04-02 11:42:05, Christophe JAILLET wrote:
> Now that fractional_divider clk computes mmask and nmask when needed, there
> is no more need to provide them explicitly anymore.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/clk/imx/clk-composite-7ulp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
> index 4eedd45dbaa8..e208ddc51133 100644
> --- a/drivers/clk/imx/clk-composite-7ulp.c
> +++ b/drivers/clk/imx/clk-composite-7ulp.c
> @@ -19,10 +19,8 @@
> #define PCG_CGC_SHIFT 30
> #define PCG_FRAC_SHIFT 3
> #define PCG_FRAC_WIDTH 1
> -#define PCG_FRAC_MASK BIT(3)
> #define PCG_PCD_SHIFT 0
> #define PCG_PCD_WIDTH 3
> -#define PCG_PCD_MASK 0x7
>
> #define SW_RST BIT(28)
>
> @@ -102,10 +100,8 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
> fd->reg = reg;
> fd->mshift = PCG_FRAC_SHIFT;
> fd->mwidth = PCG_FRAC_WIDTH;
> - fd->mmask = PCG_FRAC_MASK;
> fd->nshift = PCG_PCD_SHIFT;
> fd->nwidth = PCG_PCD_WIDTH;
> - fd->nmask = PCG_PCD_MASK;
> fd->flags = CLK_FRAC_DIVIDER_ZERO_BASED;
> if (has_swrst)
> fd->lock = &imx_ccm_lock;
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-03 20:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 9:42 [PATCH v2 0/4] clk: shrink struct clk_fractional_divider Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 9:42 ` [PATCH v2 1/4] clk: Compute masks for fractional_divider clk when needed Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 14:28 ` Heiko Stübner
2023-04-02 14:28 ` Heiko Stübner
2023-04-02 14:28 ` Heiko Stübner
2023-04-02 14:29 ` Heiko Stübner
2023-04-02 14:29 ` Heiko Stübner
2023-04-02 14:29 ` Heiko Stübner
2023-04-05 19:13 ` Stephen Boyd
2023-04-05 19:13 ` Stephen Boyd
2023-04-05 19:13 ` Stephen Boyd
2023-04-02 9:42 ` [PATCH v2 2/4] clk: imx: Remove values for mmask and nmask in struct clk_fractional_divider Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-03 20:39 ` Abel Vesa [this message]
2023-04-03 20:39 ` Abel Vesa
2023-04-03 20:39 ` Abel Vesa
2023-04-05 19:12 ` Stephen Boyd
2023-04-05 19:12 ` Stephen Boyd
2023-04-05 19:12 ` Stephen Boyd
2023-04-02 9:42 ` [PATCH v2 3/4] clk: rockchip: " Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 14:35 ` Heiko Stübner
2023-04-02 14:35 ` Heiko Stübner
2023-04-02 14:35 ` Heiko Stübner
2023-04-05 19:12 ` Stephen Boyd
2023-04-05 19:12 ` Stephen Boyd
2023-04-05 19:12 ` Stephen Boyd
2023-04-02 9:42 ` [PATCH v2 4/4] clk: Remove mmask and nmask fields " Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 9:42 ` Christophe JAILLET
2023-04-02 20:19 ` Heiko Stübner
2023-04-02 20:19 ` Heiko Stübner
2023-04-02 20:19 ` Heiko Stübner
2023-04-05 19:12 ` Stephen Boyd
2023-04-05 19:12 ` Stephen Boyd
2023-04-05 19:12 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCs5bwy63l8E91AM@linaro.org \
--to=abel.vesa@linaro.org \
--cc=abelvesa@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.