All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] libsdl2-compat: use nonarch_libdir
@ 2025-05-21 15:15 Markus Volk
  2025-05-22 14:30 ` [oe] " Khem Raj
  0 siblings, 1 reply; 4+ messages in thread
From: Markus Volk @ 2025-05-21 15:15 UTC (permalink / raw)
  To: openembedded-devel

Use nonarch_libdir for do_install:append

This should prevent a possible multilib issue

Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
index 7e3a06f34f..1d46ebf511 100644
--- a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
+++ b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
@@ -23,7 +23,7 @@ inherit cmake pkgconfig upstream-version-is-even features_check
 REQUIRED_DISTRO_FEATURES = "opengl x11"
 
 do_install:append() {
-	mv ${D}${libdir}/pkgconfig/sdl2-compat.pc ${D}${libdir}/pkgconfig/sdl2.pc
+	mv ${D}${nonarch_libdir}/pkgconfig/sdl2-compat.pc ${D}${nonarch_libdir}/pkgconfig/sdl2.pc
 }
 
 FILES:${PN} += "${datadir}/licenses"
-- 
2.49.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [oe] [meta-oe][PATCH] libsdl2-compat: use nonarch_libdir
       [not found] <184193B941EEFFB8.22209@lists.openembedded.org>
@ 2025-05-21 15:24 ` Markus Volk
  0 siblings, 0 replies; 4+ messages in thread
From: Markus Volk @ 2025-05-21 15:24 UTC (permalink / raw)
  To: Khem Raj via lists.openembedded.org; +Cc: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

I forgot to mark this one RFC. I'm not quite sure about this.

On Wed, May 21 2025 at 17:15:44 +02:00:00, Markus Volk 
<f_l_k@t-online.de> wrote:
> Use nonarch_libdir for do_install:append
> 
> This should prevent a possible multilib issue
> 
> Signed-off-by: Markus Volk <f_l_k@t-online.de 
> <mailto:f_l_k@t-online.de>>
> ---
>  meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git 
> a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb 
> b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
> index 7e3a06f34f..1d46ebf511 100644
> --- a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
> +++ b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
> @@ -23,7 +23,7 @@ inherit cmake pkgconfig upstream-version-is-even 
> features_check
>  REQUIRED_DISTRO_FEATURES = "opengl x11"
> 
>  do_install:append() {
> -	mv ${D}${libdir}/pkgconfig/sdl2-compat.pc 
> ${D}${libdir}/pkgconfig/sdl2.pc
> +	mv ${D}${nonarch_libdir}/pkgconfig/sdl2-compat.pc 
> ${D}${nonarch_libdir}/pkgconfig/sdl2.pc
>  }
> 
>  FILES:${PN} += "${datadir}/licenses"
> --
> 2.49.0
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#117573): 
> <https://lists.openembedded.org/g/openembedded-devel/message/117573>
> Mute This Topic: <https://lists.openembedded.org/mt/113230803/3618223>
> Group Owner: openembedded-devel+owner@lists.openembedded.org 
> <mailto:openembedded-devel+owner@lists.openembedded.org>
> Unsubscribe: 
> <https://lists.openembedded.org/g/openembedded-devel/unsub> 
> [f_l_k@t-online.de <mailto:f_l_k@t-online.de>]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


[-- Attachment #2: Type: text/html, Size: 2136 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [oe] [meta-oe][PATCH] libsdl2-compat: use nonarch_libdir
  2025-05-21 15:15 [meta-oe][PATCH] libsdl2-compat: use nonarch_libdir Markus Volk
@ 2025-05-22 14:30 ` Khem Raj
  2025-05-22 21:29   ` Markus Volk
  0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2025-05-22 14:30 UTC (permalink / raw)
  To: f_l_k; +Cc: openembedded-devel

On Wed, May 21, 2025 at 8:15 AM Markus Volk via lists.openembedded.org
<f_l_k=t-online.de@lists.openembedded.org> wrote:
>
> Use nonarch_libdir for do_install:append
>
> This should prevent a possible multilib issue
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
> index 7e3a06f34f..1d46ebf511 100644
> --- a/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
> +++ b/meta-oe/recipes-graphics/libsdl3/libsdl2-compat_2.32.56.bb
> @@ -23,7 +23,7 @@ inherit cmake pkgconfig upstream-version-is-even features_check
>  REQUIRED_DISTRO_FEATURES = "opengl x11"
>
>  do_install:append() {
> -       mv ${D}${libdir}/pkgconfig/sdl2-compat.pc ${D}${libdir}/pkgconfig/sdl2.pc
> +       mv ${D}${nonarch_libdir}/pkgconfig/sdl2-compat.pc ${D}${nonarch_libdir}/pkgconfig/sdl2.pc
>  }


Can you check if sdl2.pc is identical in both multilib builds ?

>
>  FILES:${PN} += "${datadir}/licenses"
> --
> 2.49.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#117573): https://lists.openembedded.org/g/openembedded-devel/message/117573
> Mute This Topic: https://lists.openembedded.org/mt/113230803/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [oe] [meta-oe][PATCH] libsdl2-compat: use nonarch_libdir
  2025-05-22 14:30 ` [oe] " Khem Raj
@ 2025-05-22 21:29   ` Markus Volk
  0 siblings, 0 replies; 4+ messages in thread
From: Markus Volk @ 2025-05-22 21:29 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

On Thu, May 22 2025 at 07:30:27 -07:00:00, Khem Raj 
<raj.khem@gmail.com> wrote:
> Can you check if sdl2.pc is identical in both multilib builds ?

Checked it. This patch seems pointless and can be ignored


[-- Attachment #2: Type: text/html, Size: 374 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-05-22 21:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-21 15:15 [meta-oe][PATCH] libsdl2-compat: use nonarch_libdir Markus Volk
2025-05-22 14:30 ` [oe] " Khem Raj
2025-05-22 21:29   ` Markus Volk
     [not found] <184193B941EEFFB8.22209@lists.openembedded.org>
2025-05-21 15:24 ` Markus Volk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.