From: Ido Schimmel <idosch@nvidia.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Ivan Vecera <ivecera@redhat.com>,
bridge@lists.linux-foundation.org, Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
Roopa Prabhu <roopa@nvidia.com>,
Arkadi Sharshevsky <arkadis@mellanox.com>,
linux-kernel@vger.kernel.org, Ido Schimmel <idosch@mellanox.com>,
Eric Dumazet <edumazet@google.com>,
"Hans J. Schultz" <netdev@kapio-technology.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic"
Date: Wed, 12 Apr 2023 19:49:17 +0300 [thread overview]
Message-ID: <ZDbhDUDs0RUWVZ4B@shredder> (raw)
In-Reply-To: <20230412162407.xk3okeiedylv6sqp@skbuf>
On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote:
> I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being
> notified from switchdev.
>
> Unless you have any objection, I won't send v2 like this:
>
> if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> return;
>
> but like this:
>
> /* Entries with just the BR_FDB_ADDED_BY_USER flag set were created
> * using 'bridge fdb add ... master dynamic'
> */
> if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER))
> return;
LGTM. Please copy me on v2 and I will run it through regression. Will
try to report results before tomorrow's PR.
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@nvidia.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Hans J. Schultz" <netdev@kapio-technology.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ivan Vecera <ivecera@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Arkadi Sharshevsky <arkadis@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic"
Date: Wed, 12 Apr 2023 19:49:17 +0300 [thread overview]
Message-ID: <ZDbhDUDs0RUWVZ4B@shredder> (raw)
In-Reply-To: <20230412162407.xk3okeiedylv6sqp@skbuf>
On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote:
> I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being
> notified from switchdev.
>
> Unless you have any objection, I won't send v2 like this:
>
> if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> return;
>
> but like this:
>
> /* Entries with just the BR_FDB_ADDED_BY_USER flag set were created
> * using 'bridge fdb add ... master dynamic'
> */
> if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER))
> return;
LGTM. Please copy me on v2 and I will run it through regression. Will
try to report results before tomorrow's PR.
Thanks!
next prev parent reply other threads:[~2023-04-12 16:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 20:49 [Bridge] [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic" Vladimir Oltean
2023-04-10 20:49 ` Vladimir Oltean
2023-04-11 15:30 ` [Bridge] " Jesse Brandeburg
2023-04-11 15:30 ` Jesse Brandeburg
2023-04-12 14:15 ` [Bridge] " Ido Schimmel
2023-04-12 14:15 ` Ido Schimmel
2023-04-12 14:27 ` [Bridge] " Vladimir Oltean
2023-04-12 14:27 ` Vladimir Oltean
2023-04-12 16:00 ` [Bridge] " Ido Schimmel
2023-04-12 16:00 ` Ido Schimmel
2023-04-12 16:24 ` [Bridge] " Vladimir Oltean
2023-04-12 16:24 ` Vladimir Oltean
2023-04-12 16:49 ` Ido Schimmel [this message]
2023-04-12 16:49 ` Ido Schimmel
2023-04-12 17:04 ` [Bridge] " Vladimir Oltean
2023-04-12 17:04 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDbhDUDs0RUWVZ4B@shredder \
--to=idosch@nvidia.com \
--cc=arkadis@mellanox.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@mellanox.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@kapio-technology.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.