* [PATCH] iommu: Remove iommu_group_get_by_id()
@ 2023-04-12 14:11 Jason Gunthorpe
2023-04-12 14:39 ` Robin Murphy
2023-04-14 11:09 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2023-04-12 14:11 UTC (permalink / raw)
To: iommu, Joerg Roedel, Robin Murphy, Will Deacon
This is never called.
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/iommu/iommu.c | 29 -----------------------------
include/linux/iommu.h | 6 ------
2 files changed, 35 deletions(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 7abee83610b6c9..e0e7c90b490686 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -881,35 +881,6 @@ struct iommu_group *iommu_group_alloc(void)
}
EXPORT_SYMBOL_GPL(iommu_group_alloc);
-struct iommu_group *iommu_group_get_by_id(int id)
-{
- struct kobject *group_kobj;
- struct iommu_group *group;
- const char *name;
-
- if (!iommu_group_kset)
- return NULL;
-
- name = kasprintf(GFP_KERNEL, "%d", id);
- if (!name)
- return NULL;
-
- group_kobj = kset_find_obj(iommu_group_kset, name);
- kfree(name);
-
- if (!group_kobj)
- return NULL;
-
- group = container_of(group_kobj, struct iommu_group, kobj);
- BUG_ON(group->id != id);
-
- kobject_get(group->devices_kobj);
- kobject_put(&group->kobj);
-
- return group;
-}
-EXPORT_SYMBOL_GPL(iommu_group_get_by_id);
-
/**
* iommu_group_get_iommudata - retrieve iommu_data registered for a group
* @group: the group
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 54f535ff9868af..d9e8fc4512d6c5 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -460,7 +460,6 @@ extern bool iommu_present(struct bus_type *bus);
extern bool device_iommu_capable(struct device *dev, enum iommu_cap cap);
extern bool iommu_group_has_isolated_msi(struct iommu_group *group);
extern struct iommu_domain *iommu_domain_alloc(struct bus_type *bus);
-extern struct iommu_group *iommu_group_get_by_id(int id);
extern void iommu_domain_free(struct iommu_domain *domain);
extern int iommu_attach_device(struct iommu_domain *domain,
struct device *dev);
@@ -747,11 +746,6 @@ static inline struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
return NULL;
}
-static inline struct iommu_group *iommu_group_get_by_id(int id)
-{
- return NULL;
-}
-
static inline void iommu_domain_free(struct iommu_domain *domain)
{
}
base-commit: 43a31380ed6e16ad08675de5e68b5e4d05cf8716
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: Remove iommu_group_get_by_id()
2023-04-12 14:11 [PATCH] iommu: Remove iommu_group_get_by_id() Jason Gunthorpe
@ 2023-04-12 14:39 ` Robin Murphy
2023-04-14 11:09 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Robin Murphy @ 2023-04-12 14:39 UTC (permalink / raw)
To: Jason Gunthorpe, iommu, Joerg Roedel, Will Deacon
On 2023-04-12 15:11, Jason Gunthorpe wrote:
> This is never called.
Ah yes, I see VFIO stopped using it last year.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/iommu/iommu.c | 29 -----------------------------
> include/linux/iommu.h | 6 ------
> 2 files changed, 35 deletions(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 7abee83610b6c9..e0e7c90b490686 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -881,35 +881,6 @@ struct iommu_group *iommu_group_alloc(void)
> }
> EXPORT_SYMBOL_GPL(iommu_group_alloc);
>
> -struct iommu_group *iommu_group_get_by_id(int id)
> -{
> - struct kobject *group_kobj;
> - struct iommu_group *group;
> - const char *name;
> -
> - if (!iommu_group_kset)
> - return NULL;
> -
> - name = kasprintf(GFP_KERNEL, "%d", id);
> - if (!name)
> - return NULL;
> -
> - group_kobj = kset_find_obj(iommu_group_kset, name);
> - kfree(name);
> -
> - if (!group_kobj)
> - return NULL;
> -
> - group = container_of(group_kobj, struct iommu_group, kobj);
> - BUG_ON(group->id != id);
> -
> - kobject_get(group->devices_kobj);
> - kobject_put(&group->kobj);
> -
> - return group;
> -}
> -EXPORT_SYMBOL_GPL(iommu_group_get_by_id);
> -
> /**
> * iommu_group_get_iommudata - retrieve iommu_data registered for a group
> * @group: the group
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 54f535ff9868af..d9e8fc4512d6c5 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -460,7 +460,6 @@ extern bool iommu_present(struct bus_type *bus);
> extern bool device_iommu_capable(struct device *dev, enum iommu_cap cap);
> extern bool iommu_group_has_isolated_msi(struct iommu_group *group);
> extern struct iommu_domain *iommu_domain_alloc(struct bus_type *bus);
> -extern struct iommu_group *iommu_group_get_by_id(int id);
> extern void iommu_domain_free(struct iommu_domain *domain);
> extern int iommu_attach_device(struct iommu_domain *domain,
> struct device *dev);
> @@ -747,11 +746,6 @@ static inline struct iommu_domain *iommu_domain_alloc(struct bus_type *bus)
> return NULL;
> }
>
> -static inline struct iommu_group *iommu_group_get_by_id(int id)
> -{
> - return NULL;
> -}
> -
> static inline void iommu_domain_free(struct iommu_domain *domain)
> {
> }
>
> base-commit: 43a31380ed6e16ad08675de5e68b5e4d05cf8716
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu: Remove iommu_group_get_by_id()
2023-04-12 14:11 [PATCH] iommu: Remove iommu_group_get_by_id() Jason Gunthorpe
2023-04-12 14:39 ` Robin Murphy
@ 2023-04-14 11:09 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2023-04-14 11:09 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: iommu, Robin Murphy, Will Deacon
On Wed, Apr 12, 2023 at 11:11:58AM -0300, Jason Gunthorpe wrote:
> This is never called.
>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
> drivers/iommu/iommu.c | 29 -----------------------------
> include/linux/iommu.h | 6 ------
> 2 files changed, 35 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-14 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-12 14:11 [PATCH] iommu: Remove iommu_group_get_by_id() Jason Gunthorpe
2023-04-12 14:39 ` Robin Murphy
2023-04-14 11:09 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.