From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Xinhui Pan <Xinhui.Pan@amd.com>, Arnd Bergmann <arnd@arndb.de>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
dri-devel@lists.freedesktop.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, Jarkko Sakkinen <jarkko@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
amd-gfx@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
"H . Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Airlie <airlied@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-sgx@vger.kernel.org
Subject: Re: [PATCH 1/7] mm/gup: remove unused vmas parameter from get_user_pages()
Date: Sat, 15 Apr 2023 07:27:34 +0200 [thread overview]
Message-ID: <ZDo1xtPG-7R8Zdr0@kroah.com> (raw)
In-Reply-To: <d40cb239d0ca01e51f7fc2a276398e8f4dedf9ff.1681508038.git.lstoakes@gmail.com>
On Sat, Apr 15, 2023 at 12:27:13AM +0100, Lorenzo Stoakes wrote:
> No invocation of get_user_pages() uses the vmas parameter, so remove
> it.
>
> The GUP API is confusing and caveated. Recent changes have done much to
> improve that, however there is more we can do. Exporting vmas is a prime
> target as the caller has to be extremely careful to preclude their use
> after the mmap_lock has expired or otherwise be left with dangling
> pointers.
>
> Removing the vmas parameter focuses the GUP functions upon their primary
> purpose - pinning (and outputting) pages as well as performing the actions
> implied by the input flags.
>
> This is part of a patch series aiming to remove the vmas parameter
> altogether.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
x86@kernel.org, linux-sgx@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kvm@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
Xinhui Pan <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Arnd Bergmann <arnd@arndb.de>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/7] mm/gup: remove unused vmas parameter from get_user_pages()
Date: Sat, 15 Apr 2023 07:27:34 +0200 [thread overview]
Message-ID: <ZDo1xtPG-7R8Zdr0@kroah.com> (raw)
In-Reply-To: <d40cb239d0ca01e51f7fc2a276398e8f4dedf9ff.1681508038.git.lstoakes@gmail.com>
On Sat, Apr 15, 2023 at 12:27:13AM +0100, Lorenzo Stoakes wrote:
> No invocation of get_user_pages() uses the vmas parameter, so remove
> it.
>
> The GUP API is confusing and caveated. Recent changes have done much to
> improve that, however there is more we can do. Exporting vmas is a prime
> target as the caller has to be extremely careful to preclude their use
> after the mmap_lock has expired or otherwise be left with dangling
> pointers.
>
> Removing the vmas parameter focuses the GUP functions upon their primary
> purpose - pinning (and outputting) pages as well as performing the actions
> implied by the input flags.
>
> This is part of a patch series aiming to remove the vmas parameter
> altogether.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Xinhui Pan <Xinhui.Pan@amd.com>, Arnd Bergmann <arnd@arndb.de>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
dri-devel@lists.freedesktop.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, Jarkko Sakkinen <jarkko@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
amd-gfx@lists.freedesktop.org, "H . Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-sgx@vger.kernel.org
Subject: Re: [PATCH 1/7] mm/gup: remove unused vmas parameter from get_user_pages()
Date: Sat, 15 Apr 2023 07:27:34 +0200 [thread overview]
Message-ID: <ZDo1xtPG-7R8Zdr0@kroah.com> (raw)
In-Reply-To: <d40cb239d0ca01e51f7fc2a276398e8f4dedf9ff.1681508038.git.lstoakes@gmail.com>
On Sat, Apr 15, 2023 at 12:27:13AM +0100, Lorenzo Stoakes wrote:
> No invocation of get_user_pages() uses the vmas parameter, so remove
> it.
>
> The GUP API is confusing and caveated. Recent changes have done much to
> improve that, however there is more we can do. Exporting vmas is a prime
> target as the caller has to be extremely careful to preclude their use
> after the mmap_lock has expired or otherwise be left with dangling
> pointers.
>
> Removing the vmas parameter focuses the GUP functions upon their primary
> purpose - pinning (and outputting) pages as well as performing the actions
> implied by the input flags.
>
> This is part of a patch series aiming to remove the vmas parameter
> altogether.
>
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2023-04-17 7:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 23:25 [PATCH 0/7] remove the vmas parameter from GUP APIs Lorenzo Stoakes
2023-04-14 23:27 ` [PATCH 1/7] mm/gup: remove unused vmas parameter from get_user_pages() Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-15 5:27 ` Greg Kroah-Hartman [this message]
2023-04-15 5:27 ` Greg Kroah-Hartman
2023-04-15 5:27 ` Greg Kroah-Hartman
2023-04-17 13:01 ` Jason Gunthorpe
2023-04-17 13:01 ` Jason Gunthorpe
2023-04-17 13:01 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 2/7] mm/gup: remove unused vmas parameter from pin_user_pages_remote() Lorenzo Stoakes
2023-04-17 13:02 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-15 0:25 ` Tetsuo Handa
2023-04-15 8:11 ` Lorenzo Stoakes
2023-04-17 13:09 ` Jason Gunthorpe
2023-04-17 13:09 ` Jason Gunthorpe
2023-04-17 13:13 ` Lorenzo Stoakes
2023-04-17 13:13 ` Lorenzo Stoakes
2023-04-17 13:16 ` Jason Gunthorpe
2023-04-17 13:16 ` Jason Gunthorpe
2023-04-17 13:23 ` Lorenzo Stoakes
2023-04-17 13:23 ` Lorenzo Stoakes
2023-04-17 15:07 ` Eric W. Biederman
2023-04-17 15:07 ` Eric W. Biederman
2023-04-17 15:14 ` Lorenzo Stoakes
2023-04-17 15:14 ` Lorenzo Stoakes
2023-04-14 23:27 ` [PATCH 4/7] mm/gup: introduce the FOLL_SAME_FILE GUP flag Lorenzo Stoakes
2023-04-17 13:14 ` Jason Gunthorpe
2023-04-17 13:25 ` Lorenzo Stoakes
2023-04-17 13:27 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 5/7] io_uring: rsrc: use FOLL_SAME_FILE on pin_user_pages() Lorenzo Stoakes
2023-04-17 12:56 ` Jason Gunthorpe
2023-04-17 13:19 ` Lorenzo Stoakes
2023-04-17 13:26 ` Jason Gunthorpe
2023-04-17 14:00 ` Lorenzo Stoakes
2023-04-17 14:15 ` Jason Gunthorpe
2023-04-17 15:20 ` Lorenzo Stoakes
2023-04-17 19:00 ` Lorenzo Stoakes
2023-04-17 19:24 ` Jason Gunthorpe
2023-04-17 19:45 ` Lorenzo Stoakes
2023-04-18 16:25 ` Pavel Begunkov
2023-04-18 16:35 ` Pavel Begunkov
2023-04-18 16:36 ` Jason Gunthorpe
2023-04-18 17:25 ` Pavel Begunkov
2023-04-18 18:19 ` Jason Gunthorpe
2023-04-14 23:27 ` [PATCH 6/7] mm/gup: remove vmas parameter from pin_user_pages() Lorenzo Stoakes
2023-04-14 23:27 ` Lorenzo Stoakes
2023-04-14 23:27 ` [PATCH 7/7] mm/gup: remove vmas array from internal GUP functions Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDo1xtPG-7R8Zdr0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=daniel@ffwll.ch \
--cc=david@redhat.com \
--cc=dimitri.sivanich@hpe.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sgx@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.