From: Wolfram Sang <wsa@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH 1/1] i2c: imx-lpi2c: avoid taking clk_prepare mutex in PM callbacks
Date: Sun, 30 Apr 2023 08:58:05 +0200 [thread overview]
Message-ID: <ZE4RfbOBIPH13YZQ@sai> (raw)
In-Reply-To: <20230424080627.20564-1-alexander.stein@ew.tq-group.com>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
On Mon, Apr 24, 2023 at 10:06:27AM +0200, Alexander Stein wrote:
> This is unsafe, as the runtime PM callbacks are called from the PM
> workqueue, so this may deadlock when handling an i2c attached clock,
> which may already hold the clk_prepare mutex from another context.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH 1/1] i2c: imx-lpi2c: avoid taking clk_prepare mutex in PM callbacks
Date: Sun, 30 Apr 2023 08:58:05 +0200 [thread overview]
Message-ID: <ZE4RfbOBIPH13YZQ@sai> (raw)
In-Reply-To: <20230424080627.20564-1-alexander.stein@ew.tq-group.com>
[-- Attachment #1.1: Type: text/plain, Size: 387 bytes --]
On Mon, Apr 24, 2023 at 10:06:27AM +0200, Alexander Stein wrote:
> This is unsafe, as the runtime PM callbacks are called from the PM
> workqueue, so this may deadlock when handling an i2c attached clock,
> which may already hold the clk_prepare mutex from another context.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-30 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 8:06 [PATCH 1/1] i2c: imx-lpi2c: avoid taking clk_prepare mutex in PM callbacks Alexander Stein
2023-04-24 8:06 ` Alexander Stein
2023-04-30 6:58 ` Wolfram Sang [this message]
2023-04-30 6:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZE4RfbOBIPH13YZQ@sai \
--to=wsa@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alexander.sverdlin@siemens.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.