From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
mathieu.poirier@linaro.org, darren@os.amperecomputing.com,
scott@os.amperecomputing.com, scclevenger@os.amperecomputing.com,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org
Subject: Re: [PATCH] perf cs-etm: Add support for coresight trace for any range of CPUs
Date: Thu, 20 Apr 2023 15:33:10 -0300 [thread overview]
Message-ID: <ZEGFZmBJSzr/PIgc@kernel.org> (raw)
In-Reply-To: <53132776-c998-a24f-a811-d8fb2e5e6535@arm.com>
Em Thu, Apr 20, 2023 at 04:44:21PM +0100, James Clark escreveu:
> On 20/04/2023 14:03, Suzuki K Poulose wrote:
> > On 20/04/2023 13:37, Ganapatrao Kulkarni wrote:
> >> On 20-04-2023 06:00 pm, James Clark wrote:
> >>> On 20/04/2023 12:47, Ganapatrao Kulkarni wrote:
> >>>> My patch is rebased on 6.3-RC7 codebase with Mike's 3 perf patches
> >>>> related to dynamic id [1] support(queued for 6.4).
> >>>> "perf report -D" works for me.
> >>> I was referring to sparse CPU lists, which I think you mentioned above
> >>> doesn't work even with this patch.
> >>>> [1] https://www.spinics.net/lists/linux-perf-users/msg27452.html
> >>> It should be based on the next branch here:
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git
> >> OK.
> > It need not be. Since this patch is purely perf tools patch and has
> > nothing to do with the kernel drivers, it should be beased on whatever
> > the tip of the perf tool tree is. Otherwise we risk rebasing to that
> > eventually.
> Good point, sorry for the confusion!
> I wonder if we could have some kind of new staging branch that has both
> up to date perf and coresight changes at the same time? Either that
> would make things like this easier, or more complicated. I'm not sure.
> I suppose I can DIY it quite easily but then everyone would have to as well.
My two cents: It this was available together with a CI that would run
'perf test' + 'make -C tools/perf build-test' and any other set of
tests, that would be great.
But not having it also has an advantage: no lockstep development,
tooling should gracefully work with whatever is available.
I say this because it is a really common theme, even Debian had a
packaging scheme that shoehorned (forcefully fused?) perf's and the
kernel's version :-\
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
mathieu.poirier@linaro.org, darren@os.amperecomputing.com,
scott@os.amperecomputing.com, scclevenger@os.amperecomputing.com,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org
Subject: Re: [PATCH] perf cs-etm: Add support for coresight trace for any range of CPUs
Date: Thu, 20 Apr 2023 15:33:10 -0300 [thread overview]
Message-ID: <ZEGFZmBJSzr/PIgc@kernel.org> (raw)
In-Reply-To: <53132776-c998-a24f-a811-d8fb2e5e6535@arm.com>
Em Thu, Apr 20, 2023 at 04:44:21PM +0100, James Clark escreveu:
> On 20/04/2023 14:03, Suzuki K Poulose wrote:
> > On 20/04/2023 13:37, Ganapatrao Kulkarni wrote:
> >> On 20-04-2023 06:00 pm, James Clark wrote:
> >>> On 20/04/2023 12:47, Ganapatrao Kulkarni wrote:
> >>>> My patch is rebased on 6.3-RC7 codebase with Mike's 3 perf patches
> >>>> related to dynamic id [1] support(queued for 6.4).
> >>>> "perf report -D" works for me.
> >>> I was referring to sparse CPU lists, which I think you mentioned above
> >>> doesn't work even with this patch.
> >>>> [1] https://www.spinics.net/lists/linux-perf-users/msg27452.html
> >>> It should be based on the next branch here:
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git
> >> OK.
> > It need not be. Since this patch is purely perf tools patch and has
> > nothing to do with the kernel drivers, it should be beased on whatever
> > the tip of the perf tool tree is. Otherwise we risk rebasing to that
> > eventually.
> Good point, sorry for the confusion!
> I wonder if we could have some kind of new staging branch that has both
> up to date perf and coresight changes at the same time? Either that
> would make things like this easier, or more complicated. I'm not sure.
> I suppose I can DIY it quite easily but then everyone would have to as well.
My two cents: It this was available together with a CI that would run
'perf test' + 'make -C tools/perf build-test' and any other set of
tests, that would be great.
But not having it also has an advantage: no lockstep development,
tooling should gracefully work with whatever is available.
I say this because it is a really common theme, even Debian had a
packaging scheme that shoehorned (forcefully fused?) perf's and the
kernel's version :-\
- Arnaldo
next prev parent reply other threads:[~2023-04-20 18:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 17:21 [PATCH] perf cs-etm: Add support for coresight trace for any range of CPUs Ganapatrao Kulkarni
2023-04-19 17:21 ` Ganapatrao Kulkarni
2023-04-20 9:43 ` James Clark
2023-04-20 9:43 ` James Clark
2023-04-20 10:14 ` James Clark
2023-04-20 10:14 ` James Clark
2023-04-20 11:47 ` Ganapatrao Kulkarni
2023-04-20 11:47 ` Ganapatrao Kulkarni
2023-04-20 12:30 ` James Clark
2023-04-20 12:30 ` James Clark
2023-04-20 12:37 ` Ganapatrao Kulkarni
2023-04-20 12:37 ` Ganapatrao Kulkarni
2023-04-20 13:03 ` Suzuki K Poulose
2023-04-20 13:03 ` Suzuki K Poulose
2023-04-20 15:44 ` James Clark
2023-04-20 15:44 ` James Clark
2023-04-20 18:33 ` Arnaldo Carvalho de Melo [this message]
2023-04-20 18:33 ` Arnaldo Carvalho de Melo
2023-04-21 8:55 ` Suzuki K Poulose
2023-04-21 8:55 ` Suzuki K Poulose
2023-04-20 14:30 ` Ganapatrao Kulkarni
2023-04-20 14:30 ` Ganapatrao Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEGFZmBJSzr/PIgc@kernel.org \
--to=acme@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=darren@os.amperecomputing.com \
--cc=gankulkarni@os.amperecomputing.com \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=scclevenger@os.amperecomputing.com \
--cc=scott@os.amperecomputing.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.