All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] usb-audio: Rate limit usb_set_interface error reporting
Date: Fri, 21 Apr 2023 15:48:27 +0100	[thread overview]
Message-ID: <ZEKiO7lh94QUyuAs@chrisdown.name> (raw)
In-Reply-To: <87wn25qosu.wl-tiwai@suse.de>

Hi Takashi,

Takashi Iwai writes:
>This patch itself is safe and good to have, so I'm going to take it as
>is.

Thanks!

>But I'm still curious in which code path the problem happens.  That
>is, we should address such unnecessary repeats if possible.  Do you
>have some more data?

Unfortunately not, I've been running with a kernel testing some other mm 
changes recently so haven't had a chance to debug what's going on here. But it 
starts like this:

     [Fri Apr 21 13:21:10 2023] usb 3-7: USB disconnect, device number 39
     [Fri Apr 21 13:21:10 2023] usb 3-7.1: USB disconnect, device number 40
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.1: USB disconnect, device number 42
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb (err = -19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: Unable to submit urb #2: -19 at snd_usb_queue_pending_output_urbs
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: 1:0: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: 2:0: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.2: USB disconnect, device number 44
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [... thousands of messages ensue ...]

So it looks like maybe some ordering is not quite right in destruction, perhaps 
only on multi-level USB topologies?

Thanks,

Chris

WARNING: multiple messages have this Message-ID (diff)
From: Chris Down <chris@chrisdown.name>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] usb-audio: Rate limit usb_set_interface error reporting
Date: Fri, 21 Apr 2023 15:48:27 +0100	[thread overview]
Message-ID: <ZEKiO7lh94QUyuAs@chrisdown.name> (raw)
In-Reply-To: <87wn25qosu.wl-tiwai@suse.de>

Hi Takashi,

Takashi Iwai writes:
>This patch itself is safe and good to have, so I'm going to take it as
>is.

Thanks!

>But I'm still curious in which code path the problem happens.  That
>is, we should address such unnecessary repeats if possible.  Do you
>have some more data?

Unfortunately not, I've been running with a kernel testing some other mm 
changes recently so haven't had a chance to debug what's going on here. But it 
starts like this:

     [Fri Apr 21 13:21:10 2023] usb 3-7: USB disconnect, device number 39
     [Fri Apr 21 13:21:10 2023] usb 3-7.1: USB disconnect, device number 40
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.1: USB disconnect, device number 42
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb (err = -19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: Unable to submit urb #2: -19 at snd_usb_queue_pending_output_urbs
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: 1:0: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.4: 2:0: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.2: USB disconnect, device number 44
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19)
     [... thousands of messages ensue ...]

So it looks like maybe some ordering is not quite right in destruction, perhaps 
only on multi-level USB topologies?

Thanks,

Chris

  reply	other threads:[~2023-04-21 14:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 14:38 [PATCH] usb-audio: Rate limit usb_set_interface error reporting Chris Down
2023-04-21 14:38 ` Chris Down
2023-04-21 14:42 ` Takashi Iwai
2023-04-21 14:42   ` Takashi Iwai
2023-04-21 14:48   ` Chris Down [this message]
2023-04-21 14:48     ` Chris Down
2023-04-21 15:11     ` Takashi Iwai
2023-04-21 15:11       ` Takashi Iwai
2023-04-21 15:16       ` Chris Down
2023-04-21 15:16         ` Chris Down
2023-04-21 15:37         ` Takashi Iwai
2023-04-21 15:37           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEKiO7lh94QUyuAs@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.