From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Kevin Tian <kevin.tian@intel.com>,
Nicolin Chen <nicolinc@nvidia.com>
Subject: Re: [PATCH 08/11] iommu: Always destroy the iommu_group during iommu_release_device()
Date: Wed, 26 Apr 2023 10:47:35 -0300 [thread overview]
Message-ID: <ZEkrd2VY3wOdcSWm@nvidia.com> (raw)
In-Reply-To: <da60a120-e1dd-3b61-d6c4-ba0d955e2339@linux.intel.com>
On Thu, Apr 20, 2023 at 12:23:11PM +0800, Baolu Lu wrote:
> On 4/20/23 12:11 AM, Jason Gunthorpe wrote:
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index dbaf3ed9012c45..a82516c8ea87ad 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -569,7 +569,6 @@ static void __iommu_group_remove_device(struct device *dev)
> > dev->iommu_group = NULL;
> > goto out;
>
> Nit, given that below line has been removed, can above simply be a
> loop break?
Yes, that is much nicer
Thanks,
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Will Deacon <will@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linuxppc-dev@lists.ozlabs.org, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-acpi@vger.kernel.org, iommu@lists.linux.dev,
Nicolin Chen <nicolinc@nvidia.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 08/11] iommu: Always destroy the iommu_group during iommu_release_device()
Date: Wed, 26 Apr 2023 10:47:35 -0300 [thread overview]
Message-ID: <ZEkrd2VY3wOdcSWm@nvidia.com> (raw)
In-Reply-To: <da60a120-e1dd-3b61-d6c4-ba0d955e2339@linux.intel.com>
On Thu, Apr 20, 2023 at 12:23:11PM +0800, Baolu Lu wrote:
> On 4/20/23 12:11 AM, Jason Gunthorpe wrote:
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index dbaf3ed9012c45..a82516c8ea87ad 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -569,7 +569,6 @@ static void __iommu_group_remove_device(struct device *dev)
> > dev->iommu_group = NULL;
> > goto out;
>
> Nit, given that below line has been removed, can above simply be a
> loop break?
Yes, that is much nicer
Thanks,
Jason
next prev parent reply other threads:[~2023-04-26 13:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 16:11 [PATCH 00/11] Consolidate the probe_device path Jason Gunthorpe
2023-04-19 16:11 ` [PATCH 01/11] iommu: Have __iommu_probe_device() check for already probed devices Jason Gunthorpe
2023-04-26 9:12 ` Tian, Kevin
2023-04-19 16:11 ` [PATCH 02/11] iommu: Use iommu_group_ref_get/put() for dev->iommu_group Jason Gunthorpe
2023-04-26 9:12 ` Tian, Kevin
2023-04-19 16:11 ` [PATCH 03/11] iommu: Inline iommu_group_get_for_dev() into __iommu_probe_device() Jason Gunthorpe
2023-04-26 9:21 ` Tian, Kevin
2023-04-19 16:11 ` [PATCH 04/11] iommu: Simplify the __iommu_group_remove_device() flow Jason Gunthorpe
2023-04-26 9:21 ` Tian, Kevin
2023-04-19 16:11 ` [PATCH 05/11] iommu: Add iommu_init/deinit_driver() paired functions Jason Gunthorpe
2023-04-26 9:41 ` Tian, Kevin
2023-04-26 14:36 ` Jason Gunthorpe
2023-04-26 14:36 ` Jason Gunthorpe
2023-04-19 16:11 ` [PATCH 06/11] iommu: Move the iommu driver sysfs setup into iommu_init/deinit_driver() Jason Gunthorpe
2023-04-26 9:41 ` Tian, Kevin
2023-04-19 16:11 ` [PATCH 07/11] iommu: Do not export iommu_device_link/unlink() Jason Gunthorpe
2023-04-26 9:42 ` Tian, Kevin
2023-04-19 16:11 ` [PATCH 08/11] iommu: Always destroy the iommu_group during iommu_release_device() Jason Gunthorpe
2023-04-20 4:23 ` Baolu Lu
2023-04-20 4:23 ` Baolu Lu
2023-04-26 13:47 ` Jason Gunthorpe [this message]
2023-04-26 13:47 ` Jason Gunthorpe
2023-04-26 9:42 ` Tian, Kevin
2023-04-19 16:11 ` [PATCH 09/11] iommu/power: Remove iommu_del_device() Jason Gunthorpe
2023-04-19 16:11 ` [PATCH 10/11] iommu: Split iommu_group_add_device() Jason Gunthorpe
2023-04-20 4:25 ` Baolu Lu
2023-04-20 4:25 ` Baolu Lu
2023-04-20 13:09 ` Jason Gunthorpe
2023-04-20 13:09 ` Jason Gunthorpe
2023-04-19 16:11 ` [PATCH 11/11] iommu: Avoid locking/unlocking for iommu_probe_device() Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEkrd2VY3wOdcSWm@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nicolinc@nvidia.com \
--cc=npiggin@gmail.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.