From: Daniel Golle <daniel@makrotopia.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
erkin.bozoglu@xeront.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Richard van Schagen" <richard@routerhints.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Richard van Schagen" <vschagen@cs.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
linux-mediatek@lists.infradead.org,
"Bartel Eerdekens" <bartel.eerdekens@constell8.be>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 04/24] net: dsa: mt7530: properly support MT7531AE and MT7531BE
Date: Wed, 26 Apr 2023 17:15:12 +0100 [thread overview]
Message-ID: <ZElOEAsoNXUlYL1g@makrotopia.org> (raw)
In-Reply-To: <20230426143944.s5vmhloepa3yodrj@skbuf>
On Wed, Apr 26, 2023 at 05:39:44PM +0300, Vladimir Oltean wrote:
> On Wed, Apr 26, 2023 at 02:07:45PM +0100, Daniel Golle wrote:
> > On Wed, Apr 26, 2023 at 11:12:09AM +0300, Arınç ÜNAL wrote:
> > > On 25.04.2023 18:04, Daniel Golle wrote:
> > > > On Tue, Apr 25, 2023 at 11:29:13AM +0300, arinc9.unal@gmail.com wrote:
> > > > > From: Arınç ÜNAL <arinc.unal@arinc9.com>
> > > > >
> > > > > Introduce the p5_sgmii pointer to store the information for whether port 5
> > > > > has got SGMII or not.
> > > >
> > > > The p5_sgmii your are introducing to struct mt7530_priv is a boolean
> > > > variable, and not a pointer.
> > >
> > > I must've meant to say field.
> >
> > Being just a single boolean variable also 'field' would not be the right
> > word here. We use 'field' as in 'bitfield', ie. usually disguised integer
> > types in which each bit has an assigned meaning.
>
> "field" is a perfectly legal name for a member of a C structure.
> https://en.wikipedia.org/wiki/Struct_(C_programming_language)
> Not to be confused with bitfield.
Right, thank you for pointing that out.
Must have slipped off my mind that all this is inside a struct, of
course...
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Russell King" <linux@armlinux.org.uk>,
"Richard van Schagen" <richard@routerhints.com>,
"Richard van Schagen" <vschagen@cs.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Bartel Eerdekens" <bartel.eerdekens@constell8.be>,
erkin.bozoglu@xeront.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 04/24] net: dsa: mt7530: properly support MT7531AE and MT7531BE
Date: Wed, 26 Apr 2023 17:15:12 +0100 [thread overview]
Message-ID: <ZElOEAsoNXUlYL1g@makrotopia.org> (raw)
In-Reply-To: <20230426143944.s5vmhloepa3yodrj@skbuf>
On Wed, Apr 26, 2023 at 05:39:44PM +0300, Vladimir Oltean wrote:
> On Wed, Apr 26, 2023 at 02:07:45PM +0100, Daniel Golle wrote:
> > On Wed, Apr 26, 2023 at 11:12:09AM +0300, Arınç ÜNAL wrote:
> > > On 25.04.2023 18:04, Daniel Golle wrote:
> > > > On Tue, Apr 25, 2023 at 11:29:13AM +0300, arinc9.unal@gmail.com wrote:
> > > > > From: Arınç ÜNAL <arinc.unal@arinc9.com>
> > > > >
> > > > > Introduce the p5_sgmii pointer to store the information for whether port 5
> > > > > has got SGMII or not.
> > > >
> > > > The p5_sgmii your are introducing to struct mt7530_priv is a boolean
> > > > variable, and not a pointer.
> > >
> > > I must've meant to say field.
> >
> > Being just a single boolean variable also 'field' would not be the right
> > word here. We use 'field' as in 'bitfield', ie. usually disguised integer
> > types in which each bit has an assigned meaning.
>
> "field" is a perfectly legal name for a member of a C structure.
> https://en.wikipedia.org/wiki/Struct_(C_programming_language)
> Not to be confused with bitfield.
Right, thank you for pointing that out.
Must have slipped off my mind that all this is inside a struct, of
course...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Russell King" <linux@armlinux.org.uk>,
"Richard van Schagen" <richard@routerhints.com>,
"Richard van Schagen" <vschagen@cs.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Bartel Eerdekens" <bartel.eerdekens@constell8.be>,
erkin.bozoglu@xeront.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next 04/24] net: dsa: mt7530: properly support MT7531AE and MT7531BE
Date: Wed, 26 Apr 2023 17:15:12 +0100 [thread overview]
Message-ID: <ZElOEAsoNXUlYL1g@makrotopia.org> (raw)
In-Reply-To: <20230426143944.s5vmhloepa3yodrj@skbuf>
On Wed, Apr 26, 2023 at 05:39:44PM +0300, Vladimir Oltean wrote:
> On Wed, Apr 26, 2023 at 02:07:45PM +0100, Daniel Golle wrote:
> > On Wed, Apr 26, 2023 at 11:12:09AM +0300, Arınç ÜNAL wrote:
> > > On 25.04.2023 18:04, Daniel Golle wrote:
> > > > On Tue, Apr 25, 2023 at 11:29:13AM +0300, arinc9.unal@gmail.com wrote:
> > > > > From: Arınç ÜNAL <arinc.unal@arinc9.com>
> > > > >
> > > > > Introduce the p5_sgmii pointer to store the information for whether port 5
> > > > > has got SGMII or not.
> > > >
> > > > The p5_sgmii your are introducing to struct mt7530_priv is a boolean
> > > > variable, and not a pointer.
> > >
> > > I must've meant to say field.
> >
> > Being just a single boolean variable also 'field' would not be the right
> > word here. We use 'field' as in 'bitfield', ie. usually disguised integer
> > types in which each bit has an assigned meaning.
>
> "field" is a perfectly legal name for a member of a C structure.
> https://en.wikipedia.org/wiki/Struct_(C_programming_language)
> Not to be confused with bitfield.
Right, thank you for pointing that out.
Must have slipped off my mind that all this is inside a struct, of
course...
next prev parent reply other threads:[~2023-04-26 16:17 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 8:29 [PATCH net-next 00/24] net: dsa: MT7530, MT7531, and MT7988 improvements arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 01/24] net: dsa: mt7530: fix corrupt frames using trgmii on 40 MHz XTAL MT7621 arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 02/24] net: dsa: mt7530: add missing @p5_interface to mt7530_priv description arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 03/24] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 15:06 ` Daniel Golle
2023-04-25 15:06 ` Daniel Golle
2023-04-25 15:06 ` Daniel Golle
2023-04-25 8:29 ` [PATCH net-next 04/24] net: dsa: mt7530: properly support MT7531AE and MT7531BE arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 15:04 ` Daniel Golle
2023-04-25 15:04 ` Daniel Golle
2023-04-25 15:04 ` Daniel Golle
2023-04-26 8:12 ` Arınç ÜNAL
2023-04-26 8:12 ` Arınç ÜNAL
2023-04-26 8:12 ` Arınç ÜNAL
2023-04-26 13:07 ` Daniel Golle
2023-04-26 13:07 ` Daniel Golle
2023-04-26 13:07 ` Daniel Golle
2023-04-26 14:39 ` Vladimir Oltean
2023-04-26 14:39 ` Vladimir Oltean
2023-04-26 14:39 ` Vladimir Oltean
2023-04-26 16:15 ` Daniel Golle [this message]
2023-04-26 16:15 ` Daniel Golle
2023-04-26 16:15 ` Daniel Golle
2023-04-25 8:29 ` [PATCH net-next 05/24] net: dsa: mt7530: improve comments regarding port 5 and 6 arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 06/24] net: dsa: mt7530: read XTAL value from correct register arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 07/24] net: dsa: mt7530: improve code path for setting up port 5 arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 08/24] net: dsa: mt7530: do not run mt7530_setup_port5() if port 5 is disabled arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 09/24] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 10/24] net: dsa: mt7530: empty default case on mt7530_setup_port5() arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 15:13 ` Daniel Golle
2023-04-25 15:13 ` Daniel Golle
2023-04-25 15:13 ` Daniel Golle
2023-04-26 8:22 ` Arınç ÜNAL
2023-04-26 8:22 ` Arınç ÜNAL
2023-04-26 8:22 ` Arınç ÜNAL
2023-04-25 8:29 ` [PATCH net-next 11/24] net: dsa: mt7530: call port 6 setup from mt7530_mac_config() arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 12/24] net: dsa: mt7530: remove pad_setup function pointer arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 13/24] net: dsa: mt7530: move XTAL check to mt7530_setup() arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 14/24] net: dsa: mt7530: move enabling port 6 to mt7530_setup_port6() arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 15/24] net: dsa: mt7530: switch to if/else statements on mt7530_setup_port6() arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 16/24] net: dsa: mt7530: set TRGMII RD TAP if trgmii is being used arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 17/24] net: dsa: mt7530: move lowering port 5 RGMII driving to mt7530_setup() arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 18/24] net: dsa: mt7530: fix port capabilities for MT7988 arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 19/24] net: dsa: mt7530: remove .mac_port_config for MT7988 and make it optional arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 20/24] net: dsa: mt7530: set interrupt register only for MT7530 arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 21/24] net: dsa: mt7530: force link-down on MACs before reset on MT7530 arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 22/24] net: dsa: mt7530: get rid of useless error returns on phylink code path arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 23/24] net: dsa: mt7530: rename p5_intf_sel and use only for MT7530 switch arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` [PATCH net-next 24/24] net: dsa: mt7530: run mt7530_pll_setup() only with 40 MHz XTAL arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 8:29 ` arinc9.unal
2023-04-25 15:35 ` [PATCH net-next 00/24] net: dsa: MT7530, MT7531, and MT7988 improvements Jakub Kicinski
2023-04-25 15:35 ` Jakub Kicinski
2023-04-25 15:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZElOEAsoNXUlYL1g@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=bartel.eerdekens@constell8.be \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richard@routerhints.com \
--cc=sean.wang@mediatek.com \
--cc=vschagen@cs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.