From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"Hao, Xudong" <xudong.hao@intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"lulu@redhat.com" <lulu@redhat.com>,
"Jiang, Yanting" <yanting.jiang@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices
Date: Fri, 28 Apr 2023 09:07:53 -0300 [thread overview]
Message-ID: <ZEu3Ga9cIQAykBGf@nvidia.com> (raw)
In-Reply-To: <a6b77884-1678-b17c-f6a4-28d56e6c366b@intel.com>
On Fri, Apr 28, 2023 at 02:21:26PM +0800, Yi Liu wrote:
> but this patch needs to use vfio_iommufd_emulated_bind() and
> vfio_iommufd_emulated_unbind() for the noiommu devices when binding
> to iommufd. So needs to check noiommu in the vfio_iommufd_bind()
> and vfio_iommu_unbind() as well.
I'm not sure this is strictly necessary, it just needs an access
The emulated stuff is for mdev only, it should not be confused with
no-iommu
Eg if you had a no_iommu_access value to store the access it would be
fine and could serve as the 'this is no_iommu' flag
The only purpose of the access at this moment is to get an iommufdctx
id to return to userspace.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"Hao, Xudong" <xudong.hao@intel.com>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
"Jiang, Yanting" <yanting.jiang@intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: Re: [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices
Date: Fri, 28 Apr 2023 09:07:53 -0300 [thread overview]
Message-ID: <ZEu3Ga9cIQAykBGf@nvidia.com> (raw)
In-Reply-To: <a6b77884-1678-b17c-f6a4-28d56e6c366b@intel.com>
On Fri, Apr 28, 2023 at 02:21:26PM +0800, Yi Liu wrote:
> but this patch needs to use vfio_iommufd_emulated_bind() and
> vfio_iommufd_emulated_unbind() for the noiommu devices when binding
> to iommufd. So needs to check noiommu in the vfio_iommufd_bind()
> and vfio_iommu_unbind() as well.
I'm not sure this is strictly necessary, it just needs an access
The emulated stuff is for mdev only, it should not be confused with
no-iommu
Eg if you had a no_iommu_access value to store the access it would be
fine and could serve as the 'this is no_iommu' flag
The only purpose of the access at this moment is to get an iommufdctx
id to return to userspace.
Jason
next prev parent reply other threads:[~2023-04-28 12:08 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 14:54 [Intel-gfx] [PATCH v4 0/9] Enhance vfio PCI hot reset for vfio cdev device Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 1/9] vfio: Determine noiommu in vfio_device registration Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:36 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:36 ` Tian, Kevin
2023-04-27 7:05 ` [Intel-gfx] " Liu, Yi L
2023-04-27 7:05 ` Liu, Yi L
2023-04-27 18:35 ` [Intel-gfx] " Alex Williamson
2023-04-27 18:35 ` Alex Williamson
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:39 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:39 ` Tian, Kevin
2023-04-27 6:59 ` [Intel-gfx] " Liu, Yi L
2023-04-27 6:59 ` Liu, Yi L
2023-04-27 18:32 ` [Intel-gfx] " Alex Williamson
2023-04-27 18:32 ` Alex Williamson
2023-04-28 6:21 ` [Intel-gfx] " Yi Liu
2023-04-28 6:21 ` Yi Liu
2023-04-28 7:00 ` [Intel-gfx] " Tian, Kevin
2023-04-28 7:00 ` Tian, Kevin
2023-04-28 7:04 ` [Intel-gfx] " Yi Liu
2023-04-28 7:04 ` Yi Liu
2023-04-28 12:07 ` Jason Gunthorpe [this message]
2023-04-28 12:07 ` Jason Gunthorpe
2023-04-28 16:07 ` [Intel-gfx] " Yi Liu
2023-04-28 16:07 ` Yi Liu
2023-05-02 18:12 ` [Intel-gfx] " Jason Gunthorpe
2023-05-02 18:12 ` Jason Gunthorpe
2023-05-03 9:48 ` [Intel-gfx] " Liu, Yi L
2023-05-03 9:48 ` Liu, Yi L
2023-05-03 19:42 ` [Intel-gfx] " Jason Gunthorpe
2023-05-03 19:42 ` Jason Gunthorpe
2023-05-08 15:46 ` [Intel-gfx] " Liu, Yi L
2023-05-08 15:46 ` Liu, Yi L
2023-04-28 16:13 ` [Intel-gfx] " Yi Liu
2023-04-28 16:13 ` Yi Liu
2023-05-02 18:22 ` [Intel-gfx] " Jason Gunthorpe
2023-05-02 18:22 ` Jason Gunthorpe
2023-05-03 9:57 ` [Intel-gfx] " Liu, Yi L
2023-05-03 9:57 ` Liu, Yi L
2023-05-03 19:41 ` [Intel-gfx] " Jason Gunthorpe
2023-05-03 19:41 ` Jason Gunthorpe
2023-05-03 22:49 ` [Intel-gfx] " Alex Williamson
2023-05-03 22:49 ` Alex Williamson
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 3/9] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 4/9] vfio/pci: Move the existing hot reset logic to be a helper Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:39 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:39 ` Tian, Kevin
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 5/9] vfio: Mark cdev usage in vfio_device Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:40 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:40 ` Tian, Kevin
2023-04-27 18:43 ` [Intel-gfx] " Alex Williamson
2023-04-27 18:43 ` Alex Williamson
2023-04-28 6:42 ` [Intel-gfx] " Yi Liu
2023-04-28 6:42 ` Yi Liu
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 6/9] iommufd: Reserved -1 in the iommufd xarray Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:41 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:41 ` Tian, Kevin
2023-04-27 7:09 ` [Intel-gfx] " Liu, Yi L
2023-04-27 7:09 ` Liu, Yi L
2023-04-27 11:55 ` [Intel-gfx] " Jason Gunthorpe
2023-04-27 11:55 ` Jason Gunthorpe
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 7/9] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:45 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:45 ` Tian, Kevin
2023-04-27 6:45 ` Tian, Kevin
2023-04-27 7:15 ` [Intel-gfx] " Liu, Yi L
2023-04-27 7:15 ` Liu, Yi L
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:51 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:51 ` Tian, Kevin
2023-04-27 20:04 ` [Intel-gfx] " Alex Williamson
2023-04-27 20:04 ` Alex Williamson
2023-04-27 20:15 ` [Intel-gfx] " Alex Williamson
2023-04-27 20:15 ` Alex Williamson
2023-05-08 15:32 ` [Intel-gfx] " Liu, Yi L
2023-05-08 15:32 ` Liu, Yi L
2023-05-08 20:29 ` [Intel-gfx] " Alex Williamson
2023-05-08 20:29 ` Alex Williamson
2023-04-26 14:54 ` [Intel-gfx] [PATCH v4 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET Yi Liu
2023-04-26 14:54 ` Yi Liu
2023-04-27 6:54 ` [Intel-gfx] " Tian, Kevin
2023-04-27 6:54 ` Tian, Kevin
2023-04-27 7:02 ` [Intel-gfx] " Liu, Yi L
2023-04-27 7:02 ` Liu, Yi L
2023-04-27 21:55 ` [Intel-gfx] " Alex Williamson
2023-04-27 21:55 ` Alex Williamson
2023-05-02 12:55 ` [Intel-gfx] " Liu, Yi L
2023-05-02 12:55 ` Liu, Yi L
2023-04-26 15:07 ` [Intel-gfx] [PATCH v4 0/9] Enhance vfio PCI hot reset for vfio cdev device Liu, Yi L
2023-04-26 15:07 ` Liu, Yi L
2023-04-26 15:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for " Patchwork
2023-04-28 9:28 ` [Intel-gfx] [PATCH v4 0/9] " Jiang, Yanting
2023-04-28 9:28 ` Jiang, Yanting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEu3Ga9cIQAykBGf@nvidia.com \
--to=jgg@nvidia.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.