From: Simon Horman <simon.horman@corigine.com>
To: Md Danish Anwar <a0501179@ti.com>
Cc: MD Danish Anwar <danishanwar@ti.com>,
"Andrew F. Davis" <afd@ti.com>, Tero Kristo <kristo@kernel.org>,
Suman Anna <s-anna@ti.com>, Roger Quadros <rogerq@kernel.org>,
YueHaibing <yuehaibing@huawei.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
andrew@lunn.ch, Randy Dunlap <rdunlap@infradead.org>,
Richard Cochran <richardcochran@gmail.com>,
nm@ti.com, ssantosh@kernel.org, srk@ti.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [EXTERNAL] Re: [RFC PATCH v6 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Fri, 28 Apr 2023 15:47:52 +0200 [thread overview]
Message-ID: <ZEvOiMSIIYG6nmsu@corigine.com> (raw)
In-Reply-To: <ff6fe35f-ca4b-a48d-777f-196b771a14d3@ti.com>
On Fri, Apr 28, 2023 at 02:36:42PM +0530, Md Danish Anwar wrote:
> Hi Simon.
>
> On 27/04/23 12:42, Md Danish Anwar wrote:
> > Hi Simon,
> > Thanks for the comments.
> >
> > On 27/04/23 00:39, Simon Horman wrote:
> >> On Mon, Apr 24, 2023 at 11:02:33AM +0530, MD Danish Anwar wrote:
> >>> From: Roger Quadros <rogerq@ti.com>
> >>>
> >>> This is the Ethernet driver for TI AM654 Silicon rev. 2
> >>> with the ICSSG PRU Sub-system running dual-EMAC firmware.
> >>>
>
> [ ... ]
>
> >>
> >> ...
> >>
> >>> +MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
> >>> +MODULE_AUTHOR("Puranjay Mohan <p-mohan@ti.com>");
> >>> +MODULE_AUTHOR("Md Danish Anwar <danishanwar@ti.com>");
> >>> +MODULE_DESCRIPTION("PRUSS ICSSG Ethernet Driver");
> >>> +MODULE_LICENSE("GPL");
> >>
> >> SPDK says GPL-2.0, so perhaps this should be "GPL v2" ?
> >>
>
> I am getting checkpatch warning while changing GPL version.
>
> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure
> the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
> #3602: FILE: drivers/net/ethernet/ti/icssg_prueth.c:1866:
> +MODULE_LICENSE("GPL v2");
>
> Should I ignore this warning and change it to "GPL v2"
I guess that "GPL" is correct after all.
Sorry for the noise.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@corigine.com>
To: Md Danish Anwar <a0501179@ti.com>
Cc: nm@ti.com, andrew@lunn.ch, Vignesh Raghavendra <vigneshr@ti.com>,
Eric Dumazet <edumazet@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
YueHaibing <yuehaibing@huawei.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
devicetree@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
Roger Quadros <rogerq@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
ssantosh@kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com,
Tero Kristo <kristo@kernel.org>,
netdev@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
MD Danish Anwar <danishanwar@ti.com>,
"Andrew F. Davis" <afd@ti.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [EXTERNAL] Re: [RFC PATCH v6 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Fri, 28 Apr 2023 15:47:52 +0200 [thread overview]
Message-ID: <ZEvOiMSIIYG6nmsu@corigine.com> (raw)
In-Reply-To: <ff6fe35f-ca4b-a48d-777f-196b771a14d3@ti.com>
On Fri, Apr 28, 2023 at 02:36:42PM +0530, Md Danish Anwar wrote:
> Hi Simon.
>
> On 27/04/23 12:42, Md Danish Anwar wrote:
> > Hi Simon,
> > Thanks for the comments.
> >
> > On 27/04/23 00:39, Simon Horman wrote:
> >> On Mon, Apr 24, 2023 at 11:02:33AM +0530, MD Danish Anwar wrote:
> >>> From: Roger Quadros <rogerq@ti.com>
> >>>
> >>> This is the Ethernet driver for TI AM654 Silicon rev. 2
> >>> with the ICSSG PRU Sub-system running dual-EMAC firmware.
> >>>
>
> [ ... ]
>
> >>
> >> ...
> >>
> >>> +MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
> >>> +MODULE_AUTHOR("Puranjay Mohan <p-mohan@ti.com>");
> >>> +MODULE_AUTHOR("Md Danish Anwar <danishanwar@ti.com>");
> >>> +MODULE_DESCRIPTION("PRUSS ICSSG Ethernet Driver");
> >>> +MODULE_LICENSE("GPL");
> >>
> >> SPDK says GPL-2.0, so perhaps this should be "GPL v2" ?
> >>
>
> I am getting checkpatch warning while changing GPL version.
>
> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure
> the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
> #3602: FILE: drivers/net/ethernet/ti/icssg_prueth.c:1866:
> +MODULE_LICENSE("GPL v2");
>
> Should I ignore this warning and change it to "GPL v2"
I guess that "GPL" is correct after all.
Sorry for the noise.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-28 13:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 5:32 [RFC PATCH v6 0/2] Introduce ICSSG based ethernet Driver MD Danish Anwar
2023-04-24 5:32 ` MD Danish Anwar
2023-04-24 5:32 ` [RFC PATCH v6 1/2] dt-bindings: net: Add ICSSG Ethernet MD Danish Anwar
2023-04-24 5:32 ` MD Danish Anwar
2023-04-25 18:51 ` Rob Herring
2023-04-25 18:51 ` Rob Herring
2023-04-24 5:32 ` [RFC PATCH v6 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver MD Danish Anwar
2023-04-24 9:58 ` kernel test robot
2023-04-24 16:46 ` kernel test robot
2023-04-26 19:09 ` Simon Horman
2023-04-26 19:09 ` Simon Horman
2023-04-27 7:12 ` [EXTERNAL] " Md Danish Anwar
2023-04-27 7:12 ` Md Danish Anwar
2023-04-28 7:20 ` Simon Horman
2023-04-28 7:20 ` Simon Horman
2023-04-28 9:06 ` Md Danish Anwar
2023-04-28 9:06 ` Md Danish Anwar
2023-04-28 13:47 ` Simon Horman [this message]
2023-04-28 13:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEvOiMSIIYG6nmsu@corigine.com \
--to=simon.horman@corigine.com \
--cc=a0501179@ti.com \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.