* [PATCH] perf tracepoint: Fix memory leak in is_valid_tracepoint()
@ 2023-04-21 2:59 Yang Jihong
2023-04-29 1:59 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Yang Jihong @ 2023-04-21 2:59 UTC (permalink / raw)
To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
namhyung, irogers, adrian.hunter, linux-perf-users, linux-kernel
Cc: yangjihong1
When is_valid_tracepoint() returns 1, need to call put_events_file() to
free `dir_path`.
Fixes: 25a7d914274d ("perf parse-events: Use get/put_events_file()")
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
---
tools/perf/util/tracepoint.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/tracepoint.c b/tools/perf/util/tracepoint.c
index 89ef56c43311..92dd8b455b90 100644
--- a/tools/perf/util/tracepoint.c
+++ b/tools/perf/util/tracepoint.c
@@ -50,6 +50,7 @@ int is_valid_tracepoint(const char *event_string)
sys_dirent->d_name, evt_dirent->d_name);
if (!strcmp(evt_path, event_string)) {
closedir(evt_dir);
+ put_events_file(dir_path);
closedir(sys_dir);
return 1;
}
--
2.30.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf tracepoint: Fix memory leak in is_valid_tracepoint()
2023-04-21 2:59 [PATCH] perf tracepoint: Fix memory leak in is_valid_tracepoint() Yang Jihong
@ 2023-04-29 1:59 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-04-29 1:59 UTC (permalink / raw)
To: Yang Jihong
Cc: peterz, mingo, mark.rutland, alexander.shishkin, jolsa, namhyung,
irogers, adrian.hunter, linux-perf-users, linux-kernel
Em Fri, Apr 21, 2023 at 02:59:53AM +0000, Yang Jihong escreveu:
> When is_valid_tracepoint() returns 1, need to call put_events_file() to
> free `dir_path`.
>
> Fixes: 25a7d914274d ("perf parse-events: Use get/put_events_file()")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Thanks, applied.
- Arnaldo
> ---
> tools/perf/util/tracepoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/tracepoint.c b/tools/perf/util/tracepoint.c
> index 89ef56c43311..92dd8b455b90 100644
> --- a/tools/perf/util/tracepoint.c
> +++ b/tools/perf/util/tracepoint.c
> @@ -50,6 +50,7 @@ int is_valid_tracepoint(const char *event_string)
> sys_dirent->d_name, evt_dirent->d_name);
> if (!strcmp(evt_path, event_string)) {
> closedir(evt_dir);
> + put_events_file(dir_path);
> closedir(sys_dir);
> return 1;
> }
> --
> 2.30.GIT
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-29 1:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-21 2:59 [PATCH] perf tracepoint: Fix memory leak in is_valid_tracepoint() Yang Jihong
2023-04-29 1:59 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.