From: Simon Horman <simon.horman@corigine.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
Cong Wang <cong.wang@bytedance.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>
Subject: Re: [Patch net] vsock: improve tap delivery accuracy
Date: Tue, 2 May 2023 22:02:55 +0200 [thread overview]
Message-ID: <ZFFsb2gvDMiLSY2F@corigine.com> (raw)
In-Reply-To: <20230502174404.668749-1-xiyou.wangcong@gmail.com>
On Tue, May 02, 2023 at 10:44:04AM -0700, Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>
>
> When virtqueue_add_sgs() fails, the skb is put back to send queue,
> we should not deliver the copy to tap device in this case. So we
> need to move virtio_transport_deliver_tap_pkt() down after all
> possible failures.
>
> Fixes: 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks")
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Stefano Garzarella <sgarzare@redhat.com>
> Cc: Bobby Eshleman <bobby.eshleman@bytedance.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-02 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 17:44 [Patch net] vsock: improve tap delivery accuracy Cong Wang
2023-05-02 17:44 ` Cong Wang
2023-05-02 20:02 ` Simon Horman [this message]
2023-05-02 20:14 ` Stefan Hajnoczi
2023-05-02 20:14 ` Stefan Hajnoczi
2023-04-16 4:49 ` Bobby Eshleman
2023-05-03 7:38 ` Stefano Garzarella
2023-05-03 7:38 ` Stefano Garzarella
2023-04-16 6:57 ` Bobby Eshleman
2023-05-03 13:39 ` Stefan Hajnoczi
2023-05-03 13:39 ` Stefan Hajnoczi
2023-04-16 6:40 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFFsb2gvDMiLSY2F@corigine.com \
--to=simon.horman@corigine.com \
--cc=bobby.eshleman@bytedance.com \
--cc=cong.wang@bytedance.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.