* [PATCH] Input: edt-ft5x06: Add delay after waking up
@ 2023-05-05 11:58 Philipp Puschmann
2023-05-05 18:48 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Puschmann @ 2023-05-05 11:58 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, dario.binacchi, michael, Philipp Puschmann
The touch controller needs some time to wake-up after setting the wake-up
gpio. Without having a delay after wake-up probing regularly fails in
edt_ft5x06_ts_identify() with an error (i.e. EREMOTEIO) that was caused
by a failed i2c transfer.
The datasheet sets the wake-up time to 5 ms, although it is not entirely
clear.
Signed-off-by: Philipp Puschmann <p.puschmann@pironex.com>
---
drivers/input/touchscreen/edt-ft5x06.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 24ab9e9f5b21..3a1a5e76cd68 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -1241,6 +1241,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
if (tsdata->wake_gpio) {
usleep_range(5000, 6000);
gpiod_set_value_cansleep(tsdata->wake_gpio, 1);
+ usleep_range(5000, 6000);
}
if (tsdata->reset_gpio) {
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: edt-ft5x06: Add delay after waking up
2023-05-05 11:58 [PATCH] Input: edt-ft5x06: Add delay after waking up Philipp Puschmann
@ 2023-05-05 18:48 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2023-05-05 18:48 UTC (permalink / raw)
To: Philipp Puschmann; +Cc: linux-input, dario.binacchi, michael
On Fri, May 05, 2023 at 01:58:24PM +0200, Philipp Puschmann wrote:
> The touch controller needs some time to wake-up after setting the wake-up
> gpio. Without having a delay after wake-up probing regularly fails in
> edt_ft5x06_ts_identify() with an error (i.e. EREMOTEIO) that was caused
> by a failed i2c transfer.
>
> The datasheet sets the wake-up time to 5 ms, although it is not entirely
> clear.
>
> Signed-off-by: Philipp Puschmann <p.puschmann@pironex.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-05 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05 11:58 [PATCH] Input: edt-ft5x06: Add delay after waking up Philipp Puschmann
2023-05-05 18:48 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.