All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: "Zhang, Cathy" <cathy.zhang@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
	"Srinivas, Suresh" <suresh.srinivas@intel.com>,
	"Chen, Tim C" <tim.c.chen@intel.com>,
	"You, Lizhen" <lizhen.you@intel.com>,
	"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size
Date: Tue, 9 May 2023 10:43:18 +0200	[thread overview]
Message-ID: <ZFoHpoFDkoT77afk@corigine.com> (raw)
In-Reply-To: <CH3PR11MB7345C6C523BDA425215538D8FC769@CH3PR11MB7345.namprd11.prod.outlook.com>

On Tue, May 09, 2023 at 06:57:44AM +0000, Zhang, Cathy wrote:
> 
> 
> > -----Original Message-----
> > From: Jakub Kicinski <kuba@kernel.org>
> > Sent: Tuesday, May 9, 2023 10:06 AM
> > To: Zhang, Cathy <cathy.zhang@intel.com>
> > Cc: edumazet@google.com; davem@davemloft.net; pabeni@redhat.com;
> > Brandeburg, Jesse <jesse.brandeburg@intel.com>; Srinivas, Suresh
> > <suresh.srinivas@intel.com>; Chen, Tim C <tim.c.chen@intel.com>; You,
> > Lizhen <lizhen.you@intel.com>; eric.dumazet@gmail.com;
> > netdev@vger.kernel.org
> > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper
> > size
> > 
> > On Sun,  7 May 2023 19:08:00 -0700 Cathy Zhang wrote:
> > > Fixes: 4890b686f408 ("net: keep sk->sk_forward_alloc as small as
> > > possible")
> > >
> > 
> > Ah, and for your future patches - no empty lines between trailers / tags,
> > please.
> 
> Sorry, I do not quite get your point here. Do you mean there should be no blanks between 'Fixes' line and 'Signed-off-by' line?

I'm not Jakub.
But, yes, I'm pretty sure that is what he means here.

> > 
> > > Signed-off-by: Cathy Zhang <cathy.zhang@intel.com>
> > > Signed-off-by: Lizhen You <lizhen.you@intel.com>
> > > Tested-by: Long Tao <tao.long@intel.com>
> > > Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> > > Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
> > > Reviewed-by: Suresh Srinivas <suresh.srinivas@intel.com>
> 

  reply	other threads:[~2023-05-09  8:43 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08  2:07 [PATCH net-next 0/2] net: fix memcg overhead caused by sk->sk_forward_alloc size Cathy Zhang
2023-05-08  2:08 ` [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size Cathy Zhang
2023-05-09  2:02   ` Jakub Kicinski
2023-05-09  6:52     ` Zhang, Cathy
2023-05-09  2:06   ` Jakub Kicinski
2023-05-09  6:57     ` Zhang, Cathy
2023-05-09  8:43       ` Simon Horman [this message]
2023-05-09  9:36         ` Zhang, Cathy
2023-05-09  9:45           ` Simon Horman
2023-05-09 10:41             ` Zhang, Cathy
2023-05-09  8:48   ` Eric Dumazet
2023-05-09  9:33     ` Zhang, Cathy
2023-05-09  9:51   ` Paolo Abeni
2023-05-09 10:39     ` Zhang, Cathy
2023-05-09 11:01       ` Zhang, Cathy
2023-05-09 11:58         ` Eric Dumazet
2023-05-09 15:07           ` Zhang, Cathy
2023-05-09 15:43             ` Eric Dumazet
     [not found]               ` <CANn89iJvpgXTwGEiXAkFwY3j3RqVhNzJ_6_zmuRb4w7rUA_8Ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-09 16:09                 ` Shakeel Butt
2023-05-09 16:09                   ` Shakeel Butt
     [not found]                   ` <CALvZod6JRuWHftDcH0uw00v=yi_6BKspGCkDA4AbmzLHaLi2Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-10  6:54                     ` Zhang, Cathy
2023-05-10  6:54                       ` Zhang, Cathy
2023-05-10 11:11                     ` Zhang, Cathy
2023-05-10 11:11                       ` Zhang, Cathy
     [not found]                       ` <CH3PR11MB7345ABB947E183AFB7C18322FC779-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-10 11:24                         ` Eric Dumazet
2023-05-10 11:24                           ` Eric Dumazet
     [not found]                           ` <CANn89i+9rQcGey+AJyhR02pTTBNhWN+P78e4a8knfC9F5sx0hQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-10 13:52                             ` Zhang, Cathy
2023-05-10 13:52                               ` Zhang, Cathy
     [not found]                               ` <CH3PR11MB73455A98A232920B322C3976FC779-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-10 15:07                                 ` Eric Dumazet
2023-05-10 15:07                                   ` Eric Dumazet
     [not found]                                   ` <CANn89i+J+ciJGPkWAFKDwhzJERFJr9_2Or=ehpwSTYO14qzHmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-10 16:09                                     ` Zhang, Cathy
2023-05-10 16:09                                       ` Zhang, Cathy
     [not found]                                       ` <CH3PR11MB734502756F495CB9C520494FFC779-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-10 19:00                                         ` Shakeel Butt
2023-05-10 19:00                                           ` Shakeel Butt
     [not found]                                           ` <CALvZod4n+Kwa1sOV9jxiEMTUoO7MaCGWz=wT3MHOuj4t-+9S6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-11  0:53                                             ` Zhang, Cathy
2023-05-11  0:53                                               ` Zhang, Cathy
2023-05-11  6:59                                               ` Zhang, Cathy
2023-05-11  6:59                                                 ` Zhang, Cathy
     [not found]                                                 ` <IA0PR11MB7355E486112E922AA6095CCCFC749-py0Qfd72Ncwkr2bXB6wcV5PPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-11  7:50                                                   ` Eric Dumazet
2023-05-11  7:50                                                     ` Eric Dumazet
2023-05-11  9:26                                                     ` Zhang, Cathy
     [not found]                                                       ` <IA0PR11MB73557DEAB912737FD61D2873FC749-py0Qfd72Ncwkr2bXB6wcV5PPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-11 16:23                                                         ` Shakeel Butt
2023-05-11 16:23                                                           ` Shakeel Butt
     [not found]                                                           ` <CALvZod7Y+SxiopRBXOf1HoDKO=Xh8CNPfgz3Etd4XOq5BPc5Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-11 16:35                                                             ` Eric Dumazet
2023-05-11 16:35                                                               ` Eric Dumazet
     [not found]                                                               ` <CANn89iKoB2hn8QKBw+8faL4MWZ1ByDW8T9UHyS9G-8c11mWdOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-11 17:10                                                                 ` Shakeel Butt
2023-05-11 17:10                                                                   ` Shakeel Butt
2023-05-11 21:18                                                         ` Shakeel Butt
2023-05-11 21:18                                                           ` Shakeel Butt
     [not found]                                                           ` <20230511211338.oi4xwoueqmntsuna-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-05-12  2:38                                                             ` Zhang, Cathy
2023-05-12  2:38                                                               ` Zhang, Cathy
     [not found]                                                               ` <CH3PR11MB734512D5836DBA1F1F3AE7CDFC759-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-12  3:23                                                                 ` Zhang, Cathy
2023-05-12  3:23                                                                   ` Zhang, Cathy
     [not found]                                                                   ` <CH3PR11MB7345F99927E27ED49EEFC6E5FC759-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-12  5:06                                                                     ` Shakeel Butt
2023-05-12  5:06                                                                       ` Shakeel Butt
     [not found]                                                                       ` <20230512050429.22du3gt6rrq6e37a-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-05-12  5:51                                                                         ` Zhang, Cathy
2023-05-12  5:51                                                                           ` Zhang, Cathy
     [not found]                                                                           ` <CH3PR11MB7345DBA6F79282169AAFE9E0FC759-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-12 17:17                                                                             ` Shakeel Butt
2023-05-12 17:17                                                                               ` Shakeel Butt
2023-05-15  3:46                                                                               ` Zhang, Cathy
2023-05-15  4:13                                                                                 ` Shakeel Butt
2023-05-15  4:13                                                                                   ` Shakeel Butt
     [not found]                                                                                   ` <CALvZod7n2yHU8PMn5b39w6E+NhLtBynDKfo1GEfXaa64_tqMWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-15  6:27                                                                                     ` Zhang, Cathy
2023-05-15  6:27                                                                                       ` Zhang, Cathy
     [not found]                                                                                       ` <CH3PR11MB7345E9EAC5917338F1C357C0FC789-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-15 19:50                                                                                         ` Shakeel Butt
2023-05-15 19:50                                                                                           ` Shakeel Butt
     [not found]                                                                                           ` <CALvZod6txDQ9kOHrNFL64XiKxmbVHqMtWNiptUdGt9UuhQVLOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-16  5:46                                                                                             ` Oliver Sang
2023-05-16  5:46                                                                                               ` Oliver Sang
2023-05-17 16:24                                                                                               ` Shakeel Butt
2023-05-17 16:24                                                                                                 ` Shakeel Butt
     [not found]                                                                                                 ` <20230517162447.dztfzmx3hhetfs2q-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-05-17 16:33                                                                                                   ` Eric Dumazet
2023-05-17 16:33                                                                                                     ` Eric Dumazet
     [not found]                                                                                                     ` <CANn89iL0SD=F69b=naEmzoKysscnHGX7tP6jF9MOvthSeZ53Pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-17 17:04                                                                                                       ` Shakeel Butt
2023-05-17 17:04                                                                                                         ` Shakeel Butt
     [not found]                                                                                                         ` <CALvZod6LFdydR5Zdhx1SMgknxTUJgabewi5-Ux6U=nO105GPSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-07-28  2:26                                                                                                           ` Zhang, Cathy
2023-07-28  2:26                                                                                                             ` Zhang, Cathy
2023-05-19  2:53                                                                                                   ` Oliver Sang
2023-05-19  2:53                                                                                                     ` Oliver Sang
2023-05-31  8:46                                                                                                 ` Oliver Sang
2023-05-31  8:46                                                                                                   ` Oliver Sang
2023-05-31 19:45                                                                                                   ` Shakeel Butt
2023-05-31 19:45                                                                                                     ` Shakeel Butt
     [not found]                                                                                                     ` <20230531194520.qhvibyyaqg7vwi6s-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-06-01  2:48                                                                                                       ` Zhang, Cathy
2023-06-01  2:48                                                                                                         ` Zhang, Cathy
     [not found]                                                                                                         ` <CH3PR11MB73454186CA28AE6ACCEA9674FC499-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-06-01  3:21                                                                                                           ` Eric Dumazet
2023-06-01  3:21                                                                                                             ` Eric Dumazet
2023-06-01  2:46                                                                                                   ` Zhang, Cathy
2023-05-10  7:43               ` Zhang, Cathy
     [not found]             ` <CH3PR11MB73458BB403D537CFA96FD8DDFC769-WQKEFoXy4NEXvLLfv6NhPJPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-09 17:58               ` Shakeel Butt
2023-05-09 17:58                 ` Shakeel Butt
     [not found]                 ` <CALvZod6JK1Ts90uGYSDRWXX3-D=gyN3q+Bpy-oW+dqJsjjBm2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-10  7:21                   ` Zhang, Cathy
2023-05-10  7:21                     ` Zhang, Cathy
     [not found]   ` <20230508020801.10702-2-cathy.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2023-05-09 17:19     ` Shakeel Butt
2023-05-09 17:19       ` Shakeel Butt
     [not found]       ` <20230509171910.yka3hucbwfnnq5fq-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2023-05-09 18:04         ` Chen, Tim C
2023-05-09 18:04           ` Chen, Tim C
     [not found]           ` <DM6PR11MB41078CDC3B97ED88AF71DEBFDC769-10zMTfzfexdb1STU19CZ9pPPoyLQLiKMvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2023-05-09 18:17             ` Shakeel Butt
2023-05-09 18:17               ` Shakeel Butt
     [not found]               ` <CALvZod7njXsc0JDHxxi_+0c=owNwC6m1g_FieRfY4XkfuTmo1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-05-10  7:03                 ` Zhang, Cathy
2023-05-10  7:03                   ` Zhang, Cathy
2023-05-10  7:32                   ` Zhang, Cathy
2023-05-10  7:32                     ` Zhang, Cathy
2023-05-08  2:08 ` [PATCH net-next 2/2] net: Add sysctl_reclaim_threshold Cathy Zhang
2023-05-09  2:05   ` Jakub Kicinski
2023-05-09  6:55     ` Zhang, Cathy
2023-05-09 13:36   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFoHpoFDkoT77afk@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=cathy.zhang@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=lizhen.you@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=suresh.srinivas@intel.com \
    --cc=tim.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.