Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size

[Simon Horman <simon.horman@corigine.com>]

On Tue, May 09, 2023 at 09:36:59AM +0000, Zhang, Cathy wrote:
> 
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@corigine.com>
> > Sent: Tuesday, May 9, 2023 4:43 PM
> > To: Zhang, Cathy <cathy.zhang@intel.com>
> > Cc: Jakub Kicinski <kuba@kernel.org>; edumazet@google.com;
> > davem@davemloft.net; pabeni@redhat.com; Brandeburg, Jesse
> > <jesse.brandeburg@intel.com>; Srinivas, Suresh
> > <suresh.srinivas@intel.com>; Chen, Tim C <tim.c.chen@intel.com>; You,
> > Lizhen <lizhen.you@intel.com>; eric.dumazet@gmail.com;
> > netdev@vger.kernel.org
> > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper
> > size
> > 
> > On Tue, May 09, 2023 at 06:57:44AM +0000, Zhang, Cathy wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Jakub Kicinski <kuba@kernel.org>
> > > > Sent: Tuesday, May 9, 2023 10:06 AM
> > > > To: Zhang, Cathy <cathy.zhang@intel.com>
> > > > Cc: edumazet@google.com; davem@davemloft.net; pabeni@redhat.com;
> > > > Brandeburg, Jesse <jesse.brandeburg@intel.com>; Srinivas, Suresh
> > > > <suresh.srinivas@intel.com>; Chen, Tim C <tim.c.chen@intel.com>;
> > > > You, Lizhen <lizhen.you@intel.com>; eric.dumazet@gmail.com;
> > > > netdev@vger.kernel.org
> > > > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as
> > > > a proper size
> > > >
> > > > On Sun,  7 May 2023 19:08:00 -0700 Cathy Zhang wrote:
> > > > > Fixes: 4890b686f408 ("net: keep sk->sk_forward_alloc as small as
> > > > > possible")
> > > > >
> > > >
> > > > Ah, and for your future patches - no empty lines between trailers /
> > > > tags, please.
> > >
> > > Sorry, I do not quite get your point here. Do you mean there should be no
> > blanks between 'Fixes' line and 'Signed-off-by' line?
> > 
> > I'm not Jakub.
> 
> My apologies :-)

Sorry, what I meant here is: I think I know the answer. I could be
wrong, because I am a different person. But I'll try and answer anyway.

> > But, yes, I'm pretty sure that is what he means here.
> 
> Sure, I will pay attention to. For checkpatch.pl does not report error, I submit
> as it.

Yes, perhaps checkpatch.pl could be enhanced in this regard.