All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Simon Horman <horms@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>,
	"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
	kexec@lists.infradead.org, linux-parisc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: kexec: include reboot.h
Date: Wed, 10 May 2023 12:11:47 +0800	[thread overview]
Message-ID: <ZFsZg0fvPA2/eysa@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZFo0Gd/Eucw/0gtC@kernel.org>

On 05/09/23 at 01:52pm, Simon Horman wrote:
> On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
> > On 05/09/23 at 09:01am, Simon Horman wrote:
> > > Include reboot.h in machine_kexec.c for declaration of
> > > machine_crash_shutdown and machine_shutdown.
> > > 
> > > gcc-12 with W=1 reports:
> > > 
> > >  arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> > >     57 | void machine_crash_shutdown(struct pt_regs *regs)
> > >        |      ^~~~~~~~~~~~~~~~~~~~~~
> > >  arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
> > >     61 | void machine_shutdown(void)
> > >        |      ^~~~~~~~~~~~~~~~
> > > 
> > > No functional changes intended.
> > > Compile tested only.
> > > 
> > > Signed-off-by: Simon Horman <horms@kernel.org>
> > 
> > Acked-by: Baoquan He <bhe@redhat.com>
> > 
> > We may need to find out the places in all architectures and fix all of
> > them.
> 
> I did check. It seemed to be needed for riscv, m68k and parisc.
> I've sent out patches for all three. But I may have missed something.

That's great, thanks. I didn't notice the other two.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Simon Horman <horms@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>,
	"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
	kexec@lists.infradead.org, linux-parisc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: kexec: include reboot.h
Date: Wed, 10 May 2023 12:11:47 +0800	[thread overview]
Message-ID: <ZFsZg0fvPA2/eysa@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZFo0Gd/Eucw/0gtC@kernel.org>

On 05/09/23 at 01:52pm, Simon Horman wrote:
> On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
> > On 05/09/23 at 09:01am, Simon Horman wrote:
> > > Include reboot.h in machine_kexec.c for declaration of
> > > machine_crash_shutdown and machine_shutdown.
> > > 
> > > gcc-12 with W=1 reports:
> > > 
> > >  arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
> > >     57 | void machine_crash_shutdown(struct pt_regs *regs)
> > >        |      ^~~~~~~~~~~~~~~~~~~~~~
> > >  arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
> > >     61 | void machine_shutdown(void)
> > >        |      ^~~~~~~~~~~~~~~~
> > > 
> > > No functional changes intended.
> > > Compile tested only.
> > > 
> > > Signed-off-by: Simon Horman <horms@kernel.org>
> > 
> > Acked-by: Baoquan He <bhe@redhat.com>
> > 
> > We may need to find out the places in all architectures and fix all of
> > them.
> 
> I did check. It seemed to be needed for riscv, m68k and parisc.
> I've sent out patches for all three. But I may have missed something.

That's great, thanks. I didn't notice the other two.


  parent reply	other threads:[~2023-05-10  4:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  7:01 [PATCH] parisc: kexec: include reboot.h Simon Horman
2023-05-09  7:01 ` Simon Horman
2023-05-09  9:01 ` Baoquan He
2023-05-09  9:01   ` Baoquan He
2023-05-09 11:52   ` Simon Horman
2023-05-09 11:52     ` Simon Horman
2023-05-09 12:08     ` Helge Deller
2023-05-09 12:08       ` Helge Deller
2023-05-10  4:11     ` Baoquan He [this message]
2023-05-10  4:11       ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFsZg0fvPA2/eysa@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=deller@gmx.de \
    --cc=horms@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.