All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Davis <afd@ti.com>
Cc: Baruch Siach <baruch@tkos.co.il>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/10] ARM: mach-airoha: Rework support and directory structure
Date: Mon, 15 May 2023 17:31:02 +0100	[thread overview]
Message-ID: <ZGJeRiqylcysFPqu@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230515160234.289631-6-afd@ti.com>

On Mon, May 15, 2023 at 11:02:30AM -0500, Andrew Davis wrote:
> Having a platform need a mach-* directory should be seen as a negative,
> it means the platform needs special non-standard handling. ARM64 support
> does not allow mach-* directories at all. While we may not get to that
> given all the non-standard architectures we support, we should still try
> to get as close as we can and reduce the number of mach directories.
> 
> The mach-airoha/ directory, and files within, provide just one "feature":
> having the kernel print the machine name if the DTB does not also contain
> a "model" string (which they always do). To reduce the number of mach-*
> directories let's do without that feature and remove this directory.

I'm guessing this is copy-n-pasted description. However:
> -static const char * const airoha_board_dt_compat[] = {
> -	"airoha,en7523",
> -	NULL,
> -};
> -
> -DT_MACHINE_START(MEDIATEK_DT, "Airoha Cortex-A53 (Device Tree)")
> -	.dt_compat	= airoha_board_dt_compat,
> -MACHINE_END

If this is actually used, then it will have the effect of providing a
"machine" that has both l2c_aux_mask and l2c_aux_val as zero, whereas
the default one has l2c_aux_mask set to ~0.

This has the effect of _not_ calling l2x0_of_init() - but you don't
mention this. You probably should, and you should probably state why
that is safe (assuming you've even realised you've made this change!)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Davis <afd@ti.com>
Cc: Baruch Siach <baruch@tkos.co.il>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/10] ARM: mach-airoha: Rework support and directory structure
Date: Mon, 15 May 2023 17:31:02 +0100	[thread overview]
Message-ID: <ZGJeRiqylcysFPqu@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230515160234.289631-6-afd@ti.com>

On Mon, May 15, 2023 at 11:02:30AM -0500, Andrew Davis wrote:
> Having a platform need a mach-* directory should be seen as a negative,
> it means the platform needs special non-standard handling. ARM64 support
> does not allow mach-* directories at all. While we may not get to that
> given all the non-standard architectures we support, we should still try
> to get as close as we can and reduce the number of mach directories.
> 
> The mach-airoha/ directory, and files within, provide just one "feature":
> having the kernel print the machine name if the DTB does not also contain
> a "model" string (which they always do). To reduce the number of mach-*
> directories let's do without that feature and remove this directory.

I'm guessing this is copy-n-pasted description. However:
> -static const char * const airoha_board_dt_compat[] = {
> -	"airoha,en7523",
> -	NULL,
> -};
> -
> -DT_MACHINE_START(MEDIATEK_DT, "Airoha Cortex-A53 (Device Tree)")
> -	.dt_compat	= airoha_board_dt_compat,
> -MACHINE_END

If this is actually used, then it will have the effect of providing a
"machine" that has both l2c_aux_mask and l2c_aux_val as zero, whereas
the default one has l2c_aux_mask set to ~0.

This has the effect of _not_ calling l2x0_of_init() - but you don't
mention this. You probably should, and you should probably state why
that is safe (assuming you've even realised you've made this change!)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2023-05-15 16:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15 16:02 [PATCH 01/10] ARM: Kconfig: move platform selection into its own Kconfig file Andrew Davis
2023-05-15 16:02 ` Andrew Davis
2023-05-15 16:02 ` [PATCH 02/10] ARM: mach-asm9260: Move ASM9260 support into Kconfig.platforms Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:02 ` [PATCH 03/10] ARM: mach-rda: Move RDA Micro " Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:02 ` [PATCH 04/10] ARM: mach-uniphier: Move Socionext UniPhier " Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:02 ` [PATCH 05/10] ARM: mach-moxart: Move MOXA ART " Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:02 ` [PATCH 06/10] ARM: mach-airoha: Rework support and directory structure Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:31   ` Russell King (Oracle) [this message]
2023-05-15 16:31     ` Russell King (Oracle)
2023-07-13 18:44     ` Andrew Davis
2023-07-13 18:44       ` Andrew Davis
2023-07-14  7:52       ` Arnd Bergmann
2023-07-14  7:52         ` Arnd Bergmann
2023-05-15 16:02 ` [PATCH 07/10] ARM: mach-digicolor: " Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:02 ` [PATCH 08/10] ARM: mach-hpe: " Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-12-22 14:21   ` Arnd Bergmann
2023-12-22 14:21     ` Arnd Bergmann
2023-05-15 16:02 ` [PATCH 09/10] ARM: mach-lpc18xx: " Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:02 ` [PATCH 10/10] ARM: mach-sunplus: " Andrew Davis
2023-05-15 16:02   ` Andrew Davis
2023-05-15 16:31 ` [PATCH 01/10] ARM: Kconfig: move platform selection into its own Kconfig file Andrew Davis
2023-05-15 16:31   ` Andrew Davis
  -- strict thread matches above, loose matches on Subject: below --
2023-03-06 16:34 Andrew Davis
2023-03-06 16:34 ` [PATCH 06/10] ARM: mach-airoha: Rework support and directory structure Andrew Davis
2023-03-06 16:34   ` Andrew Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGJeRiqylcysFPqu@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=afd@ti.com \
    --cc=arnd@arndb.de \
    --cc=baruch@tkos.co.il \
    --cc=geert+renesas@glider.be \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.