All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: rsbecker@nexbridge.com
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [BUG] Git 2.41.0-rc0 - Compile Error ALLOC_GROW
Date: Tue, 16 May 2023 13:06:53 -0400	[thread overview]
Message-ID: <ZGO4LesPe4A2ftdm@nand.local> (raw)
In-Reply-To: <009501d98817$9eb44560$dc1cd020$@nexbridge.com>

On Tue, May 16, 2023 at 12:58:15PM -0400, rsbecker@nexbridge.com wrote:
> Hi Git Team,
>
> I am getting a compile error on rc0:
>
>   	ALLOC_GROW(git_atexit_hdlrs.handlers, git_atexit_hdlrs.nr + 1,
> git_atexit_hdlrs.alloc);
>   	^
> "/home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/run-command.c
> ", line 1103: error(114): identifier "ALLOC_GROW" is undefined
>
> Any help o nthis?

None of the code in run-command.c has changed much recently, but this
bisects to 36bf195890 (alloc.h: move ALLOC_GROW() functions from
cache.h, 2023-02-24).

Note that it only affects when building with NO_PTHREADS=1 (which I
suspect is the case on NonStop). Here's the bisection:

    $ git bisect start
    $ git bisect bad
    $ git bisect good v2.40.0
    $ git bisect run sh -c 'make DEVELOPER=1 NO_PTHREADS=1 run-command.o'

I'll attach a patch in a separate message.

Thanks,
Taylor

  reply	other threads:[~2023-05-16 17:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 16:58 [BUG] Git 2.41.0-rc0 - Compile Error ALLOC_GROW rsbecker
2023-05-16 17:06 ` Taylor Blau [this message]
2023-05-16 17:19   ` Junio C Hamano
2023-05-16 17:24     ` [PATCH] run-command.c: need alloc.h for our own at-exit handler emulation Junio C Hamano
2023-05-16 17:33       ` rsbecker
2023-05-16 17:57       ` Taylor Blau
2023-05-16 18:01         ` Taylor Blau
2023-05-16 18:44           ` Junio C Hamano
2023-05-16 18:47             ` Taylor Blau
2023-05-16 18:53               ` Junio C Hamano
2023-05-16 17:56   ` [PATCH] run-command.c: fix missing include under `NO_PTHREADS` Taylor Blau
2023-05-16 19:12     ` Junio C Hamano
2023-05-16 19:13       ` rsbecker
2023-05-16 21:33       ` Taylor Blau
2023-05-18  4:16         ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGO4LesPe4A2ftdm@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.